Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 31 Dec 2022 19:37:20 +0000
From:   Gary Guo <gary@garyguo.net>
To:     Wedson Almeida Filho <wedsonaf@gmail.com>
Cc:     rust-for-linux@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] rust: sync: allow type of `self` to be `Arc<T>` or
 variants
Message-ID: <20221231193720.4428eb7d.gary@garyguo.net>
In-Reply-To: <20221228060346.352362-2-wedsonaf@gmail.com>
References: <20221228060346.352362-1-wedsonaf@gmail.com>
        <20221228060346.352362-2-wedsonaf@gmail.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MBhNIc8zqisxQCCHOHN6SbHWHG9eL2mIv3sEx+QKSvixQTAbkabQIgNLFmXw?=
 =?us-ascii?Q?M8opMG5ojnL/wRKJaurjlhHRr70NToECXVYX+fZrVvWFXYoRFwIhlN8xXbXK?=
 =?us-ascii?Q?Hz8g3/5jQCqJsDriITpeJncp6Mr5wFqua5qPtY7Kp6PzLs04wxdn/qZT8tVs?=
 =?us-ascii?Q?d46iYCggS6GeBs3HJ7qtUQEiBEqa6+4VlwmLQuaLi/6i/P1QfWACKGCMT2bL?=
 =?us-ascii?Q?Coh2i/MTw6+XegFLL0Yffpyi/BScY8TLj5vRyMqFyornCVF9L6elc0Ec1Bq5?=
 =?us-ascii?Q?sgC7D4jBOJBmDsjTnPDb4m1IzxCIhD8b+rE9S+aRd2G13ybAap8qQ63la3BE?=
 =?us-ascii?Q?HgxCWL/FGwI7u0U/hJdi12K12RznXlsnwrVdwruPuWuYkSwmf7hm4z92sGkN?=
 =?us-ascii?Q?wrA29a8eWLmZjQpTxQfBdYIskxPdDMzsrL5MguXDEDNgUkRdg4xz3w/zjl5A?=
 =?us-ascii?Q?VunuBIG7PX5XRGIxLrZnpDSpMUUniynb5x9ybKSAkKoHvvYIcBUC91X1poSz?=
 =?us-ascii?Q?NLhUMbN5zGsrGrdib1OmEk1G68jUTgZXuYspW+YGcdK2ER37VeZY4K/itJwx?=
 =?us-ascii?Q?MLb2FcyXH4XqyCUpNTCv9Av3CAu67VM8vPe6A1U/EhXHT2onjT2ACYA20FGW?=
 =?us-ascii?Q?BOsp3bag035qbYHRcj0dPG5DN4eCbpn2TeBNhnSeqZBOPHUlLQrKloMuRSJS?=
 =?us-ascii?Q?/NnkztnZ8E7sXlLkiMm7Ny9iSAb34grK2qn7ZfbuIJ/ur381O9VpL3sATkmx?=
 =?us-ascii?Q?azMe3wBGLkjlhGaYqGBDOBRr+Ju98m3/pcFa2qR8fVow/OvNu2uEiP0caoBK?=
 =?us-ascii?Q?/N/Ah0wV155u7i2KTiTj/OZuMneFCFN07fsHfjhGGa7vklPTMsX+Ou7mkkVw?=
 =?us-ascii?Q?7IKUbIa5zo6SqTlX5GGMTz6oKx5ki9qlx3bPNeMTMn3VLc1D8vm+rJNy9r1v?=
 =?us-ascii?Q?4COCDysRSyzAsCQGV+/6Lit5t9xm6mdAawUDuk5iY9S4oF++Y23ScZel64ZT?=
 =?us-ascii?Q?WiOVNMoZwWLtkgN55y/yMmlU+A7pEeknpm69ZSsWcqppDTfRbsYZ+sityxIK?=
 =?us-ascii?Q?WTbSaRUKIu/r6ZcgD3sxU8Mdv4GfcZBqIJ6oDYUBNt+KfDTjjcClrBTDTlia?=
 =?us-ascii?Q?DbQllZzPxUCi9Njzte0r2NXwSXx9AZWtYcz6ejOhxy7a9vO7KHGKFDtjOsXN?=
 =?us-ascii?Q?JmENjAFndiOJGPpKLqigVcaHRhHZBDduIDe7pnNGjh9KmJwN1aMqyF7Qw4o2?=
 =?us-ascii?Q?pQ7KWAh1+ilemfL9wgZQFtWaIhkdgQ2wIDqIWai759zCkrUNYRYsGVZCuAOZ?=
 =?us-ascii?Q?rrbdYjMVt7H5cV2XZnDMCisLoOkR0BqBfxnP4KoY8wrrNdZpnRbz334+sSTj?=
 =?us-ascii?Q?o67kFDjFFWrwqrmfJVHQR9NWnG0h48nGyboTJnU+6mOk5IY3j0Sd63KGxCPP?=
 =?us-ascii?Q?PlO/dSHHs/4604Up9J3O5QwSWEpzhZa9fU74Cm8o+wqOCk+eCVla1w++zHQ+?=
 =?us-ascii?Q?+msMpibOTEtg4N7oDiLjdeNjg/gL87xw9Um8Qv1Q1AhOqkimPMo0BRHjGRLv?=
 =?us-ascii?Q?Talj8PBe7ZihhH1mYj4=3D?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 7dc85e46-9391-4fed-131a-08daeb666f2f
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Dec 2022 19:37:21.2155
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MuNhN803hS9lV4nEeg0Mtt1MkRFHk8nnrYHVms7GkAA6SoMJSBXAqYh1QoiMz595AEEl4feJg/8AhjFYH40YFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB2580
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 28 Dec 2022 06:03:41 +0000
Wedson Almeida Filho <wedsonaf@gmail.com> wrote:

> This allows associated functions whose `self` argument has `Arc<T>` or
> variants as their type. This, in turn, allows callers to use the dot
> syntax to make calls.
> 
> Signed-off-by: Wedson Almeida Filho <wedsonaf@gmail.com>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  rust/kernel/lib.rs      |  1 +
>  rust/kernel/sync/arc.rs | 28 ++++++++++++++++++++++++++++
>  2 files changed, 29 insertions(+)
> 
> diff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs
> index ace064a3702a..1a10f7c0ddd9 100644
> --- a/rust/kernel/lib.rs
> +++ b/rust/kernel/lib.rs
> @@ -14,6 +14,7 @@
>  #![no_std]
>  #![feature(allocator_api)]
>  #![feature(core_ffi_c)]
> +#![feature(receiver_trait)]
>  
>  // Ensure conditional compilation based on the kernel configuration works;
>  // otherwise we may silently break things like initcall handling.
> diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs
> index 22290eb5ab9b..e2eb0e67d483 100644
> --- a/rust/kernel/sync/arc.rs
> +++ b/rust/kernel/sync/arc.rs
> @@ -57,6 +57,31 @@ use core::{marker::PhantomData, ops::Deref, ptr::NonNull};
>  ///
>  /// // The refcount drops to zero when `cloned` goes out of scope, and the memory is freed.
>  /// ```
> +///
> +/// Using `Arc<T>` as the type of `self`:
> +///
> +/// ```
> +/// use kernel::sync::Arc;
> +///
> +/// struct Example {
> +///     a: u32,
> +///     b: u32,
> +/// }
> +///
> +/// impl Example {
> +///     fn take_over(self: Arc<Self>) {
> +///         // ...
> +///     }
> +///
> +///     fn use_reference(self: &Arc<Self>) {
> +///         // ...
> +///     }
> +/// }
> +///
> +/// let obj = Arc::try_new(Example { a: 10, b: 20 })?;
> +/// obj.use_reference();
> +/// obj.take_over();
> +/// ```
>  pub struct Arc<T: ?Sized> {
>      ptr: NonNull<ArcInner<T>>,
>      _p: PhantomData<ArcInner<T>>,
> @@ -68,6 +93,9 @@ struct ArcInner<T: ?Sized> {
>      data: T,
>  }
>  
> +// This is to allow [`Arc`] (and variants) to be used as the type of `self`.
> +impl<T: ?Sized> core::ops::Receiver for Arc<T> {}
> +
>  // SAFETY: It is safe to send `Arc<T>` to another thread when the underlying `T` is `Sync` because
>  // it effectively means sharing `&T` (which is safe because `T` is `Sync`); additionally, it needs
>  // `T` to be `Send` because any thread that has an `Arc<T>` may ultimately access `T` directly, for