Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 31 Dec 2022 19:44:14 +0000
From:   Gary Guo <gary@garyguo.net>
To:     Wedson Almeida Filho <wedsonaf@gmail.com>
Cc:     rust-for-linux@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] rust: sync: allow type of `self` to be
 `ArcBorrow<T>`
Message-ID: <20221231194414.3f66d8af.gary@garyguo.net>
In-Reply-To: <20221228060346.352362-5-wedsonaf@gmail.com>
References: <20221228060346.352362-1-wedsonaf@gmail.com>
        <20221228060346.352362-5-wedsonaf@gmail.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HN2tZEM7soJAPmgBoMyhoQkzoilYpe88//3VMYVUYFu0CUcYwnpL+isb63Bn?=
 =?us-ascii?Q?5oosSYAvtvALAfvNB/D65GCFKswbXm1PiDoW+yPbVuU5wdd9Q6MQrVwiEQnO?=
 =?us-ascii?Q?kEL2Te9oIO7DU5679P0p0gkP+QQW9jxjJlh/l2qvLObZMbltKHkLUnw9sjsU?=
 =?us-ascii?Q?zCMfXkxFrU9mErQnfR0xQeWxZ5I9yHFZuL1weNt9BdTWT+gPhNBqFerUlg8O?=
 =?us-ascii?Q?RRIgPwQKMLyJ0Eb9E4zUtA1BmxbxSWbdDmyE25vw6Jbwsswjj+EEY5m7WK22?=
 =?us-ascii?Q?AnUVydqESVBCmus2jl6aAcdx2I6cny5QlzDGphczZPcT5J1m6yQde1JPpSF6?=
 =?us-ascii?Q?ZJeSL+lmODZcdjCLKlDv0SdweHp1JmanSfaI26oUZUhatgDdM+BnqsezY6Qs?=
 =?us-ascii?Q?eNkveufnvYqua2+syIEwzoXBvuUW4sa4K2jctrbrJNERx/AoR0elQ9+GowVE?=
 =?us-ascii?Q?vVVdOMJ7LAG/PXYadfp/9rdiltsjysCwi9yRr9OEEduVAQyIl1UBr1HykIsw?=
 =?us-ascii?Q?UMrEbCUHXpqNNd03/jOqAVQZ9MEksOAKaUaxIoV3xPzKxugZS89qkWlpat2M?=
 =?us-ascii?Q?/161fLB8SaQY1nCKbwcK4nNvn1lQMWMbV5xcuAoAfedwtlVhN0yZzSV8xMYT?=
 =?us-ascii?Q?cgnDGBKl8oxHk71lyQo+5WoHEKWfw9tmAQ8PaIQ6VkLf67uIYKGGyZ189Ddp?=
 =?us-ascii?Q?Xu8SY0mVaI7OXABqDZ9DpFtyvIaASsejlCM0aVSTad+k7MKu81Ip67K7wYtX?=
 =?us-ascii?Q?30f/pp3shJJ8n596SYgb2NLYQZRs8dWUUomNQlY3wJL+lFMySH7tTSkRt2H2?=
 =?us-ascii?Q?q/SNlEcLiiK3GQtMar42Nm5SsX9N13cs6xVfToDO1/FWiWsvBV+O1ZIg0z9Z?=
 =?us-ascii?Q?5286kGZxaouIKmEqKLb2x8kZSoC6LI0gOcZNaBoJJeMAmJAhi7jRNcBRxdd4?=
 =?us-ascii?Q?aYX1oCO9H5Ib5wVdfnPIR0gJeSDoLfyNH9eOPib2GvBzFUDR2ZqJQlqsj6J9?=
 =?us-ascii?Q?qQvgZqV7P1YzC+I/mpu5JUIjYSKEq9aDzZNRFkWfuDnarUQe4BrdWAnZndri?=
 =?us-ascii?Q?j6G1ToI8i31ZGcY+BsU5Db7uyp6ld6ckbS2oJwZgkU2V/OOS5AtKaZfgSmYf?=
 =?us-ascii?Q?4WbjAEVoHyVypzRRou0UBuux7q/LjJdTu3F9b1XjfBsCHEDMe+4kPtLUwQlc?=
 =?us-ascii?Q?aQuUjaA33zb/K4rBsSw9zQthYa5VSgpL0HSXqB0WLE4YKEYGPJaFFXRMuEjc?=
 =?us-ascii?Q?IR6kc6whXe4CIqwzHYa4ZwCzYbcselclMlDhNqvkkZTvpLFnjm6mQHeGrzez?=
 =?us-ascii?Q?cilKCX8THRsFjVTHS8z1nj/mC2yzjqSNpdAZFjzaSJ0kyEMVNfZevGDbiph+?=
 =?us-ascii?Q?7Niq4h8QKXFI1Nj+G7ETCJ8DqrRKexeEKd884SdQ0xgKl8rTHfaps9Km4LCg?=
 =?us-ascii?Q?z8XimJx6muF/seZlLxDLPwEp6oLtmzM1WKr71/LxUnVgRTk7AXAVuyOENIa4?=
 =?us-ascii?Q?sIDzVpIE7z/DcY4gPnsKl79lAqiNwltC+7vk/tPt4rzJsk2iiYc3ZU21FlAk?=
 =?us-ascii?Q?4McbMOoy/l06HwPiG0U=3D?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 6187456e-47bc-46df-39aa-08daeb6765e2
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Dec 2022 19:44:15.0923
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UTgtFbIeR+r2r6sgsT0/Y+IzKvxwuji6+N2t7gEByWpsEh5yegiWQRT5fIdzxbxPzicOWzF2z/b4jBiAkk5tdw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO6P265MB6473
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 28 Dec 2022 06:03:44 +0000
Wedson Almeida Filho <wedsonaf@gmail.com> wrote:

> This allows associated functions whose `self` argument has
> `ArcBorrow<T>` as their type. This, in turn, allows callers to use the
> dot syntax to make calls.
> 
> Signed-off-by: Wedson Almeida Filho <wedsonaf@gmail.com>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  rust/kernel/sync/arc.rs | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs
> index f68bfc02c81a..84f31c85a513 100644
> --- a/rust/kernel/sync/arc.rs
> +++ b/rust/kernel/sync/arc.rs
> @@ -255,11 +255,34 @@ impl<T: ?Sized> Drop for Arc<T> {
>  /// // Assert that both `obj` and `cloned` point to the same underlying object.
>  /// assert!(core::ptr::eq(&*obj, &*cloned));
>  /// ```
> +///
> +/// Using `ArcBorrow<T>` as the type of `self`:
> +///
> +/// ```
> +/// use crate::sync::{Arc, ArcBorrow};
> +///
> +/// struct Example {
> +///     a: u32,
> +///     b: u32,
> +/// }
> +///
> +/// impl Example {
> +///     fn use_reference(self: ArcBorrow<'_, Self>) {
> +///         // ...
> +///     }
> +/// }
> +///
> +/// let obj = Arc::try_new(Example { a: 10, b: 20 })?;
> +/// obj.as_arc_borrow().use_reference();
> +/// ```
>  pub struct ArcBorrow<'a, T: ?Sized + 'a> {
>      inner: NonNull<ArcInner<T>>,
>      _p: PhantomData<&'a ()>,
>  }
>  
> +// This is to allow [`ArcBorrow`] (and variants) to be used as the type of `self`.
> +impl<T: ?Sized> core::ops::Receiver for ArcBorrow<'_, T> {}
> +
>  impl<T: ?Sized> Clone for ArcBorrow<'_, T> {
>      fn clone(&self) -> Self {
>          *self