Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 31 Dec 2022 20:01:19 +0000
From:   Gary Guo <gary@garyguo.net>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        =?UTF-8?B?Qmo=?= =?UTF-8?B?w7Zybg==?= Roy Baron 
        <bjorn3_gh@protonmail.com>, Boqun Feng <boqun.feng@gmail.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Nicolas Schier <nicolas@fjasle.eu>, Tom Rix <trix@redhat.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        llvm@lists.linux.dev, rust-for-linux@vger.kernel.org
Subject: Re: [PATCH 1/6] kbuild: specify output names separately for each
 emission type from rustc
Message-ID: <20221231200119.227f622d.gary@garyguo.net>
In-Reply-To: <20221231064203.1623793-2-masahiroy@kernel.org>
References: <20221231064203.1623793-1-masahiroy@kernel.org>
        <20221231064203.1623793-2-masahiroy@kernel.org>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jbbuHtAkkmluhmZDVFxSPHLzd+3N3mBBvJD+aGLpzLHjTrXRjQwLl+zpMzoT?=
 =?us-ascii?Q?U88f/vpVxmW9dOc9o84qw4jQZLwRRlroqDOdGZMG+WMQT8OMS/gUP6BRBH2Y?=
 =?us-ascii?Q?0u/iaU+b1c+0hkpn4arQbbnlVT9z/YjfkAgFOjxnoU5egKstQWUZmVBo9tkX?=
 =?us-ascii?Q?sSuO71B1LMJrXbcENR20YfGUzaNmoc3ifCM5LtIk4gywyY+xuVxfEUYi3T18?=
 =?us-ascii?Q?Z6ovCPv47PNVPig6/nxcCFXxrhKWbsprj26TIlVptQce51dIaJque6QXBH6E?=
 =?us-ascii?Q?47iS+cmtoRofFvejvA3qetezYaIUcx2UBbP1HHnbnNzrn8ttO/0+QNEuXiJs?=
 =?us-ascii?Q?bXtnRfDZk84jJ2btqq+5mApsHN0y3tWce/QIhwL9/u0vzkCkfPKnJ593EX1+?=
 =?us-ascii?Q?GZh8rE48cr982bAJaZonEw+tG/dY/XavxGn8u1qSWpEOkJ4DIJ6Tt0u8F+be?=
 =?us-ascii?Q?z9LgYbqEQ49UGNHR/gzgL4KIgJyMb5Yfc4N7/l8oVJ+6yt5TLJGQeThdMCvG?=
 =?us-ascii?Q?j3ZwOAz8WorR/3lgXTwHM8QKo+K39nAIc7DuX0gHF9FMt5j4m0pm23SQcW8K?=
 =?us-ascii?Q?wkCyeIyuTvSr5hopqAwriRuttBNRsn3rJS2NNGwqWn3ceqKk1XUm1sFIC7jX?=
 =?us-ascii?Q?8jqScPRvPfksAzu6zMtM9e/FNDMfKBZDcikKbMYTOr2Q0eVkbYTwmmqNNUfk?=
 =?us-ascii?Q?xU+eoxmoTi+3aYhV7r297qxMfy66aEfCKiyP9LKq+7xFsPZu97jOE8oxvIcN?=
 =?us-ascii?Q?sQieO2ZMA6BzydtJrfkWWOlVaNxETo2V+ypgNAbODrAVN9klpXd8ofPhOnKo?=
 =?us-ascii?Q?xMCwSU1wfSILNMxuBbuh6vqLqvOqUKbxyecuzm5EjqFEOiwZZLatimtA9Soy?=
 =?us-ascii?Q?i31hP6L9uNaVz5emEzZKBDJ7dTs6tuUM8QeIwAwRwe0uB6Yd4MENCUhxW+EN?=
 =?us-ascii?Q?ip57/Lz90yYzYdmg6SPjdR89T0Lgf6td7l1XLMU4AVxXoVrAQC4K0F7ddeEw?=
 =?us-ascii?Q?7f62+dSznCPhedjecJdY5lAEsOmp8+KYGX8TdH0XzSJ0hZaD9935l4oGU65w?=
 =?us-ascii?Q?iqtrxw32bmYinRAoHx2Q7KfuFMk8iOif/uOqDydJdu5nHINES9XU+v9fRQaW?=
 =?us-ascii?Q?12eqWev2W7lOblyklTxG/R//+cY4wVK7S8RxKva7fr6AB4XQZrNy/GJxhosU?=
 =?us-ascii?Q?yj7Ui3pq6qxdjO06AliOiTG3rwaVxe+Vugm+pXNH2EjvYm8EgyZJLtRc09pb?=
 =?us-ascii?Q?t3rPajqcYUrAJxnbYj5Jaghwi3NNizYGC0o/LFbJRFIoklcrrO6SJStz47D2?=
 =?us-ascii?Q?2IKOO0r8+vyOw+Gvjn0Pgxa60QmKLT8y5fJA9jk46ORsZkhWhkn7SU9kue+i?=
 =?us-ascii?Q?N/WbdKEvZhrhbPNepTu72tMxZEnMhKgOVKsXgl3rWpTtpUaCVRub2d/H7Bc+?=
 =?us-ascii?Q?QtodAYWHMrfPI5YadPdUtexyBOi6eb0ZA0chwYbkjfF4I7tCPvjopqgDF9vS?=
 =?us-ascii?Q?AGwJEBGP8xEf9kWDqgS7jgTHkHh6+Rw9E/0dNupGt3WztRtFaGAcZo+hOdWo?=
 =?us-ascii?Q?PNfpBKwrIiz9/QqhbfNXRqLDGakTLsI0/umitUuc?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 25576835-f255-47f2-2333-08daeb69c949
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Dec 2022 20:01:20.8703
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZXZcwZAgBrk1VzVztbVIa2K+ZGXdgsBd6YZNkmMTaUlJKGgl28bY/G+Zv3wH2fKrXmcF1sczOTbrPlkPqz4eOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB2545
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 31 Dec 2022 15:41:58 +0900
Masahiro Yamada <masahiroy@kernel.org> wrote:

> diff --git a/scripts/Makefile.host b/scripts/Makefile.host
> index da133780b751..4434cdbf7b8e 100644
> --- a/scripts/Makefile.host
> +++ b/scripts/Makefile.host
> @@ -84,8 +84,8 @@ _hostc_flags   = $(KBUILD_HOSTCFLAGS)   $(HOST_EXTRACFLAGS)   \
>                   $(HOSTCFLAGS_$(target-stem).o)
>  _hostcxx_flags = $(KBUILD_HOSTCXXFLAGS) $(HOST_EXTRACXXFLAGS) \
>                   $(HOSTCXXFLAGS_$(target-stem).o)
> -_hostrust_flags = $(KBUILD_HOSTRUSTFLAGS) $(HOST_EXTRARUSTFLAGS) \
> -                  $(HOSTRUSTFLAGS_$(target-stem))
> +hostrust_flags = $(KBUILD_HOSTRUSTFLAGS) $(HOST_EXTRARUSTFLAGS) \
> +                  $(HOSTRUSTFLAGS_$(target-stem)) --emit=dep-info=$(depfile)
>  
>  # $(objtree)/$(obj) for including generated headers from checkin source files
>  ifeq ($(KBUILD_EXTMOD),)
> @@ -97,7 +97,6 @@ endif
>  
>  hostc_flags    = -Wp,-MMD,$(depfile) $(_hostc_flags)
>  hostcxx_flags  = -Wp,-MMD,$(depfile) $(_hostcxx_flags)
> -hostrust_flags = $(_hostrust_flags)

Would it be better to have `--emit=dep-info=$(depfile)` added here
instead so that it mimics c/cxx flags?

>  
>  #####
>  # Compile programs on the host
> @@ -149,9 +148,7 @@ $(host-cxxobjs): $(obj)/%.o: $(src)/%.cc FORCE
>  # host-rust -> Executable
>  quiet_cmd_host-rust	= HOSTRUSTC $@
>        cmd_host-rust	= \
> -	$(HOSTRUSTC) $(hostrust_flags) --emit=dep-info,link \
> -		--out-dir=$(obj)/ $<; \
> -	mv $(obj)/$(target-stem).d $(depfile); \
> +	$(HOSTRUSTC) $(hostrust_flags) --emit=link=$@ $<; \
>  	sed -i '/^\#/d' $(depfile)
>  $(host-rust): $(obj)/%: $(src)/%.rs FORCE
>  	$(call if_changed_dep,host-rust)

Best,
Gary