Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 31 Dec 2022 19:51:54 +0000
From:   Gary Guo <gary@garyguo.net>
To:     Laine Taffin Altman <alexanderaltman@me.com>
Cc:     Wedson Almeida Filho <wedsonaf@gmail.com>,
        rust-for-linux@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/7] rust: sync: add support for dispatching on Arc and
 ArcBorrow.
Message-ID: <20221231195154.24c07869.gary@garyguo.net>
In-Reply-To: <D0EB09C0-A9F6-4AB3-B9A2-98ACDAA25DAD@me.com>
References: <20221228060346.352362-1-wedsonaf@gmail.com>
        <20221228060346.352362-7-wedsonaf@gmail.com>
        <D0EB09C0-A9F6-4AB3-B9A2-98ACDAA25DAD@me.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1+Pt30j/jrx0mKYdM1z+Wq/1S3dXZC7oV0q+XIllThe6a3Fvols7s+XYT+5m?=
 =?us-ascii?Q?tNhF3wD/S1r1lYFxvYIRLVgJfJwpehXXL2XPqHRFHLtZsFP9MrfHyZFO4OKL?=
 =?us-ascii?Q?Fc7TDD6oJ8ZzSyOd00KSYvyDbV9slPeYb8AHzwWNl9VEU7BxdcUO9NzEl4E1?=
 =?us-ascii?Q?j1ajr6lu4P/SiNBoTk2eBgfdQYq03lcqaceu7/Butd+6nJtK4hY4dH9fP21o?=
 =?us-ascii?Q?tQoL31+h898M20fQJYX9Y+hvfTsL1G0VpeViOj+Se+wuuSetcQhPDMKUmNbI?=
 =?us-ascii?Q?rwVlemU17vzJFjxEw8iQpVWux+cVb4il+R+In7ZoR1++4z/gLpLZeGwoHEoJ?=
 =?us-ascii?Q?z234A0PWAftw11i5JVwjFNMbQc9REM+Ah7EQjk49gz2AkFfhULA0XTb9qf57?=
 =?us-ascii?Q?8GlI6/uiMfU8MYBVV3rKSC9Yf9RvkLYF2UzoMvP+KTqvjGhBuhtS+NWKQlbi?=
 =?us-ascii?Q?Mm7QlBs6oL4AM40brcEBiD8T+4VeC6qWRjgY4LmosQKhrHqjPkybBSuiNsWf?=
 =?us-ascii?Q?knx6VrMcLiMnknFyRTc5n+Mo9XjaOMycPpuFVgLLTrOag2fxK5mI5pdCZEkr?=
 =?us-ascii?Q?0ZR0ndmFiP/dCOA1P/I2Mq/xgHVyox/HqCbx2v9eGdoBi0Jf2dEmhJocZ5dl?=
 =?us-ascii?Q?iMge8UFUXzTMaQzAPnCIY5QCjDeUfuaJRmHJgE1eR0HEKyThG4bs6HEx8lPJ?=
 =?us-ascii?Q?p3WJW1P9P8OvYIPkpAqlbMmeCLGLbZkBTs83SaOWbnoKEBcRfO5OV3asUTrI?=
 =?us-ascii?Q?MSiKcBqH38tVUFijQmW9fwAp1rIwY1N6F25VUCyCfCDLI0oy26Bv0Es/Fuv8?=
 =?us-ascii?Q?NXSbbvWgqnvgQeiF0y1sjpmwgO7y/sntZAn47WQzzsLPbDYADyfTEIHBFGri?=
 =?us-ascii?Q?p+3vo7UhDbRriv4k++05tES++QYam2hWuPtX/npi4/az4kXp2DqGI+T3HJC1?=
 =?us-ascii?Q?WBm7TuMFVpmZVtzY/XKQ8/M8qxXLdDJPooqJirvrJeW9KiBVvZ7U7P539oWJ?=
 =?us-ascii?Q?6XBDOvNJZDPqhAP25y262G7IeASmnkXwiAc4JHruWDO8PV78bkUC1BHAdMc7?=
 =?us-ascii?Q?swgFW0KPjJkBFRZcVu4lbAD/Z+5KKq1mZxe1rPiaL4dx2GQAR9/Qk+KJZU0u?=
 =?us-ascii?Q?+bPfR/XYxKr3HM50mmLlEueu3xskl9wJNkCeLlLczCr6TbkGLaz9VZU5fa9z?=
 =?us-ascii?Q?sz4dVn0TvLB7ljgA/+qRHyqBJfnh25v4C/8bbhyUm1HkytioonTXDOimEKLS?=
 =?us-ascii?Q?WhDYJmNQwQXh+plrwdSlyQ1PGeQhyHm13zljhhxio5d6A2z7pG6y7fk5NpXG?=
 =?us-ascii?Q?ogvcxA8JRyNgVrbcxDYsHtYdKBVDK6yJBB2AV6QayEvMUUpMbJhgCvhHhq/L?=
 =?us-ascii?Q?06jmDbwRGwjjMaVK7XItr4VlykpKso+HQViCElf/6kKdes7R2RetXAtGNKJt?=
 =?us-ascii?Q?OnndVWwl9fC+zbxlTvh4aS48hS+LUaJLxxYxMVLxO+ayFU9VuB7ZMhfBDyfk?=
 =?us-ascii?Q?5DZ/eXuVnRY3byfg+tCdbakyEhPALg+XdyWY5hTc/yRTalUoCEaqbcNTQOoa?=
 =?us-ascii?Q?n9VhSyMPtP51ETJ6a0k=3D?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f317a50-6a4c-4c1c-5770-08daeb68788b
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Dec 2022 19:51:55.8819
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aik1dM82xqUvMjxD6McFYxKKlHVDlYBGLmxMVAqTgHZ7UcQxE25Dg9KrWGE66A2nCpIP+v6V8KrSUtWJbdDiPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB5403
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 27 Dec 2022 23:24:37 -0800
Laine Taffin Altman <alexanderaltman@me.com> wrote:

> > +// This is to allow `ArcBorrow<U>` to be dispatched on when `ArcBorrow<T>` can be coerced into
> > +// `ArcBorrow<U>`.
> > +impl<T: ?Sized + Unsize<U>, U: ?Sized> core::ops::DispatchFromDyn<ArcBorrow<'_, U>>
> > +    for ArcBorrow<'_, T>  
> 
> These lifetimes need to be tied together, I think.
> `impl<'a, T: ?Sized + Unsize<U> + 'a, U: ?Sized + 'a> core::ops::DispatchFromDyn<ArcBorrow<'a, U>> for ArcBorrow<'a, T>`

I don't think this is necessary, libcore has the following code
(https://doc.rust-lang.org/stable/src/core/ops/unsize.rs.html#123):

impl<'a, T: ?Sized + Unsize<U>, U: ?Sized> core::ops::DispatchFromDyn<&'a U> for &'a T {}

which should be equivalent to Wedson's lifetime elided version.

Best,
Gary