Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 31 Dec 2022 19:46:58 +0000
From:   Gary Guo <gary@garyguo.net>
To:     Laine Taffin Altman <alexanderaltman@me.com>
Cc:     Wedson Almeida Filho <wedsonaf@gmail.com>,
        rust-for-linux@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] rust: sync: introduce `UniqueArc`
Message-ID: <20221231194658.4f45055d.gary@garyguo.net>
In-Reply-To: <792D12DA-73F0-4218-B0E1-7A0D8C235C21@me.com>
References: <20221228060346.352362-1-wedsonaf@gmail.com>
        <20221228060346.352362-6-wedsonaf@gmail.com>
        <792D12DA-73F0-4218-B0E1-7A0D8C235C21@me.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gJ8PlFxYwQa2vPl7u2t5ACkM9whurhW3CnaeN26+ZRduXT3lcl/lwOM6WEam?=
 =?us-ascii?Q?l0MFl9AhbsvtVBJWk4VYsbkyNXi0dgDL32h6hnHQTvKdUMxXKHcIKT3gmiiK?=
 =?us-ascii?Q?HUcYcXIZQsSFE06FpAMove8WmsMWJLoVfvQJDOZyqcEuIa74Fu6sgudss992?=
 =?us-ascii?Q?AW17OiQBLGNGjZlH0g7geEjnUIVksubMVWEbxLBixeePfWaliM9ZBlVb92a7?=
 =?us-ascii?Q?uiBFhJvRPcZEvkGZAwo4WavTQqUko2u7WDGi5wd4j+6yZnr6/yVVONdboKNA?=
 =?us-ascii?Q?dCsbTWm+I28SCXmS39kg2MDF54EqpXb+Bv7dFEHI+gxA5w678LGatUVXvA9w?=
 =?us-ascii?Q?jt3PWcVL+JChZrR4svg9WDY/vfJenHjgEVhsocreiterSFepoNQNcuY5YZ/w?=
 =?us-ascii?Q?I/H9C6bceO6k3psr9OOpbK2LwABMlp1P8aOG9IafsgrolVOS06vZvzL6bFQ3?=
 =?us-ascii?Q?fbRTQ7lj4K2iJsODHhsgxAXj7rLsN1yKCoFBqBEAFXGg1bpzO7vlS3DVPqqU?=
 =?us-ascii?Q?RFY0O8bZyh90GViJywHZjj9axdyESryu3P3Utr6LcnlPOIZLVf5NcaOK59SL?=
 =?us-ascii?Q?TPgUyXpg/5zmi4fy28OJ7f4PYZOUqbiIUGtYPseIsSQtnNZ6yitlIhWg8Kpm?=
 =?us-ascii?Q?PHkHUEazexnE06dEBPucN2kmxzgdOv3/u0sNwYe2r61HZsIrdGGb+O82wpPA?=
 =?us-ascii?Q?kaBCq8Lo/HjKhJzQSdwtHyos+pq8mN11crh+1dI0hFgC1PFgP+1aPlX+Ihj0?=
 =?us-ascii?Q?iHhpFtZa7yGQKIedysQ1pjUlYTVEpi3Tt8ZfF5WxIL1izDRnBxM5+V46L3Wr?=
 =?us-ascii?Q?Q6WoS7VgAOy/nyO04q318ZRZiVQcga3Tw3ga1dXA+HG2KkSes8G6O1PzTnIW?=
 =?us-ascii?Q?33WT95eTPgYDna03RQC57CkuMbAzXBBkFbM+RrFRRVphR5dUKl0ImmVaC2KT?=
 =?us-ascii?Q?eBb1qRKUBxacu2vt3TekraCUkye2/yaKKVntSMPlgpqJ3bwr0JE4aOf6eswN?=
 =?us-ascii?Q?gGLmVGjmR066mIcE00Q+xCOTseo+UTQkU1Zy94RTyPOYWiKQxz6REKNRnhqn?=
 =?us-ascii?Q?3V4BCip5y3rZJX43OnlERDVOkAoUhoxlRA7JsZTQdsKQ15PhiNYJqumNgkNK?=
 =?us-ascii?Q?iR/YigmWDvb1Wg7OJwxYu32cj8K6uF02ooh85yEzVeg8wavB6kgDKQBMcs6E?=
 =?us-ascii?Q?MzNq/oQsT2SFZmb21GvN1lv0aYRaWx4bjVQ2RCm837ptlACnG8Y+5Z74OVEm?=
 =?us-ascii?Q?Ht9skaVTsOvzJu0w42ROxHn9B2o64O9esto4F0RSfTjihUVv5Y4mtCoqnfxt?=
 =?us-ascii?Q?BzaNqHggz/H+gXkk/iAFOl21STo/LSBtduPSt+8ggZmmcgdV+Y5QvvHOHbTd?=
 =?us-ascii?Q?kXLzPmoZdT14OrErE9wJ9HB8FOryyMdyNsfli+F8lL+uDuM+1gAaA0hiwVC7?=
 =?us-ascii?Q?n+Gd1Aw7ypg7n9SIx81k0sqpQHOCYRWlWE77yUyxZ4PZMDlagpJ9srYBRJNu?=
 =?us-ascii?Q?f6vZYovrsfhsP5ZQrWI5Soj640FRSZepayhTBW5vd+Qf86ETwLRxUKtL6wSn?=
 =?us-ascii?Q?ccQRFebt3eAs2Ls0Tvw=3D?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: ee70ac92-6168-4650-47da-08daeb67c82c
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Dec 2022 19:47:00.0256
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E9rAo2HGmTyltoiMjm5U7EbUMdlGSW/sIqlDnjoBLAkK0J3RezJxMQZPR6AXLgmuk71Hs4i3jb6CRgJOg01mMg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB5403
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 27 Dec 2022 23:19:52 -0800
Laine Taffin Altman <alexanderaltman@me.com> wrote:

> > +impl<T: ?Sized> From<UniqueArc<T>> for Pin<UniqueArc<T>> {
> > +    fn from(obj: UniqueArc<T>) -> Self {
> > +        // SAFETY: It is not possible to move/replace `T` inside a `Pin<UniqueArc<T>>` (unless `T`  
> 
> Minor nit:  `Pin<UniqueArc<T>>` in this comment should just be `UniqueArc<T>`.

No, the current comment is correct. It's possible to move `T` inside
`UniqueArc<T>` (because it implements `DerefMut`).

Best,
Gary Guo