Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 31 Dec 2022 15:55:17 -0500 (EST)
From:   Nicolas Pitre <nico@fluxnic.net>
To:     Ira Weiny <ira.weiny@intel.com>
cc:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        Christian Brauner <brauner@kernel.org>,
        linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
        "Venkataramanan, Anirudh" <anirudh.venkataramanan@intel.com>
Subject: Re: [PATCH] fs/cramfs: Convert kmap() to kmap_local_data()
In-Reply-To: <Y69mtbmmbDcXhiln@iweiny-desk3>
Message-ID: <210n4959-p557-894p-20qp-r595540r0827@syhkavp.arg>
References: <20221012091356.16632-1-fmdefrancesco@gmail.com> <Y69mtbmmbDcXhiln@iweiny-desk3>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-1989546398-1672520118=:4092182"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-1989546398-1672520118=:4092182
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Fri, 30 Dec 2022, Ira Weiny wrote:

> On Wed, Oct 12, 2022 at 11:13:56AM +0200, Fabio M. De Francesco wrote:
> > The use of kmap() is being deprecated in favor of kmap_local_page().
> >=20
> > There are two main problems with kmap(): (1) It comes with an overhea=
d as
> > the mapping space is restricted and protected by a global lock for
> > synchronization and (2) it also requires global TLB invalidation when=
 the
> > kmap=E2=80=99s pool wraps and it might block when the mapping space i=
s fully
> > utilized until a slot becomes available.
> >=20
> > With kmap_local_page() the mappings are per thread, CPU local, can ta=
ke
> > page faults, and can be called from any context (including interrupts=
).
> > It is faster than kmap() in kernels with HIGHMEM enabled. Furthermore=
,
> > the tasks can be preempted and, when they are scheduled to run again,=
 the
> > kernel virtual addresses are restored and still valid.
> >=20
> > Since its use in fs/cramfs is safe everywhere, it should be preferred=
.
> >=20
> > Therefore, replace kmap() with kmap_local_page() in fs/cramfs. Instea=
d
> > of open-coding kmap_local_page() + memcpy(), use memcpy_from_page().
> >=20
> > Cc: "Venkataramanan, Anirudh" <anirudh.venkataramanan@intel.com>
> > Suggested-by: Ira Weiny <ira.weiny@intel.com>
>=20
> Nicolas, I was auditing the kmap conversion status and I see you review=
ed this
> but did not merge it.  Are you still the maintainer for fs/cramfs?  Sho=
uld
> Fabio send this to someone else?

Please send it to Al Viro with my reviewed-by.


Nicolas
--8323328-1989546398-1672520118=:4092182--