Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b5a0c3cb115e3408094c434e486f009aef7a9585.camel@svanheule.net>
Subject: Re: [PATCH] watchdog: realtek_otto: Use devm_clk_get_enabled()
 helper
From:   Sander Vanheule <sander@svanheule.net>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Guenter Roeck <linux@roeck-us.net>
Cc:     linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-watchdog@vger.kernel.org
Date:   Sun, 01 Jan 2023 00:09:31 +0100
In-Reply-To: <5e4255782fbb43d1b4b5cd03bd12d7a184497134.1672498920.git.christophe.jaillet@wanadoo.fr>
References: <5e4255782fbb43d1b4b5cd03bd12d7a184497134.1672498920.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.2 (3.46.2-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

Hi Christophe,

On Sat, 2022-12-31 at 16:02 +0100, Christophe JAILLET wrote:
> The devm_clk_get_enabled() helper:
> =C2=A0=C2=A0 - calls devm_clk_get()
> =C2=A0=C2=A0 - calls clk_prepare_enable() and registers what is needed in=
 order to
> =C2=A0=C2=A0=C2=A0=C2=A0 call clk_disable_unprepare() when needed, as a m=
anaged resource.
>=20
> This simplifies the code and avoids the need of a dedicated function used
> with devm_add_action_or_reset().
>=20
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> =C2=A0drivers/watchdog/realtek_otto_wdt.c | 17 ++---------------
> =C2=A01 file changed, 2 insertions(+), 15 deletions(-)

Good to see more concise code here. Thanks!

FWIW

Acked-by: Sander Vanheule <sander@svanheule.net>

Best,
Sander