Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <249b621a-a527-6ee9-7802-acb34e91e433@intel.com>
Date:   Sun, 1 Jan 2023 09:27:24 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.1
Subject: Re: [Intel-wired-lan] [PATCH] igc: Mask replay rollover/timeout
 errors in I225_LMVP
To:     Rajat Khandelwal <rajat.khandelwal@linux.intel.com>,
        <jesse.brandeburg@intel.com>, <anthony.l.nguyen@intel.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, "Ruinskiy, Dima" <dima.ruinskiy@intel.com>,
        "Lifshits, Vitaly" <vitaly.lifshits@intel.com>,
        "Avivi, Amir" <amir.avivi@intel.com>
CC:     <netdev@vger.kernel.org>, <intel-wired-lan@lists.osuosl.org>,
        <linux-kernel@vger.kernel.org>, <rajat.khandelwal@intel.com>,
        "Neftin, Sasha" <sasha.neftin@intel.com>
References: <20221229122640.239859-1-rajat.khandelwal@linux.intel.com>
Content-Language: en-US
From:   "Neftin, Sasha" <sasha.neftin@intel.com>
In-Reply-To: <20221229122640.239859-1-rajat.khandelwal@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVN4OExJQXRRY001MkQzOU94UmlUWVNFb1FyRVNlckN0VEY2UE5YSFJQdmtM?=
 =?utf-8?B?TnlsRzl4MzJnS2ovdE85Sis0RzZMVGNiOGhhZVBRaUFqdGtXNUMzVmVLZllI?=
 =?utf-8?B?ZTZuTjZpaHo4NU1mRGNRNVpqTTY4K05vUnJ1SWhTME1BbUFjc3BIQ1d6NXZL?=
 =?utf-8?B?b3VvVFFscmU2L0MzRlk3ZFQrMFFGNTlrM3RPaFdyMHBTZ0VkL29vZUwxS1Fl?=
 =?utf-8?B?cG1Zem1ydkdPRUg3SE9yOWJJSGU1Y3plMWNDK2VpVmd3K0tvdm9ONWxrU3d2?=
 =?utf-8?B?UE5XUkF4QzhZTjNUbm5ROTcxNExobTN6UWEyWmZHMFBBWG5EYno5eGpvaHZL?=
 =?utf-8?B?di9WU2l2d01nZExKUDZBakE4cEpWaldoMDBRN0RncVQzb3dDTG9HL214QnZZ?=
 =?utf-8?B?SUlUYzFneHNlc3Q2SUk0UG83OGs2c0FOak1scmw4ZjZIMXNTQXMvUHVwMU93?=
 =?utf-8?B?NUxwOWJxK1VzSXRKVC9kNjAxeCsvUnQvcVhQN05oaU5kaFU5T1VVM1gza1I1?=
 =?utf-8?B?T01jOGExVkdXdFdKS3ZtUFBoZ2UyNHpSOGFjQWhDSk5uOUlncmJYeWJHVkh4?=
 =?utf-8?B?WUdHNFlHdDJ5UVdmKzlaWU4zS3J1UEZzV1RZUnFGUDFUOU9mbE9KNXpIbENk?=
 =?utf-8?B?Tk1ZbHE0anFpZjQ4cEdwWE1UYUZYTittYldENmpjcURDNk53dzYrNlgvZWJ0?=
 =?utf-8?B?WldIUjBiWW5mZVlKUmQ5aUxoMEFCTXVRTThxU0dudld5U2MwNWg4WUszUVp2?=
 =?utf-8?B?enZNR202V0dDZXp6T0Vzb3BwV1poMlpsSncvdDZLNEQxRWpWYTRRa0Y5dWdw?=
 =?utf-8?B?TTd5NSs0UWNmNUgwdWdHU3dYd0xkTktYd1BlNm51SUd0OGFUMytzcHZVZ3Mx?=
 =?utf-8?B?TDBzNnhJVHFFWWtSUVl1cFc5RGVvck5sZDhlWnJjc1NYMDZZY0x2RG51bVNI?=
 =?utf-8?B?aVlOMyticG5KckwxZGU4NnVEblp1MEwwbUhuRzgrN0NQZEk2emQxKzNYUk16?=
 =?utf-8?B?S2pFWjZyVThTUGQxWTYzb0JKd2Y2MTRCblhlUjlnT0VZUXZzN0F1N0ZKRHIv?=
 =?utf-8?B?dkh2QVgwYzdZb0gwVnhrR20yaTBzdFZJSXlIODN1bE5YY2YzN0xCSTVJOUtn?=
 =?utf-8?B?cXNad29vUmVJZnJVam8ycWppaFNQVlAxenFGVVNVV0dvVGJMek9teXlBSC9s?=
 =?utf-8?B?Sk5WM0huZ0FTaXVBMTBIbFJXLzFKRnJHdDgyRHd6cTNZa3l1N3dTWWxVbGpy?=
 =?utf-8?B?eXJiNTBlNnkzOTRYR1RoTWs4czUrK0N5N0R3eFBJMTkvUE5PblY1a2dzQlZz?=
 =?utf-8?B?amFsYWl6SDRoOHQ3bVowaWlXRDJLQXZzZ2QxcUcwSk5qcHpwL20xbW9mUzhJ?=
 =?utf-8?B?KzNvNzdkU1RjcnozbDYvQVBxUUtDTDNwbVdJK3hJcG10dWE2YVJMaEhGZEVr?=
 =?utf-8?B?MW52N1FHOFlpNUtNUXVjYUNvazAwWXlmSU5mQU5hb0N3Z2ZsNFpidzFvWFA0?=
 =?utf-8?B?bEZXYzlqOXpaU2RoVFlQdEhIc3BRd1dvTS94NnNFWUQ5R2tSSVJjRjZZYU5l?=
 =?utf-8?B?MG1TUVZoSzk0SlZWVURkcDJzNWs5dkhhbmxUc2c2UVN4KzRZU3UweTFkL292?=
 =?utf-8?B?KzFXbVZweENaVm16ZmprSDdvVnQrbWpyMXIvWG5YZWk3TFVtZnJxS1VKZjVE?=
 =?utf-8?B?QzA4SVhMNU1ZSDJhTnZ6VjlYRnJiMXZKeTBraWE2dDZuRDVsMWFLV0QvanFy?=
 =?utf-8?B?bGY2R3JhbTFhSUxOamltV2oxNXRnT3FjRTZCSG9yUytpb0pObEhXbThOSjla?=
 =?utf-8?B?SmlqR3o4S2QrdTgvMUd5YVpHcE9odlZlYm56dkVYT1l6MHFyTTBLWVFZbHJ0?=
 =?utf-8?B?c2RrU0NNVENiOGtaVjBSMUh2RUE5VjJyWU54VVNXMzJlclBSM1pkZlF2YklJ?=
 =?utf-8?B?QWZzZ0FjSStsbWZsMjNQN0dTWFNvamZJekc0NjI1UWFCUmVuTDhuM0lqdGMx?=
 =?utf-8?B?bGx5Zk5UcTUvSjZtdDVuTWR3TjFDSHc1ZitKeW8yVUtiTUtuQWtsdkdoTStp?=
 =?utf-8?B?K3kvNGRuVk5WWk5pZ0VMOHF3ZzNoNTl6d3kzVVh4SFFxdVpVc0FYM3liMWIr?=
 =?utf-8?Q?cRckTyn4e3s1G+pNeHTzcMG0J?=
X-MS-Exchange-CrossTenant-Network-Message-Id: adf8c267-f9b7-4b5c-51e0-08daebc9a6b1
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB6738.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jan 2023 07:27:34.6594
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f85JSHVho1LJYov7l8+dYsMQQzaSZuGmh+Fzp7MPqdDPgYBnMzw7hpfAieYBLFp+z2v5AMWcWFFes/KU9htCYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6850
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/29/2022 14:26, Rajat Khandelwal wrote:
> The CPU logs get flooded with replay rollover/timeout AER errors in
> the system with i225_lmvp connected, usually inside thunderbolt devices.
> 
> One of the prominent TBT4 docks we use is HP G4 Hook2, which incorporates
> an Intel Foxville chipset, which uses the igc driver.
> On connecting ethernet, CPU logs get inundated with these errors. The point
> is we shouldn't be spamming the logs with such correctible errors as it
> confuses other kernel developers less familiar with PCI errors, support
> staff, and users who happen to look at the logs.
> 
> Signed-off-by: Rajat Khandelwal <rajat.khandelwal@linux.intel.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_main.c | 28 +++++++++++++++++++++--
>   1 file changed, 26 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
> index ebff0e04045d..a3a6e8086c8d 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -6201,6 +6201,26 @@ u32 igc_rd32(struct igc_hw *hw, u32 reg)
>   	return value;
>   }
>   
> +#ifdef CONFIG_PCIEAER
> +static void igc_mask_aer_replay_correctible(struct igc_adapter *adapter)
> +{
> +	struct pci_dev *pdev = adapter->pdev;
> +	u32 aer_pos, corr_mask;
> +
> +	if (pdev->device != IGC_DEV_ID_I225_LMVP)
> +		return;
> +
> +	aer_pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_ERR);
> +	if (!aer_pos)
> +		return;
> +
> +	pci_read_config_dword(pdev, aer_pos + PCI_ERR_COR_MASK, &corr_mask);
> +
> +	corr_mask |= PCI_ERR_COR_REP_ROLL | PCI_ERR_COR_REP_TIMER;
> +	pci_write_config_dword(pdev, aer_pos + PCI_ERR_COR_MASK, corr_mask);
> +}
> +#endif
> +
Hello Rajat,
May we use the privilege flag approach, give user control: and mask some 
advanced errors?
Although...  Why did it happen? Didn't you prefer not to investigate it 
or else mask it? (I have concerns about the PCIe link over the 
thunderbolt tunnel)
>   /**
>    * igc_probe - Device Initialization Routine
>    * @pdev: PCI device information struct
> @@ -6236,8 +6256,6 @@ static int igc_probe(struct pci_dev *pdev,
>   	if (err)
>   		goto err_pci_reg;
>   
> -	pci_enable_pcie_error_reporting(pdev);
> -
>   	err = pci_enable_ptm(pdev, NULL);
>   	if (err < 0)
>   		dev_info(&pdev->dev, "PCIe PTM not supported by PCIe bus/controller\n");
> @@ -6272,6 +6290,12 @@ static int igc_probe(struct pci_dev *pdev,
>   	if (!adapter->io_addr)
>   		goto err_ioremap;
>   
> +#ifdef CONFIG_PCIEAER
> +	igc_mask_aer_replay_correctible(adapter);
> +#endif
> +
> +	pci_enable_pcie_error_reporting(pdev);
> +
>   	/* hw->hw_addr can be zeroed, so use adapter->io_addr for unmap */
>   	hw->hw_addr = adapter->io_addr;
>