Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 1 Jan 2023 09:51:24 +0200
From:   Mike Rapoport <rppt@kernel.org>
To:     Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
Cc:     jan.kiszka@siemens.com, kbingham@kernel.org,
        akpm@linux-foundation.org, gregkh@linuxfoundation.org,
        mingo@redhat.com, x86@kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, vbabka@suse.cz
Subject: Re: [PATCH] scripts/gdb: add mm introspection utils
Message-ID: <Y7E7fEBm6p0Q2djI@kernel.org>
References: <20221230163512.23736-1-dmitrii.bundin.a@gmail.com>
 <Y69E0diWostgY2pj@kernel.org>
 <CANXV_XzMVGHy5SP-2=QyO6YvpZAzLU4ZwFL3b8KOucr9rwkzhg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANXV_XzMVGHy5SP-2=QyO6YvpZAzLU4ZwFL3b8KOucr9rwkzhg@mail.gmail.com>
Precedence: bulk

On Sat, Dec 31, 2022 at 08:14:30PM +0300, Dmitrii Bundin wrote:
> On Fri, Dec 30, 2022 at 11:07 PM Mike Rapoport <rppt@kernel.org> wrote:
> >
> > The commit message does not mention it's x86-specific.
> > Not sure how gdb scripts handle per-arch functionality, but at the very
> > least this should be stated in the commit message.
> >
> Thanks for pointing this out. Will fix it. I put the command's code
> under the if utils.is_target_arch("x86") ... else
> gdb.GdbError("Virtual address translation is not supported for this
> arch") as it's done in other scripts and have plans to implement the
> same functionality for ARM in the foreseeable future.
> 
> > Any particular reason to make it ALL CAPS?
> Actually, no. Do you propose to reformat the output with a lower case?

I like lower case more :)

I'd also put the bit number first and would align the columns, e.g
something like:

    bit  0: entry present		: true
    bit  1: read/write access allowed	: true
    bit  2: user access allowed		: true
    bit  3: page level write through	: false
    bit  4: page level cache disabled	: false
    bit  5: entry has been accessed	: true
    bit  7: page size			: false
    bit 11: restart to ordinary		: false
    bit 63: execute disable		: true

-- 
Sincerely yours,
Mike.