Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a4216a94-72b3-4711-bc90-ad564a57b310@molgen.mpg.de>
Date:   Sun, 1 Jan 2023 11:34:21 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [Intel-wired-lan] [PATCH] igc: Mask replay rollover/timeout
 errors in I225_LMVP
Content-Language: en-US
To:     Leon Romanovsky <leon@kernel.org>,
        Rajat Khandelwal <rajat.khandelwal@linux.intel.com>
Cc:     intel-wired-lan@lists.osuosl.org, rajat.khandelwal@intel.com,
        jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org,
        edumazet@google.com, anthony.l.nguyen@intel.com,
        netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com,
        davem@davemloft.net, Bjorn Helgaas <bhelgaas@google.com>,
        linux-pci@vger.kernel.org
References: <20221229122640.239859-1-rajat.khandelwal@linux.intel.com>
 <Y7FFESJONJqGJUkb@unreal>
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <Y7FFESJONJqGJUkb@unreal>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

[Cc: +Bjorn, +linux-pci]

Dear Leon, dear Rajat,


Am 01.01.23 um 09:32 schrieb Leon Romanovsky:
> On Thu, Dec 29, 2022 at 05:56:40PM +0530, Rajat Khandelwal wrote:
>> The CPU logs get flooded with replay rollover/timeout AER errors in
>> the system with i225_lmvp connected, usually inside thunderbolt devices.
>>
>> One of the prominent TBT4 docks we use is HP G4 Hook2, which incorporates
>> an Intel Foxville chipset, which uses the igc driver.
>> On connecting ethernet, CPU logs get inundated with these errors. The point
>> is we shouldn't be spamming the logs with such correctible errors as it
>> confuses other kernel developers less familiar with PCI errors, support
>> staff, and users who happen to look at the logs.
>>
>> Signed-off-by: Rajat Khandelwal <rajat.khandelwal@linux.intel.com>
>> ---
>>   drivers/net/ethernet/intel/igc/igc_main.c | 28 +++++++++++++++++++++--
>>   1 file changed, 26 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
>> index ebff0e04045d..a3a6e8086c8d 100644
>> --- a/drivers/net/ethernet/intel/igc/igc_main.c
>> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
>> @@ -6201,6 +6201,26 @@ u32 igc_rd32(struct igc_hw *hw, u32 reg)
>>   	return value;
>>   }
>>   
>> +#ifdef CONFIG_PCIEAER
>> +static void igc_mask_aer_replay_correctible(struct igc_adapter *adapter)
>> +{
>> +	struct pci_dev *pdev = adapter->pdev;
>> +	u32 aer_pos, corr_mask;
>> +
>> +	if (pdev->device != IGC_DEV_ID_I225_LMVP)
>> +		return;
>> +
>> +	aer_pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_ERR);
>> +	if (!aer_pos)
>> +		return;
>> +
>> +	pci_read_config_dword(pdev, aer_pos + PCI_ERR_COR_MASK, &corr_mask);
>> +
>> +	corr_mask |= PCI_ERR_COR_REP_ROLL | PCI_ERR_COR_REP_TIMER;
>> +	pci_write_config_dword(pdev, aer_pos + PCI_ERR_COR_MASK, corr_mask);
> 
> Shouldn't this igc_mask_aer_replay_correctible function be implemented
> in drivers/pci/quirks.c and not in igc_probe()?

Probably. Though I think, the PCI quirk file, is getting too big.


Kind regards,

Paul