Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Winkler, Tomas" <tomas.winkler@intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Lubart, Vitaly" <vitaly.lubart@intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Subject: RE: [PATCH v1 1/1] mei: pxp: Use correct macros to initialize uuid_le
Thread-Topic: [PATCH v1 1/1] mei: pxp: Use correct macros to initialize
 uuid_le
Thread-Index: AQHZGtY8SdpSr4iFY06/Sk1hol6Ajq6Jgtfw
Date:   Sun, 1 Jan 2023 12:27:37 +0000
Message-ID: <MN2PR11MB40935FAB63820A3B25E3A37DE5F69@MN2PR11MB4093.namprd11.prod.outlook.com>
References: <20221228160558.21311-1-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20221228160558.21311-1-andriy.shevchenko@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KqTvebjiQvnzKV3wU36I9Msi8yB74PWEF8nYDey5qDQUvX5lVi9VidQArhmB?=
 =?us-ascii?Q?PL0EXbGG36JKJMIaSLmM4aZOVqiyfAtbCyyWrggM4QEsk/ltio3EOLXyk1aq?=
 =?us-ascii?Q?rE9/K/tGQtNj9jRd6inOc4IFn2h+lO99Wfo2+cjjAsf0lIe/pbmQxTkhzIPB?=
 =?us-ascii?Q?JvbjWRYmKF5YFjdjBjFZ8OruxdOOY8/Bi6qGsjocXp0hu291ohT528iZsVUj?=
 =?us-ascii?Q?lAT8/nv1sEprmxQGQh2Zx40gKAdR+Fc4yS8798lsAGieOb5l3ArXO+zzcre7?=
 =?us-ascii?Q?bx/NdhRVFNIoa+9ziejjxPnRgPxcPhIob/29mC/a9xPDKW4nAhaH4EYW3hH8?=
 =?us-ascii?Q?M5u7AKlTbt50g0zi3gZoGOusMWoVzJqhq1WqmXXVqAoesC/c7LYw9m/FVcih?=
 =?us-ascii?Q?3yIFi/1Xs4gXrTk5lYd79J4Sr8gIj6pjfu4TUuX9laVsdjLwCpKb2hyGJnIc?=
 =?us-ascii?Q?KJ5I7YGzMuhUD4ovKtRieaWvX5bC+vIuo+7q49Hc3cOstEsjWtsu3mShMnqn?=
 =?us-ascii?Q?igPXBYmzLNvutA/zkMAX7HHRGBy/rLhDG7FpO04DoIbk3gAZoaREEnesNizA?=
 =?us-ascii?Q?FPokbqxLX1Y9U8ohGKPPrvBPmh8UoU6qVUs2p5TA+zvHvY6LwPXX1purQ5qm?=
 =?us-ascii?Q?Y1KsjHVZvxm0Gn6wwkWwRqPEX2mv5Gbmltxmf2wl/pcdgdGb9h/6xqHmbfyF?=
 =?us-ascii?Q?6uuVcD+hfzQlmYBfsWAnbR8OTlX8iWflFKAxPrJrrzZxdE+hFpBqluxkZnj5?=
 =?us-ascii?Q?5Tm1vcckgMO93Jk6wbzME8+yrIvSQh83opI6mwAh1gJ0cJLqO01y5IkoZdoo?=
 =?us-ascii?Q?a47L15NVjQMTzkQBzsrqaMdm63mT6KO7OR/8OW4hPk22Gz+aQtU8Dz/gMYui?=
 =?us-ascii?Q?/Z9HUguiOTutPB+AsRQHBmdxVNrGofcF7x2S/7SpH9aqN8Z4TKSAROm6KWhf?=
 =?us-ascii?Q?nKuCJt5zvmSLSTCdYaxTfmSGtlq1KeAFVCODpqKDuba2xN5388pnU44z2edH?=
 =?us-ascii?Q?y4olGrlZRCZA4XJ8nadYsLAhkPYKhU2FKNmENJabewsYhEhdUSfvMd/J+Rto?=
 =?us-ascii?Q?Ge7QRQBJXHN9Mt7p74cieSr4r0HBNUltXjyIi89vV5M4TO7V3uVi3ABMyqMm?=
 =?us-ascii?Q?+rTogLEG4kbdTEWpYRcfOksQ8ofh5s0SFywmka3UyBzJnKHgE7Mg97E28jTj?=
 =?us-ascii?Q?F/m8jJKIOa2mPmBYNRQnTKPKuCrTYl681f4OJOpFYk1LRzdXKTY1bNri8JSj?=
 =?us-ascii?Q?xecW0TcinJiWJcDytwqghagfQ9cZJLNyyS2u1GmSk9+uwNx/pyrgIL1uE3Ir?=
 =?us-ascii?Q?hzfalUp/JKFo4iUIpX+FeA3YULqalHtrXdLsbn5zo6XoiTKHXuHQsim5GKv+?=
 =?us-ascii?Q?50nrcfmNYcx0Op32AVCake9QkmlrVU7b5CtyspDtBmzSiYxnHYbTffVME2Qm?=
 =?us-ascii?Q?Q1M3xiwUEtzWFQ7IwS0agzoIzDKV9SNUP8s+AQHHRnhBzgxRf7Sa9GM31J0v?=
 =?us-ascii?Q?4U4VCLTCZhZpOILHnO0InrAKxwDpoH0SrgU3oS9KWq0L7sradHLUm/rwuTTp?=
 =?us-ascii?Q?/IyboeMq+tqvGsYCpTFVvEfodUJgcP+I8fQ6J9Fc?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB4093.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 06dc0889-fe73-4dcc-eac3-08daebf39147
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jan 2023 12:27:37.2711
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xpeamAl4uo+ofSiVdmQ5LHxv1aFqy1SzeUj7mjh7ITxGCsEY0/4CPa+61MusCrWzJDP309rwzvNxfL/ROWv7wQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8062
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>=20
> GUID_INIT() is for internal guid_t type and shouldn't be used for the uui=
d_le.
> I.o.w. relying on the implementation details is layering violation. Use c=
orrect
> macros to initialize uuid_le.
>=20
> Fixes: c2004ce99ed7 ("mei: pxp: export pavp client to me client bus")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Tomas Winkler <tomas.winkler@intel.com>=20

> ---
>  drivers/misc/mei/pxp/mei_pxp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/misc/mei/pxp/mei_pxp.c
> b/drivers/misc/mei/pxp/mei_pxp.c index 8dd09b1722eb..7ee1fa7b1cb3
> 100644
> --- a/drivers/misc/mei/pxp/mei_pxp.c
> +++ b/drivers/misc/mei/pxp/mei_pxp.c
> @@ -238,8 +238,8 @@ static void mei_pxp_remove(struct mei_cl_device
> *cldev)  }
>=20
>  /* fbf6fcf1-96cf-4e2e-a6a6-1bab8cbe36b1 : PAVP GUID*/ -#define
> MEI_GUID_PXP GUID_INIT(0xfbf6fcf1, 0x96cf, 0x4e2e, 0xA6, \
> -			       0xa6, 0x1b, 0xab, 0x8c, 0xbe, 0x36, 0xb1)
> +#define MEI_GUID_PXP UUID_LE(0xfbf6fcf1, 0x96cf, 0x4e2e, 0xA6, \
> +			     0xa6, 0x1b, 0xab, 0x8c, 0xbe, 0x36, 0xb1)
>=20
>  static struct mei_cl_device_id mei_pxp_tbl[] =3D {
>  	{ .uuid =3D MEI_GUID_PXP, .version =3D MEI_CL_VERSION_ANY },
> --
> 2.35.1