Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Winkler, Tomas" <tomas.winkler@intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ramalingam C <ramalingam.c@intel.com>,
        "Daniel Vetter" <daniel.vetter@ffwll.ch>
Subject: RE: [PATCH v1 1/1] misc/mei/hdcp: Use correct macros to initialize
 uuid_le
Thread-Topic: [PATCH v1 1/1] misc/mei/hdcp: Use correct macros to initialize
 uuid_le
Thread-Index: AQHZGtYXcHWV36/kLkObNr2HC3mdLq6JgzKg
Date:   Sun, 1 Jan 2023 12:27:51 +0000
Message-ID: <MN2PR11MB4093FCF4AD5486647237BAA2E5F69@MN2PR11MB4093.namprd11.prod.outlook.com>
References: <20221228160500.21220-1-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20221228160500.21220-1-andriy.shevchenko@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?32PL+tBZoui7BP3YMyAugxs6N7FoRIdsxFys7bUSblbYBAriDtziy7783dDk?=
 =?us-ascii?Q?aQOem50HxM5/S01rs7jd+PMch3htpG3MVieJ/HhhIA3BJsoBgr8Fy6k5lUZT?=
 =?us-ascii?Q?v1WepdEP49ra9WmpIN8RfAuZjfdsZW/SgQYZhHIS01cpeUBdC/WCVeaTts4q?=
 =?us-ascii?Q?pSC3dccaDQSZgbeX7VPWiRFSyWlF5ZCc4SOso+0r/wQccbYUefxRpWyeFPgg?=
 =?us-ascii?Q?GB+bwqlAL9ZOvMjfMVDMxqa4EelQWvlMeQ/KC7mwj9Jykkuce+XMSzXeXtj6?=
 =?us-ascii?Q?+IyeBOA3bwskAeaAXCUqNWub2XItLXTLNEwkf3B5m3YBpp94vXWze/lgmbZC?=
 =?us-ascii?Q?gvOGKvOcbwCP5k29gF8JlFAUF9sZVU5lck1uZ3ZEl97RN+Vwwo/Z0ipgX0a/?=
 =?us-ascii?Q?lKM77mk8WBnZxF02NDWEwcyOln1ERjHqHgC2+nu62hbrFmcxx3z89AINUZE4?=
 =?us-ascii?Q?MCUpKDtZDZhDLHdhNgfpwzx3Z83cJYeEd25kERQQeEEBtkobwJ2ZibAUqdLu?=
 =?us-ascii?Q?zQbPsPyrhcrK2qZG/HUm7PrWUpl+GU95kkPBmOIj+6pVe7jPrWJoNf37OD19?=
 =?us-ascii?Q?8i8AOSc2r5P0tDw5gkYeMEo0qy7QHs7OU9FQP9GqXVPvObm9jtds8ZggDzwt?=
 =?us-ascii?Q?/4lqgNR8XKDWBj9PaNKkhFGusLK/LPVXrJk70vRKNCeXV01y1bPS2DGir0ZY?=
 =?us-ascii?Q?IY1GDvLqnf9jM9p75aFP7mXzcHexH0tUQLiT5ID4SAWoL/wbfW6H4WqnTwPD?=
 =?us-ascii?Q?7jUA0Q4WEqGy5ZuaofCspl9P4jME3pO4LW7Mh7wgvO5MO2tvjIP7BuVQGx2i?=
 =?us-ascii?Q?oNlloECKPjT5WIfUEIc5Rr2F+7YYS73zmJ7tQOy8aqqsEKa4C+oSR9/zi2cD?=
 =?us-ascii?Q?y6OKdjUACksNjAt371LdNKIin3JDEEk7qOjuHbXa3ATeoW/g3/m7YKCyvVtt?=
 =?us-ascii?Q?oU2pDcLDxL3nC0cQeswrLkRiGuf7xotgVtoVGMWMl/bYV9GtHzt2BUsw6BaI?=
 =?us-ascii?Q?vJt7bHumI3RFYOGZyq4HjlumDh7ugmPDsEobXIKZNO/VrwO8RsHkXpUEdclg?=
 =?us-ascii?Q?PJzk2Y90N6Xj8Mj4ZYu6uVtpLUZJSQok0DASJSbqEl3LhrrOds2vzHns/Ntt?=
 =?us-ascii?Q?T5QdkBIDYzsTRGSxYKRg/Oz1psdzMo7rJEqkVgUjsTdVmteYjknpPeR6Qk4f?=
 =?us-ascii?Q?mh0KArOs1ck9rSGMsJ5ydEHIpkbJjo3UPlNYox4korGLwzGE7XR1oC7FYZgL?=
 =?us-ascii?Q?NkdYh1okPIQGWqo0ZF22SJBfufqiczus19mAKvhjvI7dX+w3V8Y4zHYwSMN2?=
 =?us-ascii?Q?hOO9gSJ6AncvIk4zRM/+itPw1hYuA0A2RNtcY3VaWP3TvrIhuChTTVzrfV+w?=
 =?us-ascii?Q?+S5pC8hQeUZ5yLSp6rxuajxnbzzvkTWIAIwxUkpIgwjXnIzmiU/51CZ7vI/z?=
 =?us-ascii?Q?4WDI+MtnW0ei9KdWBQbARk+rpRjyqpNY7WjZpKQJdckBzcdVxOsJV+55WDls?=
 =?us-ascii?Q?D7bQZnTLFHvjzm3SD6s0M/9CGJLeKRl7Sfj675BGMOjHFtYLvNmTFZRahM4y?=
 =?us-ascii?Q?CDkGN3ornl4gpjOgvyuz+XiFD5PcYOOkwSm7LfA6?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB4093.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f424851-5ca4-450c-1264-08daebf399d2
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jan 2023 12:27:51.5983
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: E3J9YWUbsj1Ab2PBN8m4PTNr3G6NK7KXH8Z2XrQzp1fcDzhiTJYxcPsZ9K9v1yaGv/k7C57W7Eg1g9H+aMfgMw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8062
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> GUID_INIT() is for internal guid_t type and shouldn't be used for the uui=
d_le.
> I.o.w. relying on the implementation details is layering violation. Use c=
orrect
> macros to initialize uuid_le.
>=20
> Fixes: 64e9bbdd9588 ("misc/mei/hdcp: Client driver for HDCP application")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
>  drivers/misc/mei/hdcp/mei_hdcp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c
> b/drivers/misc/mei/hdcp/mei_hdcp.c
> index 5a1c93a2d2f1..cc7f1169206c 100644
> --- a/drivers/misc/mei/hdcp/mei_hdcp.c
> +++ b/drivers/misc/mei/hdcp/mei_hdcp.c
> @@ -858,8 +858,8 @@ static void mei_hdcp_remove(struct mei_cl_device
> *cldev)
>  		dev_warn(&cldev->dev, "mei_cldev_disable() failed\n");  }
>=20
> -#define MEI_UUID_HDCP GUID_INIT(0xB638AB7E, 0x94E2, 0x4EA2, 0xA5, \
> -				0x52, 0xD1, 0xC5, 0x4B, 0x62, 0x7F, 0x04)
> +#define MEI_UUID_HDCP UUID_LE(0xB638AB7E, 0x94E2, 0x4EA2, 0xA5, \
> +			      0x52, 0xD1, 0xC5, 0x4B, 0x62, 0x7F, 0x04)
>=20
>  static const struct mei_cl_device_id mei_hdcp_tbl[] =3D {
>  	{ .uuid =3D MEI_UUID_HDCP, .version =3D MEI_CL_VERSION_ANY },
> --
> 2.35.1