Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221226142150.13324-1-pali@kernel.org> <20221226142150.13324-4-pali@kernel.org>
In-Reply-To: <20221226142150.13324-4-pali@kernel.org>
From:   Kari Argillander <kari.argillander@gmail.com>
Date:   Sun, 1 Jan 2023 21:02:46 +0200
Message-ID: <CAC=eVgS7weRq7S16MpTyx9eZm=2s+OZhm6Ko75Z6bmjsHH-7Yw@mail.gmail.com>
Subject: Re: [RFC PATCH v2 03/18] ntfs: Undeprecate iocharset= mount option
To:     =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali@kernel.org>
Cc:     linux-fsdevel@vger.kernel.org,
        linux-ntfs-dev@lists.sourceforge.net, linux-cifs@vger.kernel.org,
        jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Jan Kara <jack@suse.cz>, "Theodore Y . Ts'o" <tytso@mit.edu>,
        Anton Altaparmakov <anton@tuxera.com>,
        OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
        Luis de Bethencourt <luisbg@kernel.org>,
        Salah Triki <salah.triki@gmail.com>,
        Steve French <sfrench@samba.org>, Paulo Alcantara <pc@cjr.nz>,
        Ronnie Sahlberg <lsahlber@redhat.com>,
        Shyam Prasad N <sprasad@microsoft.com>,
        Tom Talpey <tom@talpey.com>, Dave Kleikamp <shaggy@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Pavel Machek <pavel@ucw.cz>,
        Christoph Hellwig <hch@infradead.org>,
        Viacheslav Dubeyko <slava@dubeyko.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

26.12.2022 klo 16.22 Pali Roh=C3=A1r (pali@kernel.org) wrote:
>
> Other fs drivers are using iocharset=3D mount option for specifying chars=
et.
> So mark iocharset=3D mount option as preferred and deprecate nls=3D mount
> option.

snip.

> diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c

snip.

> @@ -218,10 +213,10 @@ static bool parse_options(ntfs_volume *vol, char *o=
pt)
>                 } else if (!strcmp(p, "utf8")) {
>                         bool val =3D false;
>                         ntfs_warning(vol->sb, "Option utf8 is no longer "
> -                                  "supported, using option nls=3Dutf8. P=
lease "
> -                                  "use option nls=3Dutf8 in the future a=
nd "
> -                                  "make sure utf8 is compiled either as =
a "
> -                                  "module or into the kernel.");
> +                                  "supported, using option iocharset=3Du=
tf8. "
> +                                  "Please use option iocharset=3Dutf8 in=
 the "
> +                                  "future and make sure utf8 is compiled=
 "
> +                                  "either as a module or into the kernel=
.");

We do not have to make sure utf8 is compiled anymore as it "always is" righ=
t?

>                         if (!v || !*v)
>                                 val =3D true;
>                         else if (!simple_getbool(v, &val))