Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221220090248.1134214-1-haibo.chen@nxp.com>
In-Reply-To: <20221220090248.1134214-1-haibo.chen@nxp.com>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Mon, 2 Jan 2023 09:03:45 +0100
Message-ID: <CAMRc=MdW5OfHPy5hmJddV65C8-eqeQSt4dd_p=03jBNR65vrAg@mail.gmail.com>
Subject: Re: [PATCH 1/2] gpio: vf610: connect GPIO label to dev name
To:     haibo.chen@nxp.com
Cc:     linus.walleij@linaro.org, stefan@agner.ch,
        linux-gpio@vger.kernel.org, linux-imx@nxp.com,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Dec 20, 2022 at 10:02 AM <haibo.chen@nxp.com> wrote:
>
> From: Haibo Chen <haibo.chen@nxp.com>
>
> Current GPIO label is fixed, so can't distinguish different GPIO
> controllers through labels. Use dev name instead.
>
> Fixes: 7f2691a19627 ("gpio: vf610: add gpiolib/IRQ chip driver for Vybrid")
> Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
>  drivers/gpio/gpio-vf610.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
> index 9db42f6a2043..a429176673e7 100644
> --- a/drivers/gpio/gpio-vf610.c
> +++ b/drivers/gpio/gpio-vf610.c
> @@ -304,7 +304,7 @@ static int vf610_gpio_probe(struct platform_device *pdev)
>
>         gc = &port->gc;
>         gc->parent = dev;
> -       gc->label = "vf610-gpio";
> +       gc->label = dev_name(dev);
>         gc->ngpio = VF610_GPIO_PER_PORT;
>         gc->base = of_alias_get_id(np, "gpio") * VF610_GPIO_PER_PORT;
>
> --
> 2.34.1
>

I applied this one, please fix patch 2/2 and resend on its own.

Bartosz