Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp10363335rwl; Mon, 2 Jan 2023 00:55:40 -0800 (PST) X-Google-Smtp-Source: AMrXdXsT6ye8EvZvHcoGUtandBFMF97i3ZiSmqA/ZqhES6fMIF+JFM4tixiU/RvGZ9g2r24qFILK X-Received: by 2002:a17:902:cf02:b0:191:283d:5afb with SMTP id i2-20020a170902cf0200b00191283d5afbmr42666207plg.50.1672649739888; Mon, 02 Jan 2023 00:55:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672649739; cv=none; d=google.com; s=arc-20160816; b=xfBmt3hriWNhP7e+bpuV0Z6bbwlRYLPeIJ+MC+aIpB2AdUh/qLG8c/iEuf35P/e3aq 8Ino5DMwIItOCWnE8Lrmy9dKcLuF0g82t3CBOwPcpME4X6pXO1zzNCznLD+knSaerEym ZbbEX5WA5GZpAFSYgy771kUIkUrD3F0Zcz4jNLHwQgf7mZZUaERO35zs3Kkr7vbzueAo 3fM4O7aGnEPv1EqDryUvJ9oRlBaY3sdLr8zKG5BNDhI1TnZGmDRhjZQcM1UhOv1TauWy sg0BfpO0gQMzL3XQMDctTxIOjHUtn4kAcNnr/dkIpomMqC1DYujaLNivihhJ8WLLewGF AXKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=JV7mKkj4m/LbjdZ+E3y5ghBdnOoxXVhztXdDkfMjQ3Y=; b=usPxshLxUw+NH1xL7Nz022tR0BAvfSF89pbtwQ5QZUcwA+dtR+734qw+pyoEQA+xxU Uk9tcv3NohywVG++PJwcXSLb8XnLdGIVYJjA+i6HA6m/g2MPzH2NwsXBNpcbOXKzvPyx A1CulL7MKHXYLDPMad7bBUz5v0ojh5G9T1DFAGj+gY8IGsO6K8Ua82Y1a1KdQRQKoteu XUgvV94nQaWC093EEcUJW/HcGcmaHZzuljkdtNN10dfrvHVjvt1VbLAz4EIqSyQKx76i GKab1xC+PUUXqmzkw907Zmh3BAZVjfpgBKB3brfhgJSqDgKvhlXFLdxwFBms58wIHK1E jPQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="LnOdDY/x"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k3-20020a170902d58300b001927aa58c73si19674453plh.203.2023.01.02.00.55.31; Mon, 02 Jan 2023 00:55:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="LnOdDY/x"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231890AbjABIm3 (ORCPT + 58 others); Mon, 2 Jan 2023 03:42:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231993AbjABImS (ORCPT ); Mon, 2 Jan 2023 03:42:18 -0500 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDD0BDF4 for ; Mon, 2 Jan 2023 00:42:17 -0800 (PST) Received: by mail-pl1-x629.google.com with SMTP id g16so19317950plq.12 for ; Mon, 02 Jan 2023 00:42:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=JV7mKkj4m/LbjdZ+E3y5ghBdnOoxXVhztXdDkfMjQ3Y=; b=LnOdDY/x11L2fWrc3DS8NW4NDOu1PWG9qOJCbJslNnneoe+SOcgeHhjAk/sZvYewEo jMlNouPohv6UO21l880LPap2L+oZ4UTjFlXLLPfEknP3pweaRshCLU8u2VIW+OG0Z6BW e6dEk3rYJkyB/oqut1yL41ELcuIh8OWrwzbNvKOqasT6TQnL55IiccBWvX3Nx8C/mN6I lVGCytF/KmPtFje99ltjbeW7g1XsdO17dOaOAAbd3e2K0me7ZwkmNEWtzM/BmA9OSNlG WlF4eH3Zw3YzcqGLnBEKMRqklsDH+PGl6wUC18ao+0gZ6E5D4YMY3kHA91SvOotW5yLb qBtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JV7mKkj4m/LbjdZ+E3y5ghBdnOoxXVhztXdDkfMjQ3Y=; b=5Go3yCkNY4E10ApGFN2Fr6flFV6CXxYxSv4VmsDV8QkbZwXbIfdKiMm5GrkQwhoyLA HKMmyQrQclrkbZ/e+UAGyk4ssXrNhRTeh02FQ/FIyd/wdNwttjX4oCEH3tlj7nVHi0j7 djUiQxI+PxoxA/i5ffO4joh5MueV5V44sqAuahqMq4+ivwR9C27qFkrdXF60yyDmGTG9 kMY8fj7pRjwBDe4ikTQN7HHRfvb/yuH1ljnM0wGR2Y0QFPDEEzCNs6gAJYjKVgjgc38J rj9NVFukhRUd4bFOALL+em/2iOSNeGg6WUfVaZtbmFp7PvfY8ZXdNLMqAPZdhIc8qaQm Zv7g== X-Gm-Message-State: AFqh2kq91D3E4cQN6JvVIBCM8evjcroHYpafV1B48nGLDdQdYCW9jUzT dZV8LSiqONIj4JnP0RmTdqbdQR527CrlYr9+ X-Received: by 2002:a05:6a20:8f26:b0:ad:db18:6d0d with SMTP id b38-20020a056a208f2600b000addb186d0dmr62886922pzk.59.1672648937455; Mon, 02 Jan 2023 00:42:17 -0800 (PST) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id t29-20020a63535d000000b004767bc37e03sm16609386pgl.39.2023.01.02.00.42.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 00:42:16 -0800 (PST) From: Miaoqian Lin To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Gleixner , Marc Zyngier , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] irqchip/irq-mvebu-gicp: Fix refcount leak in mvebu_gicp_probe Date: Mon, 2 Jan 2023 12:42:08 +0400 Message-Id: <20230102084208.3951758-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_irq_find_parent() returns a node pointer with refcount incremented, We should use of_node_put() on it when not needed anymore. Add missing of_node_put() to avoid refcount leak. Fixes: a68a63cb4dfc ("irqchip/irq-mvebu-gicp: Add new driver for Marvell GICP") Signed-off-by: Miaoqian Lin --- drivers/irqchip/irq-mvebu-gicp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-mvebu-gicp.c b/drivers/irqchip/irq-mvebu-gicp.c index fe88a782173d..c43a345061d5 100644 --- a/drivers/irqchip/irq-mvebu-gicp.c +++ b/drivers/irqchip/irq-mvebu-gicp.c @@ -221,6 +221,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev) } parent_domain = irq_find_host(irq_parent_dn); + of_node_put(irq_parent_dn); if (!parent_domain) { dev_err(&pdev->dev, "failed to find parent IRQ domain\n"); return -ENODEV; -- 2.25.1