Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: iefc945ae:Fastmail
Message-ID: <aef7295e-264c-4812-06f5-b8f7a8339ed9@tom-fitzhenry.me.uk>
Date:   Mon, 2 Jan 2023 22:13:41 +1100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] mfd: rk808: re-add rk808-clkout to RK818
To:     neil.armstrong@linaro.org, Lee Jones <lee@kernel.org>
Cc:     Ondrej Jirman <megi@xff.cz>,
        Javier Martinez Canillas <javierm@redhat.com>,
        Martijn Braam <martijn@brixit.nl>,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20221228140708.26431-1-tom@tom-fitzhenry.me.uk>
 <3f40e58a-dcd2-7c9a-1a9d-cae36719352f@linaro.org>
Content-Language: en-US
From:   Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
In-Reply-To: <3f40e58a-dcd2-7c9a-1a9d-cae36719352f@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2/1/23 21:06, Neil Armstrong wrote:
> On 28/12/2022 15:07, Tom Fitzhenry wrote:
>> Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which
>> dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe.
>>
>> This line was removed in commit 3633daacea2e
>> ("mfd: rk808: Permit having multiple PMIC instances"), but only from 
>> RK818.
>>
>> Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
>> ---
>>   drivers/mfd/rk808.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
>> index f44fc3f080a8..0f22ef61e817 100644
>> --- a/drivers/mfd/rk808.c
>> +++ b/drivers/mfd/rk808.c
>> @@ -189,6 +189,7 @@ static const struct mfd_cell rk817s[] = {
>>   };
>>   static const struct mfd_cell rk818s[] = {
>> +    { .name = "rk808-clkout", .id = PLATFORM_DEVID_NONE, },
>>       { .name = "rk808-regulator", .id = PLATFORM_DEVID_NONE, },
>>       {
>>           .name = "rk808-rtc",
>>
>> base-commit: c76083fac3bae1a87ae3d005b5cb1cbc761e31d5
> 
> Sorry, my bad...

No worries!

> Acked-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks, I have added this to the v2 patch.