Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp10494753rwl; Mon, 2 Jan 2023 03:42:35 -0800 (PST) X-Google-Smtp-Source: AMrXdXudylor9rYH84Hjdoa0/qcgcjK8mvLwhulx1q5N1nKHNzqUk7ikmLP3+PPMeQWsraNu5ik1 X-Received: by 2002:a17:90a:fe10:b0:226:201a:fdb0 with SMTP id ck16-20020a17090afe1000b00226201afdb0mr17240040pjb.35.1672659754869; Mon, 02 Jan 2023 03:42:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672659754; cv=none; d=google.com; s=arc-20160816; b=zRhwodQfjAgjqUEsA0pbCZDNT44ieusZ1jlZ1+eFM0BVbjgZLSVxYaIgGV5v5qDNB5 oswwrdYOfKjOfNMNj0M6mtInNbWX7O85IfKoP/76zKlufjhX0GGku3/Im/548O27fi0P R4JPK/XgR7c+pHj1vaK/RVxuC10CauoBOtfvJCrTNM08bRv6H1SKoOTrTKhRazRSNeUB ipAtOjo+DXfROkqu2nRfCQ+6K5Q4bTqhEFtbTtgoBX/S6xwP+gBXNFsGJ1o/HEg2mxNJ JpYHAVeRvDkmAtGAVq0YV8kzKiMxlN672uO5psjlAK1bmXAuPGa8SKR9KDaqffVIzV8i Xfnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:feedback-id:dkim-signature :dkim-signature; bh=Q4jkeKlxInSpmYKiriM5hlWL/XAXcD0E9o2hKjrYh20=; b=HbtglVSyBJtCLCmn09gBWfYRmlarSY4SVJE1lx+C8q+znKJtOXHBHTlM+sJF9TA457 fyKDAk6ZGSBCzHLAFEJsIhWGcBk07onbHzDJbGJ8ghaZ9+O2V3nC0c6WY0n3ZsTIc0v5 KtiR6uSq2IV41I8l3oz4/lDlpAppJai0yVmB+iWdMUhx8ChyZ/ZXQt2t8oqKzT7K9vuD cwhJKGF3ZCiugkJr8AF0zqJgxOY2vFqLbNp38GFO16N43oCBjdodRs2ohn83jStq63oN Rtb4TMUplH/ZrNLu1Tv0T2emZ8ZGnSVLLwuAF5JlwwzXc3uD8F3y8cII8X1274WPHAwb D48Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tom-fitzhenry.me.uk header.s=fm2 header.b=J8PeGCvU; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=nvG1VVEm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=tom-fitzhenry.me.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mi18-20020a17090b4b5200b002266326b49dsi5235690pjb.158.2023.01.02.03.42.26; Mon, 02 Jan 2023 03:42:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@tom-fitzhenry.me.uk header.s=fm2 header.b=J8PeGCvU; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=nvG1VVEm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=tom-fitzhenry.me.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232050AbjABLMW (ORCPT + 60 others); Mon, 2 Jan 2023 06:12:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231949AbjABLMU (ORCPT ); Mon, 2 Jan 2023 06:12:20 -0500 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBCF4296 for ; Mon, 2 Jan 2023 03:12:18 -0800 (PST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 9643132008FA; Mon, 2 Jan 2023 06:12:14 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 02 Jan 2023 06:12:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= tom-fitzhenry.me.uk; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to; s=fm2; t=1672657934; x=1672744334; bh=Q4 jkeKlxInSpmYKiriM5hlWL/XAXcD0E9o2hKjrYh20=; b=J8PeGCvU8c4eObKh3+ bNGsv051SDJEla1S5Pj1pZS+4oiBeiPA/WUNzbh4KnaKQAKBpSP6wCeXH6/M8PNz PA2lN6MxKizG6PBWpVEGSVIs3hNUxJOLjyTMxXrrHlNMdUgclBz9Y61T2BvOv4/5 4J1e3EoF+aHlJelSnoZVeAZML/IUMLwkUp+il29KbwtNMa6vqXJluxOQmz/xJ94m 7gmworcqDkAGhIY+NoGUpQyHIvvD9J2FKoiblJgBXjLGXnVgM7FhFGwMyjWjS/9F dDeSytUO3uq2HAzQdJEJ4ST7gVCzOWM2sotAVKHL+ZrwrFJMPPBWUVdu9ZKpgH5n srhA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1672657934; x=1672744334; bh=Q4jkeKlxInSpmYKiriM5hlWL/XAXcD0E9o2 hKjrYh20=; b=nvG1VVEmsRKsRIRYJX0fXBI5yMqFNBWpzfDL6xA5dRSLI/h2AFX 1o5UgATbL8qK4jwbWgK/0W97QQ4k8S1KtSNhh3bDZZW8XXCwKNHmiTIPlVCutezl egc+hi6N7cD2PlUA6CP4n1mtlwCV6yce8Pkki8FXuHfftR1siP9wWrnEo0rVs52/ EhxBmpCaA9kKYVZoq+HxywwZaZ18z93ETAocp/fWfwsK+qWCoPyH/90ZC0ztRnRL VHP11QLjJvUyDeLWB3BsPa7E8oEE0Idrje55mXHG5kn51sQ12Mzholnj+iuiidY7 d9MolemNJG81h9qpT9DLCG1S7QMJVRGzIOA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrjedvgddvhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefvohhmucfhihht iihhvghnrhihuceothhomhesthhomhdqfhhithiihhgvnhhrhidrmhgvrdhukheqnecugg ftrfgrthhtvghrnhepfeeivdegffeftefhkeeugfdvudetfedtieejuddugfejueektddv vdefueetgeevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhomhesthhomhdqfhhithiihhgvnhhrhidrmhgvrdhukh X-ME-Proxy: Feedback-ID: iefc945ae:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 2 Jan 2023 06:12:10 -0500 (EST) From: Tom Fitzhenry To: Lee Jones , Neil Armstrong Cc: Ondrej Jirman , Javier Martinez Canillas , Martijn Braam , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Tom Fitzhenry Subject: [PATCH v2] mfd: rk808: re-add rk808-clkout to RK818 Date: Mon, 2 Jan 2023 22:11:47 +1100 Message-Id: <20230102111147.2580861-1-tom@tom-fitzhenry.me.uk> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe. This line was removed in commit 3633daacea2e ("mfd: rk808: Permit having multiple PMIC instances"), but only from RK818. Changes in v2: - Add a Fixes tag (Javier Martinez Canillas). - Add Javier Martinez Canillas's Reviewed-by tag. - Add Neil Armstrong's Acked-by tag. Fixes: 3633daacea2e ("mfd: rk808: Permit having multiple PMIC instances") Signed-off-by: Tom Fitzhenry Reviewed-by: Javier Martinez Canillas Acked-by: Neil Armstrong --- drivers/mfd/rk808.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c index f44fc3f080a8..0f22ef61e817 100644 --- a/drivers/mfd/rk808.c +++ b/drivers/mfd/rk808.c @@ -189,6 +189,7 @@ static const struct mfd_cell rk817s[] = { }; static const struct mfd_cell rk818s[] = { + { .name = "rk808-clkout", .id = PLATFORM_DEVID_NONE, }, { .name = "rk808-regulator", .id = PLATFORM_DEVID_NONE, }, { .name = "rk808-rtc", base-commit: c76083fac3bae1a87ae3d005b5cb1cbc761e31d5 -- 2.38.1