Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <69dd964c-c015-7ddf-4df4-4f2cb7b157c0@theobroma-systems.com>
Date:   Mon, 2 Jan 2023 12:48:07 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v2 2/2] usb: dwc2: prevent core PHY initialization on
 Rockchip
Content-Language: en-US
To:     Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
        Quentin Schulz <foss+kernel@0leil.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Bin Yang <yangbin@rock-chips.com>
References: <20221206-dwc2-gadget-dual-role-v2-0-0de821615dd3@theobroma-systems.com>
 <20221206-dwc2-gadget-dual-role-v2-2-0de821615dd3@theobroma-systems.com>
 <BYAPR12MB339982A244FBA1178423E529A7EA9@BYAPR12MB3399.namprd12.prod.outlook.com>
From:   Quentin Schulz <quentin.schulz@theobroma-systems.com>
In-Reply-To: <BYAPR12MB339982A244FBA1178423E529A7EA9@BYAPR12MB3399.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3Z6cFp5MUFucHJYVFZMYU9wQ3BrVnJUeXRBdkY3RkdiMWxLbHJkZk16YVhZ?=
 =?utf-8?B?dGhzL1dWbUxCSUJJSXhwVkZHb1FSZmNla1d2TW11Vjd0L2t2SGN3ZjFXQkhK?=
 =?utf-8?B?eUF6cHFqY1ZZR2JqSk0ramRpNVdoOVdpblhvdk9STEtSWTR3eXFzaGpwWVJS?=
 =?utf-8?B?U3NqdWtUODRUOFNpSTM1dTlUam95ejV2RnAybTVHNXVHWUtmaHdDVkNhQTh0?=
 =?utf-8?B?cnRPSmR1VzlKc3pPZE1oRkQvK2xacHhVUUhJNWQyOUJVYUM3czhRbTUvREhy?=
 =?utf-8?B?NGdWWlE2UGIySzlNcnFRUDJyeXNxVUdUeENCTFdoYUVLNUg5RStQbC9YN2VM?=
 =?utf-8?B?WnV6STZ1VDhBdHRKUG84THcweTgwaTZCZzNkSTRMYk1uZTcxbWxVOWhrWkI0?=
 =?utf-8?B?RGdLaE5VczZFaEJPNGNrdmkvNFByYlpQMHhOclhTcVBqSjVEYWhqbnlQMmk1?=
 =?utf-8?B?SmR2RytLbXd3WXNQeWVDLzdpWE5OdURQNTREWHVSbkZHMXI2RXhleWkzMmlj?=
 =?utf-8?B?aXpVV2d0c3V2Nlk2eG5jNkN6bTZrblFYOG8vNUUvQi9vZm01djdSVTJoais3?=
 =?utf-8?B?NW10aklQL0FMakF2UDQ2T1E1NE9lN2ZOc1ZTNUdleHRheDRlak1Rc3VxNEoy?=
 =?utf-8?B?bDdVeEMycVEwMGtmWnJ5QU1vL0h4bnZES1M2cnozbVNVbGNQcmRJUjkreTFR?=
 =?utf-8?B?bUZZZEdwSkFwYVVVcnR6bmtaN1NFZjQrVDlnanFVdytXM3ovSXM2MTljMUZW?=
 =?utf-8?B?N3ZuRHJvM1BXRXo4VVA1TVpnMkhsY2kvK0pYMVJaeDhxOGY5NHF4UmtFaTY2?=
 =?utf-8?B?aDlIaFE3YVQ4YmpJWDhTbTBnNlVUd213bFdLSi9wV0VNenBLSnUwTlFlelF0?=
 =?utf-8?B?dlZEYUFqLzRqenE2NmY2YXhxVG4vOUo5MjBiUnZOQlBLd3BYalRwODE0R25k?=
 =?utf-8?B?cXRvWjZ5VDZXQTd0TzRmZDcrVE1ra0tFRk5TQXNwZ1ZiS3NzZzNlVWhHMi9s?=
 =?utf-8?B?SDF1ejBObldGL1diOGFJcFJLaTlaTk8ybHBIVVVYWGluZ09aY21XQlgrRjZz?=
 =?utf-8?B?ZWdObi9kWnZheDVPK3V2OXhXY1Nvd0JlRDIzNlI0Rml5cTlvaU9QZEZ4ZDNl?=
 =?utf-8?B?MUZEcFJIaEdudlpheWdZWXFaaGYyc1labCs4Sk03QUQwVHFReEtIU1dIQnM3?=
 =?utf-8?B?dDFYeE9ZbHJRbU1EcUNpUTJwWTdBUUZpVS9LRm5JeGcwaFhFbXExVnA4b2Rx?=
 =?utf-8?B?SlBtTWtLSi9oaWRCMUR6Y0hjcjRySWV4UkRtZEJTL1dMeVFkcXdFSEp4cyty?=
 =?utf-8?B?ZDRNUlN0ckZXM2Q5K3hJUW5yZnNLekU4MWRRTlpRdTVhU3lYRVdwTHZsb01N?=
 =?utf-8?B?Mll2OTljZk85Y3NWdm5TLzdIalNxd0cvY05Ody9ON0RSVVNYeitLZWNHZTNW?=
 =?utf-8?B?WVMxOUpuZERMb2lvNkVibmxRY2hTMzMwQXJDTWl1Y1ZWejhITTRMS3htWXJV?=
 =?utf-8?B?MW1xQWd6NlA3Tk9DZnR2VEQ3U2pUcmRJQ3ZGbDh5aFdpNFhMaFRaSWpMaFNm?=
 =?utf-8?B?YWljY1dsK1BRMlVodkZLSnJwb2RoajdMaDZ4S3pVRzNVbzhtaE1oZi8rVXM2?=
 =?utf-8?B?ZzVUZGNMWTdxYTl1L3VHTXNlNjFTcWVZSmxMUDRCU2x0dlRLUVpVRjhLUEpn?=
 =?utf-8?B?NnY1SWdPMVN6TlljR3YvMU5mTk5UMlo0cFdiRkJIb0lMeThQZVpCY0lkSzZE?=
 =?utf-8?B?SU52Y242SlBMNTB1eHVrQ2NUK2Y3MVgzeXg2V08yU2hsWWFlNlBRQ0F2M0RH?=
 =?utf-8?B?ZmFTWVhGU3dUVTlqNzZpODMzUmxvSGdjcUlQcitMNEpDaHUyT3ZKQktrL3NQ?=
 =?utf-8?B?a3E2VUJERUx3SFluODZZcmhTSmdOTlplT29QNGVwWTBkTFlBVE9DeFNHYnFu?=
 =?utf-8?B?S2EvNFFwdXptRTBrM28xdDRsYXI3OHJHRUl0UXZuWDkvb0RiaGRKbXRCbktQ?=
 =?utf-8?B?eUdlWFhYQVlZQ2NiUHBmZW5VdW9wZU1lU3JHK0x6bW8rWUV4V0VxakF2OVdR?=
 =?utf-8?B?ellaY2VsSkJzSmJ5U1o0bk9SejdoVlRteTBtZktNblNtejNxZXgrOHF3Zlh5?=
 =?utf-8?B?UGk2bmpmTC9UY3dDNStBd3lMQmZ2ZW1nT0ZhakUxZTYreVZrUkFiWDF1cHYy?=
 =?utf-8?B?d3FVYldkRGZ4VVBzNFBaNTcxNnloeDlFeFNCRFRaNG9QdGJ0VDhEb0Nuc0VK?=
 =?utf-8?B?TS9ldFpWQi9COFgyc3JwOUlyV0x3PT0=?=
X-OriginatorOrg: theobroma-systems.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b743d20-b825-478d-a385-08daecb73843
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8536.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2023 11:48:09.4879
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 10Nsh81Xal3L51wj0EWZpa/9sky89NeDvdMnrVbF1CrP1Msej7AASJzlAYT/ht5DhlHG2bcVM8LW4ewbHJK97+AqYVAmosH26mPTfIi2adt/QhYD0S0ZoArHPDbOpfE1
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9690
X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Minas,

On 12/20/22 07:02, Minas Harutyunyan wrote:
> Hi Quentin,
> 
> On 12/16/2022 8:29 PM, Quentin Schulz <foss+kernel@0leil.net> wrote:
>> From: Quentin Schulz <foss+kernel@0leil.net>
>> Sent: Friday, December 16, 2022 8:29 PM
>> To: Minas Harutyunyan <hminas@synopsys.com>; Greg Kroah-Hartman
>> <gregkh@linuxfoundation.org>
>> Cc: Quentin Schulz <foss+kernel@0leil.net>; linux-usb@vger.kernel.org;
>> linux-kernel@vger.kernel.org; Bin Yang <yangbin@rock-chips.com>; Quentin
>> Schulz <quentin.schulz@theobroma-systems.com>
>> Subject: [PATCH v2 2/2] usb: dwc2: prevent core PHY initialization on
>> Rockchip
>>
>> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>>
>> In Rockchip vendor kernel, the core PHY initialization is disabled with the
>> following justification:
>>
>> The usb phys need to be controlled dynamically on some Rockchip SoCs.
>> So set the new HCD flag which prevents USB core from trying to manage  our
>> phys.
>>
>> This is required to get USB gadget working in dual-role mode on Ringneck
>> PX30 SoM on a Haikou Devkit.
>>
>> Cc: Bin Yang <yangbin@rock-chips.com>
>> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>> ---
>> drivers/usb/dwc2/params.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index
>> 9ed9fd956940..9095437b3236 100644
>> --- a/drivers/usb/dwc2/params.c
>> +++ b/drivers/usb/dwc2/params.c
>> @@ -117,6 +117,7 @@ static void dwc2_set_rk_params(struct dwc2_hsotg *hsotg)
>> 	p->lpm_clock_gating = false;
>> 	p->besl = false;
>> 	p->hird_threshold_en = false;
>> +	p->hcd_skip_phy_initialization = 1;
> 
> I'm not familiar with all "rk" platforms, but are you sure that
> p->hcd_skip_phy_initialization = 1 required for all of them?
> 

No I am not. This is however applied to all devices (even non-Rockchip 
ones) in Rockchip vendor kernel.

I could check on an RK3368 since we have a module available for that, 
but I don't have access to any other Rockchip platform. From a quick 
grep, the following seems to be susceptible to this change:

rk3128
rv1108
rk3288
rk3036
rk3228-evb
rk3229
rk3066a
rk3188
rk3328
px30
rk3308
rk3368

Cheers,
Quentin