Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f98a3ab9-73a8-812d-c363-8039b8837bd2@theobroma-systems.com>
Date:   Mon, 2 Jan 2023 12:55:12 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v2 0/2] usb: dwc2: fix USB peripheral role in dual-role
 mode on PX30
Content-Language: en-US
To:     Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
        Quentin Schulz <foss+kernel@0leil.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Bin Yang <yangbin@rock-chips.com>
References: <20221206-dwc2-gadget-dual-role-v2-0-0de821615dd3@theobroma-systems.com>
 <BYAPR12MB339938A2413F4D40A084F4DCA7EA9@BYAPR12MB3399.namprd12.prod.outlook.com>
From:   Quentin Schulz <quentin.schulz@theobroma-systems.com>
In-Reply-To: <BYAPR12MB339938A2413F4D40A084F4DCA7EA9@BYAPR12MB3399.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXUvS0l6MmEwd3JDOHZqVDZqdUw5SlkvSS9mZ01OakQyZHV3eVVrYWlRbmh6?=
 =?utf-8?B?Wks3TzI2OCszRW9seXBGYlZBK2RJZU5oaCtqVHdjUjRhQ3pTZ2FwczBra0l2?=
 =?utf-8?B?U2M2V0lXdU1zdUw3T1VKT01vamZvQmJGTTR3Q05QK0RSc2pPa01HUlpGMXlO?=
 =?utf-8?B?L2YrMVR5VW1TWVJNSmx4ck5zN0pXMGd6TkFKQXpkL24rbklzTzAxU2tTVmU2?=
 =?utf-8?B?bGJRS3M1VHVLY3l3R1RYcE5XMlpNbFcxWmJuTHBoQ05zNm1hOVNrYmFBaE90?=
 =?utf-8?B?RlhDZms2bGlYdk9ORjQ2aG5UeEhpOFByMjl6cTF2SGxwZDAwT25TMUtsVkpU?=
 =?utf-8?B?V3VRYkFidjBLdUhkd3NLOHVkdDhyYU9DbStKWjBhZk9lcXR6WFJVYnBiTExY?=
 =?utf-8?B?dHhPbDZER2phTyt5TVlUUXR2UnNjY3hHVWhDbjBDRWhsNXQ3blJTVWhlRlVp?=
 =?utf-8?B?Q3JPRzZqNkNWRGhZcXBYeGIzb2xIb01rRXRkYkxMTEJicThiVC8rNnNxOUNN?=
 =?utf-8?B?VklkaDNtemVVQ1JDd3drYzROem02V1VlWEhkNHJZMGtKb1ljbGJHWS9FRzlI?=
 =?utf-8?B?OHcwb2pDV0MvNVllWGFaOVFqV2NGb2pwSEg2aTMxYzFNOHg1QTV2R3ljNnYy?=
 =?utf-8?B?Z0ZNSzlEWGpyeDI3WXArTE9nTXlnN1Zwa3JXWFRjcjRIdnRwZ2NyWHIzQ1pG?=
 =?utf-8?B?RkFZdlhLbjRCdEJzeDlKbW9Sc2ZwL0dZaDd1SzZIeGVNTXNJWDRIbG1Fcnd1?=
 =?utf-8?B?UlNjK0F2OTB0bm94YjQzazQzZmNSQW5lcnYxZ1ZQWlJ5M21zK3ZnMzE3SEI0?=
 =?utf-8?B?dytUY3Y4TkRxWWpvNlhWcTVUV2FXUEswNnNoeC9HOUFFSmwyRVN0WHFlcUVM?=
 =?utf-8?B?WVlJYXQvbDZLc1U2VGQyMjZDQUV1UnYvRFl2S3lhZFdjWStvdVdmYkdsdHhn?=
 =?utf-8?B?cW1VL3Zyd3JIMW5OTllXMkVLMzcrcWJ2SGcvT1Q4b3hnb2QvdXVvRUVnWUNT?=
 =?utf-8?B?OHNqQmZSbHFtSlpxSUoyR3NaVUR2QUhZc2sxVndTZHNldzZEZ3JhTXFEUWRy?=
 =?utf-8?B?RXhQSUJObkhOa0c0djBIVTE0c0JoTWNMUU5jMVRSQTNZd3prNFpBRTN2T24v?=
 =?utf-8?B?OTM5L3h0bWNYSVBWTlNFaGRTdWdmQ1hacDJLNmtGcUR3bmM2SFMrRjFydnJG?=
 =?utf-8?B?YW5xcFlQU3NrM3VEbkJWdXk4aXRGZ3lQeERuR1BFMW03REh3MFZtMVlLT2ow?=
 =?utf-8?B?VlBJMFp4dkI2RWtJcXVvdWxtNWV5V0prUmg5aFhBRWVwZE5UbUluT09KUlNB?=
 =?utf-8?B?d2RpN1J6K0hpZDM0VTFNSUQ3NW41aHNRVWNFSGJZcnNSOGF0bHMyVjZpa2hF?=
 =?utf-8?B?L2JYYm94VmxQQUliVU9OY3ZZczduZDE5NEtOZ0ttdWdEaWpCN1k5UVNGSnRR?=
 =?utf-8?B?WS8yVGhFem1jQ0x4NkUyd0Nra3ZvM2NtTWZtdElZLzVlUENzYnlIalZoemZP?=
 =?utf-8?B?bzVMZVN2NHlEYTJCODl3ajVoN0t6Y2MvcUJyU0RpNlFvcEgzR3JUMlhjeDVL?=
 =?utf-8?B?RFlmMTNrekd5d3gzZlFmc3BUOWtWTVhXcllCaXBadDl0Qm5kZEJveWR1K0ow?=
 =?utf-8?B?azhOMWhxeGtUVCtkNm4wUnc5Szh6NGhGSjhLejR4QUdYYkJMSmUxUTZCME1N?=
 =?utf-8?B?eTFvY2NLZlBzbDM3NCtCYldadW1HUC9WbzJrNElWN1l3YWFHdXFvSUVsbGFL?=
 =?utf-8?B?TVVLVTNIVlhUVGE5UHl4aWRmSGdrdFo1d3pTbHBYZnNpb0tUV053OVVQd2tS?=
 =?utf-8?B?NVFzN1F6WGNMUXRGRVZmSW91WmtBdTAzOW1KUVhkTXF0SXpkalpMNjF3bndr?=
 =?utf-8?B?V3dDQ1V3K0R6ajhJSE1uaU1md0tlZWRHYmcvNXhxMWR1RGNMSjVqYkw4bkFI?=
 =?utf-8?B?WkFETGx4UW1yOTBCL09yV01FWFo5S09LRW91K3BMZE9iZCtoQTl0RVpCdmNN?=
 =?utf-8?B?UWUrVFhvWVB4Nk9PQ2djdGhkQUYxeWdIZkE4TytCd0l2RzFZekhWRXZYUUhx?=
 =?utf-8?B?MGVOUFJyWDM4SkpyMWpGTzNUZTVnSDhUWmQrYXl6NG5CL3Bod3JEb0ZDaXlB?=
 =?utf-8?B?TzA5T0pQTm9HdkR4SmtWbHhTV1hPUkpnS3hMeUkzakpCSE5sdjA1dWFPb1BT?=
 =?utf-8?B?aExNZ29oZDFEWTB1UWh5NEtzL2Z6NHdHL0xETnYzYkxNeWVTcDVHaTRGYkVQ?=
 =?utf-8?B?ZVM4YS9EamRIZXJ5MVdzSWx3VTFRPT0=?=
X-OriginatorOrg: theobroma-systems.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7687a260-8a92-41d3-4e48-08daecb835c3
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8536.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2023 11:55:14.7569
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iMZkgpjgFKPIGZ++x3+0XkoMB5JU+HDcArZSbWsuCzxN5OGu/lwgE1O3Z8EZ8KD8R1vxKA2T6+xeejb8ga9peVlCtiHBniNWoVOHjEpZXPXo9xrjpWwlHQCD6y03J9Tz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7628
X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Minas,

On 12/20/22 07:02, Minas Harutyunyan wrote:
> Hi Quentin,
> 
> On 12/16/2022 8:29 PM, Quentin Schulz <foss+kernel@0leil.net> wrote:
>> From: Quentin Schulz <foss+kernel@0leil.net>
>> Sent: Friday, December 16, 2022 8:29 PM
>> To: Minas Harutyunyan <hminas@synopsys.com>; Greg Kroah-Hartman
>> <gregkh@linuxfoundation.org>
>> Cc: Quentin Schulz <foss+kernel@0leil.net>; linux-usb@vger.kernel.org;
>> linux-kernel@vger.kernel.org; Bin Yang <yangbin@rock-chips.com>; Quentin
>> Schulz <quentin.schulz@theobroma-systems.com>
>> Subject: [PATCH v2 0/2] usb: dwc2: fix USB peripheral role in dual-role mode
>> on PX30
>>
>> On Theobroma Ringneck SoM, USB peripheral role when in dual-role mode does
>> not work and displays the following error message:
>> dwc2 ff300000.usb: dwc2_core_reset: HANG! Soft Reset timeout GRSTCTL_CSFTRST
>>
> 
> This mostly happen if PHY not initialized correctly.
> 

Any way to know which part of the PHY wouldn't be correctly initialized? 
or is this just a whack-a-mole game with register bits?

>> The USB sniffer shows nothing and dumping the host registers is stuck on
>> HCDMA(0) register.
>>
>> Note that for some reason it works "fine" on PX30-EVB (there's another issue
>> but not related to/fixed in this patch series).
>>
>> Since there's no documentation available for this IP, this patch series is
>> basically just slightly adapted downstream BSP vendor kernel patches and I
>> cannot unfortunately give more information than what I have.
>>
>> This patch series was tested on Theobroma Ringneck SoM on Haikou devkit and
>> PX30 EVB. It fixes Ringneck support and does not break PX30-EVB's.
>>
>> For reference, the content of those commits can be found in tag linux-5.10-
>> gen-rkr1, and the following commits have been used:
>> 964d50060bf53a8defd1fc561b9261424f25ddad
>> ad81c375602819a538ad68d979906c05663046e2
>> 6e6adab8f735bc4fe27a67bdc3144d8fa89250d4
>> 7c3a4e60247fd7f7b04d95d15cb12c63a5c20408
>>
>> Note that Rockchip kernel called a slightly different implementation of
>> __dwc2_lowlevel_hw_enable instead of dwc2_lowlevel_hw_enable but it seemed
>> more right to me to call dwc2_lowlevel_hw_enable as done for the forced
>> peripheral mode.
>>
>> Note that it is still not flawlessly working but the support is improved
>> (somewhat working vs not working at all).
> 
> If "still not flawlessly working" maybe required deeper investigate issue
> and submit "flawlessly working" patch.
> 

I would love to honestly. But no documentation and the vendor kernel 
works differently but not better. I get the point, not sure I'll be able 
to provide any meaningful improvement to this patch though. Let's see if 
I'll have time to dig into this sometime soon (I expect not :/).

I'm all ears if someone wants to share how they would start debugging 
this though.

Cheers,
Quentin