Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Date:   Mon, 02 Jan 2023 12:20:02 +0000
From:   Marc Zyngier <maz@kernel.org>
To:     Miaoqian Lin <linmq006@gmail.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Saravana Kannan <saravanak@google.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqchip: Fix refcount leak in platform_irqchip_probe
In-Reply-To: <20230102121318.3990586-1-linmq006@gmail.com>
References: <20230102121318.3990586-1-linmq006@gmail.com>
User-Agent: Roundcube Webmail/1.4.13
Message-ID: <6fa4699cc0b1b17943d4c67e53c432a4@kernel.org>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023-01-02 12:13, Miaoqian Lin wrote:
> of_irq_find_parent() returns a node pointer with refcount incremented,
> We should use of_node_put() on it when not needed anymore.
> Add missing of_node_put() to avoid refcount leak.
> 
> Fixes: f8410e626569 ("irqchip: Add IRQCHIP_PLATFORM_DRIVER_BEGIN/END
> and IRQCHIP_MATCH helper macros")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>

Please stop sending these patches one by one.

Send a series covering the whole of the irqchip subsystem, once
you have looked at all the drivers.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...