Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp10610777rwl; Mon, 2 Jan 2023 05:34:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXuC1/wZ7twmZQHOOmRu6U36m+gZWMSd5G/EHv0hRCZZbav8Lj9lWNTQq/v4pWEYtpLfJKGi X-Received: by 2002:aa7:db53:0:b0:45c:835c:c6d0 with SMTP id n19-20020aa7db53000000b0045c835cc6d0mr35667707edt.1.1672666469992; Mon, 02 Jan 2023 05:34:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672666469; cv=none; d=google.com; s=arc-20160816; b=zS1uz2S2Nw6gkSxb55FF4Wa8pfhH+GZ/fATyEM53argBYDgWsGvXpOMQlUZRHEzzFx PDr/aowIFtJoO0ag5/B/u4EMxNrj9rZoekyYb5X/uHh0q6CD6eTyMzBuORaKGkhXcCVP OrzBZ6YLR25Xt6a34wZKQ4MkCZFwIdpizwuePyuK4dXBLCa11QQdR+gy10mk0tY2+FPN 9V+7cCm4HkBtSNsGoFw4OxmSFoXDYvZyDcfR2U3GlRCeZ0qLr6XAWC+MpAECm5TP5V9d A/LsOKb8hAShjwnsTMvgabky7umbfsVmouJc2yLe6ufzAJIywTDVydx6tIjXVY1PsI0G dkHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=i9GaTllsP9ypp4U3OKqhViXfQbzgtzm78ymZRKXYwps=; b=PFjfB5dvL1wf/DGQfzT1kfFgbV3K2SfWbS8e4QbCziKy8e1Tte2XU+E7zqK5hBfj/k xXta3OZQquvXwGGuzRZSyZ46KrSIIAQ5oYRPipTrr50mSMrABC+7Yaxy5Oa52cRBJOiY 9LJzO/7hhDoWQpRuzfK3Rlu2nkppeaa2jbDE+Yw/kyNcT5SgEJq6nao0djDLfsuBwL/Q GceS5ZciR/NgtC47YRHTXtAF2J0DgZL05fcUN4uBkvotv6zr+KwAblC/C3uYJWX8MAZr orwYp1QUe9mI8Ct4piLt+Kkmb6iNlI7ry/LQ24t7tcZoGCCSshuYcuSbBOvIGPa6ZzR6 pSpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hKwI5pCv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x9-20020aa7d6c9000000b0046351fa4ae2si22200421edr.99.2023.01.02.05.34.15; Mon, 02 Jan 2023 05:34:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hKwI5pCv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232870AbjABMzl (ORCPT + 62 others); Mon, 2 Jan 2023 07:55:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbjABMzj (ORCPT ); Mon, 2 Jan 2023 07:55:39 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2FE7C7B; Mon, 2 Jan 2023 04:55:38 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6869F60F9B; Mon, 2 Jan 2023 12:55:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E27FEC433D2; Mon, 2 Jan 2023 12:55:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672664137; bh=+O8WT+Mutfqnirbic+s0CqiW9/5UVPlgZlFFpC0wM2Y=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hKwI5pCvfacoAtQhp1K8GooIUKpyPdOL2/1bYIRCDxrIIcSfqlu7YkLqvtT6yBbyK //B4UoIBfESwsLpvUNlqaMfB5I/3RvU5CUarfw2h8z4puo4pIpurnabjWPgTA2E1mF atIAdQdyMyiCg6087kDCC/FauAvNdLz70SrInmefNaRgMRLbmlGVDKuBydCOaJ8nMw Ud5VaAI5LeykH5aG6HvUYCh4a04xtNrtS8helW2KxEVvndmqUvGLoW58R5m1KIxioC tmp+l6MdMFUiy13f7hJuvTc121CbZySrfrVe0sl3gHKc4GdIZxxQYn5A+mXDJHhh9y l/5T7AYXcPwJw== Message-ID: <2b50caa7-68a7-ee99-594c-0293168666cb@kernel.org> Date: Mon, 2 Jan 2023 14:55:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 2/2] net: ti: icssg-prueth: Add ICSSG ethernet driver Content-Language: en-US To: Krzysztof Kozlowski , MD Danish Anwar , "Andrew F. Davis" , Tero Kristo , Suman Anna , YueHaibing , Vignesh Raghavendra , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , andrew@lunn.ch Cc: nm@ti.com, ssantosh@kernel.org, srk@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20221223110930.1337536-1-danishanwar@ti.com> <20221223110930.1337536-3-danishanwar@ti.com> From: Roger Quadros In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 23/12/2022 13:32, Krzysztof Kozlowski wrote: > On 23/12/2022 12:09, MD Danish Anwar wrote: >> From: Roger Quadros >> >> This is the Ethernet driver for TI AM654 Silicon rev. 2 >> with the ICSSG PRU Sub-system running dual-EMAC firmware. >> > > > (...) > >> + >> +/* Memory Usage of : DMEM1 >> + * >> + */ > > ??? What's this? > >> + >> +/* Memory Usage of : PA_STAT >> + * >> + */ > > Same question. > >> + >> +/*Start of 32 bits PA_STAT counters*/ > > That's not a Linux coding style. Add spaces and make it readable. The contents of this file were copied from f/w. This file needs to be reduced to only the elements that we really use in the Linux driver and coding style fixed. cheers, -roger