Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <17a2982e-f4e8-f8bd-db8f-dd14bf27b4e7@gmx.de>
Date:   Mon, 2 Jan 2023 15:48:21 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] matroxfb: G200eW: Increase max memory from 1 MB to 16 MB
Content-Language: en-US
To:     Paul Menzel <pmenzel@molgen.mpg.de>, "Z. Liu" <liuzx@knownsec.com>
Cc:     it+linux-fbdev@molgen.mpg.de, Rich Felker <dalias@libc.org>,
        stable@vger.kernel.org, linux-fbdev@vger.kernel.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <20230102135731.6487-1-pmenzel@molgen.mpg.de>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20230102135731.6487-1-pmenzel@molgen.mpg.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:z6gzU0P4Vkk=;dQYG9VM4sTyZ0ppmp5CCsi7GSut
 GDuitMne9sLdvy5EKVAwni+274uOK1jvMkCfssSsjpDCpi6YHvBXUoFGQVaT/QEYP0IFyGGae
 Fh2UXq9hv2FXUFokyhxP6OmbELq6G5IotwKXCHszdU9o9zrR+Cu/USPuaftynrVEA+LdpOv8M
 QrFtSHKUF4Bz7ZmAZiVBE581Yn8P/0Nf2khlAu8lP283SeeCXrljHkYKsiV9deECUZSnYQAXG
 Pz0UzlJoFKLGMO/LaQQ8AfYCgn7M0UFSlDDC2AtS/u4NNjHmMkXoi88YALov9VEiqwhTmMygb
 0zj6knzAXWC35VkDnS0e7hFbF5f0Wlw1HwFDxsJLDMTYvuVu+VVlJkzaIDvxQW5/d5g4m60EP
 WNJKvPath2U1ux8m9zvBPgQOxrJA1G15KG994xSAMX1orJ6sKFjyKmbTV8k+wpEvfdFyB0K94
 8V4R6bm9MXAB6RGQ3KJhgVnrxCr4xlTXefRxwCQzTD+iZ9pI4Jp/xbCMmEBNcNZvu8TQzp+ZM
 rtsJ75tShkzjvJ6HJkMhe3wjTG+vWnnVYGy086+iR4b6un5nu1OtPeCILB2fg/i8NJodIKAaV
 YJRACTjwiQr9wfgm5Swh1tFo6Sauv4oLp4HV5cAsOREDkXrHX4mZZ6ZoObWM1gBWlKGV9xAcY
 VXIbLv+y6y88/8E5+c6V5qsdSf7bNgPqkTsOJxAmx229irjZxSXI0nascGN/ceffp//chH/pZ
 ck0vA7oYg6L6AZeGp47MPzBy30LRRs2dg0t7TXyqwFeBzFKDD6tdJ4Ix+4Uxa4hcyzBysdZSh
 kEsw1UzKOOhcVCD/5W2hR7pwVVO79jBs5hxciNYe1zTMdGXV18cQYWDhJkGycY/4FMGguvYDa
 HGQwEcdA3cISEpcezc1sE1IW2VoGozI7w93+vS0VYCV31i/DC1QaEsCWDBgR4MVjQy/j0JNsm
 0cvPRuBttroAuvFizkPwr2NbmPY=
Precedence: bulk

On 1/2/23 14:57, Paul Menzel wrote:
> Commit 62d89a7d49af ("video: fbdev: matroxfb: set maxvram of vbG200eW to
> the same as vbG200 to avoid black screen") accidently decreases the
> maximum memory size for the Matrox G200eW (102b:0532) from 8 MB to 1 MB
> by missing one zero. This caused the driver initialization to fail with
> the messages below, as the minimum required VRAM size is 2 MB:
>
>       [    9.436420] matroxfb: Matrox MGA-G200eW (PCI) detected
>       [    9.444502] matroxfb: cannot determine memory size
>       [    9.449316] matroxfb: probe of 0000:0a:03.0 failed with error -=
1
>
> So, add the missing 0 to make it the intended 16 MB. Successfully tested=
 on
> the Dell PowerEdge R910/0KYD3D, BIOS 2.10.0 08/29/2013, that the warning=
 is
> gone.
>
> While at it, add a leading 0 to the maxdisplayable entry, so it=E2=80=99=
s aligned
> properly. The value could probably also be increased from 8 MB to 16 MB,=
 as
> the G200 uses the same values, but I have not checked any datasheet.
>
> Note, matroxfb is obsolete and superseded by the maintained DRM driver
> mga200, which is used by default on most systems where both drivers are
> available. Therefore, on most systems it was only a cosmetic issue.
>
> Fixes: 62d89a7d49af ("video: fbdev: matroxfb: set maxvram of vbG200eW to=
 the same as vbG200 to avoid black screen")
> Link: https://lore.kernel.org/linux-fbdev/972999d3-b75d-5680-fcef-6e6905=
c52ac5@suse.de/T/#mb6953a9995ebd18acc8552f99d6db39787aec775
> Cc: it+linux-fbdev@molgen.mpg.de
> Cc: Z. Liu <liuzx@knownsec.com>
> Cc: Rich Felker <dalias@libc.org>
> Cc: stable@vger.kernel.org
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>

applied this v1 version to the fbdev git tree.
Thanks!
Helge


> ---
>   drivers/video/fbdev/matrox/matroxfb_base.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/matrox/matroxfb_base.c b/drivers/video/=
fbdev/matrox/matroxfb_base.c
> index 0d3cee7ae7268..a043a737ea9f7 100644
> --- a/drivers/video/fbdev/matrox/matroxfb_base.c
> +++ b/drivers/video/fbdev/matrox/matroxfb_base.c
> @@ -1378,8 +1378,8 @@ static struct video_board vbG200 =3D {
>   	.lowlevel =3D &matrox_G100
>   };
>   static struct video_board vbG200eW =3D {
> -	.maxvram =3D 0x100000,
> -	.maxdisplayable =3D 0x800000,
> +	.maxvram =3D 0x1000000,
> +	.maxdisplayable =3D 0x0800000,
>   	.accelID =3D FB_ACCEL_MATROX_MGAG200,
>   	.lowlevel =3D &matrox_G100
>   };