Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp10727051rwl; Mon, 2 Jan 2023 07:16:26 -0800 (PST) X-Google-Smtp-Source: AMrXdXuLdLZvAPDeCgRGNI3yDTeP/D3oiX+nd39umd81fRCzqsP9xm65CYmXG8353yergWZsBn6I X-Received: by 2002:a17:902:c115:b0:192:6e91:7daf with SMTP id 21-20020a170902c11500b001926e917dafmr38858822pli.53.1672672586573; Mon, 02 Jan 2023 07:16:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672672586; cv=none; d=google.com; s=arc-20160816; b=sG1rvGSRuMfNjeBucHjato1zpiLXuxWiTCmkDp/ilVLUzrepfhr1iYThMq7SkAoyw5 p5yeBr05CRYxt/XEatC+puS497jATPRstz58cjkd0zVGjwH88p5a78UiAR5yUkttlpfX 2ud8WjpSW+rId4fufBlhFvsCGhfITwTUxquiFlLDYCoOCA+3CEQL6Y+9nJ8/s+bQJ4Zb HkSaP0q8gJrS0X1v8wmq/bnxw8Zy9Gi2gG6IJ4ae9hVmR99BRuoW9kgv53+1LTRIn6nL GB+Fu2/GVBNxXqV/b1A8ECNTw+cldEHeY+bHwzJrnmIpX8iUhMrLEkzXR2MlFPXKVUsv X7SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=kufovSBO5hUSNufFBCwiN98tALIhP/0+6ECN5np/fnk=; b=nkSU0SrY6a9tEU3jB1n63gECahfM58rMaRbs16eSUyJSdDtTDKSOumLVSPqFztobPr JWeJlePUs+Nq/jsmf4ESc2t4BnOHnMLL+r1s/YM3Zvyo9xjCJJyQczmYrpsWdGpKGdjZ nITe2dNBiOmQTVwBe0zqKWHDD4M1izjjILe9ZtHAppaEAWeB+KwgLK3a4sT4QVNG53bB tXBj+E6E2waZn23ycfoArA62A/pfOxa2wVpXI2JX+cYP6fMpQ+k9+nrD0QQXJAx9ripc 7012uPaFBvXZKY+vuvUvVUMtv8o2BaO4UrYw8FHara1cudA/aO1KaUPg47TEnc7OjLC1 YUkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="eiXb/uNl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n18-20020a170903111200b0019111dd056asi31733308plh.338.2023.01.02.07.16.18; Mon, 02 Jan 2023 07:16:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="eiXb/uNl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232847AbjABO7U (ORCPT + 61 others); Mon, 2 Jan 2023 09:59:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbjABO7T (ORCPT ); Mon, 2 Jan 2023 09:59:19 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C229B65BD for ; Mon, 2 Jan 2023 06:59:18 -0800 (PST) Received: from [192.168.2.142] (109-252-113-89.nat.spd-mgts.ru [109.252.113.89]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id B000B660036F; Mon, 2 Jan 2023 14:59:16 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1672671557; bh=P6twPSAUn14MSaKncu4Q5IlCvYzqCSUxPdVT3emjtIs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eiXb/uNl6OdbnvNa1TpajuzdJTUnkviFtgSQlA83EuxsK0IBdsUCmfw6IuWDgqUG2 Oi7wbyVkaTjS0/dea17uYhzclwCCmSikoLYL6S8V7dt0Bubdr5i90byVz9vLAhpy81 Pw62KiRi1wJ9V8r0buOko4jUYqMht+rORRSmf7fGgInJwMw5ymBUaQK0Hy/leBDTvA 4FqRur1eWIW0yQ5GFwLPkktC0M8AB8UIQvgLCP+u5OtUajINEDZ6Ht8l+BQNdvfiBD IRm0jLGXv31e9nTg4NVMSZ0733UfC8YLxl7KffBhO5Rkq2UfOPYy4TsYFovQPWzQGb 2fwc7RossPKXQ== Message-ID: Date: Mon, 2 Jan 2023 17:59:14 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2] drm/virtio: Spiff out cmd queue/response traces Content-Language: en-US To: Rob Clark , dri-devel@lists.freedesktop.org Cc: Rob Clark , David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , "open list:VIRTIO GPU DRIVER" , open list References: <20221130000841.318037-1-robdclark@gmail.com> From: Dmitry Osipenko In-Reply-To: <20221130000841.318037-1-robdclark@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/30/22 03:08, Rob Clark wrote: > From: Rob Clark > > Add a sequence # for more easily matching up cmd/resp, and the # of free > slots in the virtqueue to more easily see starvation issues. > > v2: Fix handling of string fields as well > > Signed-off-by: Rob Clark > Reviewed-by: Dmitry Osipenko > --- > drivers/gpu/drm/virtio/virtgpu_drv.h | 3 +++ > drivers/gpu/drm/virtio/virtgpu_trace.h | 26 +++++++++++++++----------- > drivers/gpu/drm/virtio/virtgpu_vq.c | 13 ++++++++++--- > 3 files changed, 28 insertions(+), 14 deletions(-) Applied to drm-misc-next -- Best regards, Dmitry