Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp10852293rwl; Mon, 2 Jan 2023 09:10:13 -0800 (PST) X-Google-Smtp-Source: AMrXdXvTuUq48UpBwUzrT2FsUbuTglPg/AEY2vQ3Bcz5s4ErA1DzZwGzsrb1L6cIWYU1sLRV3QhZ X-Received: by 2002:a62:834b:0:b0:582:998a:bed5 with SMTP id h72-20020a62834b000000b00582998abed5mr2135693pfe.23.1672679413000; Mon, 02 Jan 2023 09:10:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672679412; cv=none; d=google.com; s=arc-20160816; b=Y1LGkyBbwBreu0ce544y/lwV8Uefxh1IsweAiN0Wv5Mha5F4JCw+lkVcW+q//KyWYs xbunDn9bjR0F7OUdtunKBTn+d5PMNj5KABPrMazs9Ipu+Ru3ODxGgsNTXjkKzl+jjLe1 u5m87ovPhRtpRAWs7nbTpuMDcUicjYY6R3MW7aP8l40dDrHLSts9kinJq9RD76ZZxbEJ 5bwByPIohDqtK4wiTfek4pNQlqlaDN8O6yBONQUgLJG98qKOYnBJL4cfdTjlRUUPQZV1 7nHbTcXrQHF2vQFZNHhk/lh66xFc1izj+BNqVCFO6wlYDyrtEk5BMOImuUO+8ukGwGJ0 xZyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=yMroW05oFhzknL98EQCsQ+SYSzTJ+LrSISoJgrOG1c4=; b=HbxEI2+iuMbk1tGC0Y+YpDrrDQ2a0PG34+nqrt0wNd3c8eQ+CjbG4CJaC4i6JwRkk3 swj3ip1wijSezu+4ayzhjQJYxU1VDiA9VfEFrbU6ks2TYbg1q463FYG9/rTZwI6QeK9m AjgGCJ+rMjGLLEeNx74IpRVT3yOapV3fiTj5mapwkzrBe91NcoNubHNKvDLZph5w40OM aCiHwreuZtYy6dwxhnKw2ptlfkePrL2RKrlYQoZkdb6UdofFaNtsWhQ1a3NDjCFFmqa9 QFH076eKGf7TrAXvUJA9F0HFIQ16bP11TrrQZDKZuvfXfh4kai6G0hxt9ohbwNpG1HQn Icvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@resnulli-us.20210112.gappssmtp.com header.s=20210112 header.b=z6lnklFS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t28-20020aa7947c000000b00577d10d6eaesi21629200pfq.169.2023.01.02.09.10.05; Mon, 02 Jan 2023 09:10:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20210112.gappssmtp.com header.s=20210112 header.b=z6lnklFS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236329AbjABPj5 (ORCPT + 61 others); Mon, 2 Jan 2023 10:39:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232889AbjABPjy (ORCPT ); Mon, 2 Jan 2023 10:39:54 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BEF3C0 for ; Mon, 2 Jan 2023 07:39:53 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id w1so14474807wrt.8 for ; Mon, 02 Jan 2023 07:39:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yMroW05oFhzknL98EQCsQ+SYSzTJ+LrSISoJgrOG1c4=; b=z6lnklFSzA0EUtdobeGYXiDOCKMR83l8jJ5DsNGAUKi0waNzUooYubwdcTs3pe5VVB 9wGgFoHpBJXkvb9uCDCtHuhnqyYYQ1UXWu7zgGQMn4ki2w212Iz9sPYRJy/8tbD4h5Zc 0Fq0NEgUwH0WA2H5bBzCS4BkvR4+3F5lgSbtoirwyuhuFeLJCLjhFHagaITMSHi5LN0G K69E+HsNzg0S28aO7qdYPIbL9+4Kz3w7ZCvsdzzovupAZWp7si7RhlBH4U598c41myEh WIXx2CsE6cZWP42xWUFNN/L6zU1to+73+sbv/Z0xVTu88f68x6iu7R79GSAvdrCnBXEc hnmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yMroW05oFhzknL98EQCsQ+SYSzTJ+LrSISoJgrOG1c4=; b=ImCSxUwtGNEY2VYZW4uRi9rutAB2uvzm77jTixXkY2nn1F8FFv1UHFa4eXpMrpHXGq v5oSj0B1vtspvlQdJfQYi+pVdxD8Q6MH108tyscwDE/Rms/AGbMsMRjNNP9O7Y6SCUQ8 KvR5CMw+VaTYe8VpfOWy/momcvO+JWCQUJYmDV5FmktWXMCJ/F/olc0RlLgct+JlV5T8 HbguANefuG4CmdIeO52nVqVj8oGgwrBKSiUOSui8cwDiAuAFI7uX86NE7gfUyfgywtKC 0c5FmkiB8C3BVt6LgdTEUKkuPVYsfDU2Y78AVBpaFAY48TvpkR5u3S3Ld3zSWogR8H2Q zpvQ== X-Gm-Message-State: AFqh2koyIwh+cTq48CCKvIdonb0Dg4k6N86bI2kptIjTHCpxXDPR8qQK 7fj2iDwmM94UOcj8F3LGUcLxlQ== X-Received: by 2002:a5d:4b06:0:b0:28a:87f4:b21c with SMTP id v6-20020a5d4b06000000b0028a87f4b21cmr10061768wrq.32.1672673992182; Mon, 02 Jan 2023 07:39:52 -0800 (PST) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id c4-20020adfe704000000b00241b5af8697sm29097757wrm.85.2023.01.02.07.39.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 07:39:51 -0800 (PST) Date: Mon, 2 Jan 2023 16:39:50 +0100 From: Jiri Pirko To: Daniil Tatianin Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH net v2] drivers/net/bonding/bond_3ad: return when there's no aggregator Message-ID: References: <20230102095335.94249-1-d-tatianin@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230102095335.94249-1-d-tatianin@yandex-team.ru> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mon, Jan 02, 2023 at 10:53:35AM CET, d-tatianin@yandex-team.ru wrote: >Otherwise we would dereference a NULL aggregator pointer when calling >__set_agg_ports_ready on the line below. > >Found by Linux Verification Center (linuxtesting.org) with the SVACE >static analysis tool. > >Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") >Signed-off-by: Daniil Tatianin Reviewed-by: Jiri Pirko