Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@kernel.org>
To:     Chen Guokai <chenguokai17@mails.ucas.ac.cn>,
        paul.walmsley@sifive.com, palmer@dabbelt.com,
        aou@eecs.berkeley.edu, rostedt@goodmis.org, mingo@redhat.com,
        sfr@canb.auug.org.au
Cc:     linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        liaochang1@huawei.com, Chen Guokai <chenguokai17@mails.ucas.ac.cn>
Subject: Re: [PATCH v5 6/9] riscv/kprobe: Add code to check if kprobe can be
 optimized
In-Reply-To: <20221224114315.850130-7-chenguokai17@mails.ucas.ac.cn>
References: <20221224114315.850130-1-chenguokai17@mails.ucas.ac.cn>
 <20221224114315.850130-7-chenguokai17@mails.ucas.ac.cn>
Date:   Mon, 02 Jan 2023 19:04:00 +0100
Message-ID: <87sfgsvmnj.fsf@all.your.base.are.belong.to.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Chen Guokai <chenguokai17@mails.ucas.ac.cn> writes:

> From: Liao Chang <liaochang1@huawei.com>

> diff --git a/arch/riscv/kernel/probes/opt.c b/arch/riscv/kernel/probes/op=
t.c
> index a0d2ab39e3fa..258a283c906d 100644
> --- a/arch/riscv/kernel/probes/opt.c
> +++ b/arch/riscv/kernel/probes/opt.c
> @@ -271,15 +271,103 @@ static void find_free_registers(struct kprobe *kp,=
 struct optimized_kprobe *op,
>  	*ra =3D (kw =3D=3D 1UL) ? 0 : __builtin_ctzl(kw & ~1UL);
>  }
>=20=20
> +static bool insn_jump_into_range(unsigned long addr, unsigned long start,
> +				 unsigned long end)
> +{
> +	kprobe_opcode_t insn =3D *(kprobe_opcode_t *)addr;
> +	unsigned long target, offset =3D GET_INSN_LENGTH(insn);
> +
> +#ifdef CONFIG_RISCV_ISA_C
> +	if (offset =3D=3D RVC_INSN_LEN) {
> +		if (riscv_insn_is_c_beqz(insn) || riscv_insn_is_c_bnez(insn))
> +			target =3D addr + rvc_branch_imme(insn);
> +		else if (riscv_insn_is_c_jal(insn) || riscv_insn_is_c_j(insn))
> +			target =3D addr + rvc_jal_imme(insn);
> +		else
> +			target =3D 0;
> +		return (target >=3D start) && (target < end);
> +	}
> +#endif
> +
> +	if (riscv_insn_is_branch(insn))
> +		target =3D addr + rvi_branch_imme(insn);
> +	else if (riscv_insn_is_jal(insn))
> +		target =3D addr + rvi_jal_imme(insn);
> +	else
> +		target =3D 0;
> +	return (target >=3D start) && (target < end);
> +}
> +
> +static int search_copied_insn(unsigned long paddr, struct optimized_kpro=
be *op)
> +{
> +	int i =3D  1;
> +	unsigned long offset =3D GET_INSN_LENGTH(*(kprobe_opcode_t *)paddr);
> +
> +	while ((i++ < MAX_COPIED_INSN) && (offset < 2 * RVI_INSN_LEN)) {
> +		if (riscv_probe_decode_insn((probe_opcode_t *)paddr + offset,
> +					    NULL) !=3D INSN_GOOD)

If the second argument is NULL, and the insn is auipc, we'll splat with
NULL-ptr exception.

Hmm, probe_opcode_t is u32, right? And GET_INSN_LENGTH() returns 4 or 2
...then the pointer arithmetic will be a mess?


Bj=C3=B6rn