Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2f1beb15-e9e4-d8ab-1b68-c83f1a53c5c5@linux.ibm.com>
Date:   Mon, 2 Jan 2023 19:25:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: [PATCH v3 2/7] iommu: Allow .iotlb_sync_map to fail and handle
 s390's -ENOMEM return
Content-Language: en-US
To:     Niklas Schnelle <schnelle@linux.ibm.com>,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Wenjia Zhang <wenjia@linux.ibm.com>
Cc:     Matthew Rosato <mjrosato@linux.ibm.com>,
        Gerd Bayer <gbayer@linux.ibm.com>,
        Pierre Morel <pmorel@linux.ibm.com>, iommu@lists.linux.dev,
        linux-s390@vger.kernel.org, borntraeger@linux.ibm.com,
        hca@linux.ibm.com, gor@linux.ibm.com,
        gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com,
        svens@linux.ibm.com, linux-kernel@vger.kernel.org,
        Julian Ruess <julianr@linux.ibm.com>
References: <20230102115619.2088685-1-schnelle@linux.ibm.com>
 <20230102115619.2088685-3-schnelle@linux.ibm.com>
From:   Alexandra Winter <wintera@linux.ibm.com>
In-Reply-To: <20230102115619.2088685-3-schnelle@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 02.01.23 12:56, Niklas Schnelle wrote:
> On s390 .iotlb_sync_map is used to sync mappings to an underlying
> hypervisor by letting the hypervisor inspect the synced IOVA range and
> updating its shadow table. This however means that it can fail as the
> hypervisor may run out of resources. This can be due to the hypervisor
> being unable to pin guest pages, due to a limit on concurrently mapped
> addresses such as vfio_iommu_type1.dma_entry_limit or other resources.
> Either way such a failure to sync a mapping should result in
> a DMA_MAPPING_EROR.
> 
> Now especially when running with batched IOTLB flushes for unmap it may
> be that some IOVAs have already been invalidated but not yet synced via
> .iotlb_sync_map. Thus if the hypervisor indicates running out of
> resources, first do a global flush allowing the hypervisor to free
> resources associated with these mappings and only if that also fails
> report this error to callers.
> 
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> ---
Just a small typo, I noticed
[...]
> diff --git a/drivers/iommu/s390-iommu.c b/drivers/iommu/s390-iommu.c
> index ed33c6cce083..6ba38b4f5b37 100644
> --- a/drivers/iommu/s390-iommu.c
> +++ b/drivers/iommu/s390-iommu.c
> @@ -210,6 +210,14 @@ static void s390_iommu_release_device(struct device *dev)
>  		__s390_iommu_detach_device(zdev);
>  }
>  
> +
> +static int zpci_refresh_all(struct zpci_dev *zdev)
> +{
> +	return zpci_refresh_trans((u64)zdev->fh << 32, zdev->start_dma,
> +				  zdev->end_dma - zdev->start_dma + 1);
> +
> +}
> +
>  static void s390_iommu_flush_iotlb_all(struct iommu_domain *domain)
>  {
>  	struct s390_domain *s390_domain = to_s390_domain(domain);
> @@ -217,8 +225,7 @@ static void s390_iommu_flush_iotlb_all(struct iommu_domain *domain)
>  
>  	rcu_read_lock();
>  	list_for_each_entry_rcu(zdev, &s390_domain->devices, iommu_list) {
> -		zpci_refresh_trans((u64)zdev->fh << 32, zdev->start_dma,
> -				   zdev->end_dma - zdev->start_dma + 1);
> +		zpci_refresh_all(zdev);
>  	}
>  	rcu_read_unlock();
>  }
> @@ -242,20 +249,32 @@ static void s390_iommu_iotlb_sync(struct iommu_domain *domain,
>  	rcu_read_unlock();
>  }
>  
> -static void s390_iommu_iotlb_sync_map(struct iommu_domain *domain,
> +static int s390_iommu_iotlb_sync_map(struct iommu_domain *domain,
>  				      unsigned long iova, size_t size)
>  {
>  	struct s390_domain *s390_domain = to_s390_domain(domain);
>  	struct zpci_dev *zdev;
> +	int ret = 0;
>  
>  	rcu_read_lock();
>  	list_for_each_entry_rcu(zdev, &s390_domain->devices, iommu_list) {
>  		if (!zdev->tlb_refresh)
>  			continue;
> -		zpci_refresh_trans((u64)zdev->fh << 32,
> -				   iova, size);
> +		ret = zpci_refresh_trans((u64)zdev->fh << 32,
> +					 iova, size);
> +		/*
> +		 * let the hypervisor disover invalidated entries
			typo: s/disover/discover/g
> +		 * allowing it to free IOVAs and unpin pages
> +		 */
> +		if (ret == -ENOMEM) {
> +			ret = zpci_refresh_all(zdev);
> +			if (ret)
> +				break;
> +		}
>  	}
>  	rcu_read_unlock();
> +
> +	return ret;
>  }
>  
>  static int s390_iommu_validate_trans(struct s390_domain *s390_domain,
[...]