Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 2 Jan 2023 19:34:47 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Roger Quadros <rogerq@kernel.org>
Cc:     MD Danish Anwar <danishanwar@ti.com>,
        "Andrew F. Davis" <afd@ti.com>, Tero Kristo <t-kristo@ti.com>,
        Suman Anna <s-anna@ti.com>, YueHaibing <yuehaibing@huawei.com>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>, nm@ti.com,
        ssantosh@kernel.org, srk@ti.com, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, netdev@vger.kernel.org,
        linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/2] dt-bindings: net: Add ICSSG Ethernet Driver
 bindings
Message-ID: <Y7Mjx8ZEVEcU2mK8@lunn.ch>
References: <20221223110930.1337536-1-danishanwar@ti.com>
 <20221223110930.1337536-2-danishanwar@ti.com>
 <Y6W7FNzJEHYt6URg@lunn.ch>
 <620ce8e6-2b40-1322-364a-0099a6e2af26@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <620ce8e6-2b40-1322-364a-0099a6e2af26@kernel.org>
Precedence: bulk

On Mon, Jan 02, 2023 at 03:04:19PM +0200, Roger Quadros wrote:
> 
> 
> On 23/12/2022 16:28, Andrew Lunn wrote:
> >> +        ethernet-ports {
> >> +            #address-cells = <1>;
> >> +            #size-cells = <0>;
> >> +            pruss2_emac0: port@0 {
> >> +                reg = <0>;
> >> +                phy-handle = <&pruss2_eth0_phy>;
> >> +                phy-mode = "rgmii-rxid";
> > 
> > That is unusual. Where are the TX delays coming from?
> 
> >From the below property
> 
> +                ti,syscon-rgmii-delay = <&scm_conf 0x4120>;
> 
> The TX delay can be enabled/disabled from within the ICSSG block.
> 
> If this property exists and PHY mode is neither PHY_INTERFACE_MODE_RGMII_ID
> nor PHY_INTERFACE_MODE_RGMII_TXID then the internal delay is enabled.
> 
> This logic is in prueth_config_rgmiidelay() function in the introduced driver.

What nearly every other MAC driver does is pass the phy-mode to the
PHY and lets the PHY add the delays. I would recommend you do that,
rather than be special and different.

       Andrew