Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 2 Jan 2023 19:50:00 +0100
From:   Sam Ravnborg <sam@ravnborg.org>
To:     Javier Martinez Canillas <javierm@redhat.com>
Cc:     linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH 11/14] drm/panel-sharp-ls060t1sx01: Drop custom DSI write
 macro
Message-ID: <Y7MnWBaQfnDHHKqv@ravnborg.org>
References: <20221228014757.3170486-1-javierm@redhat.com>
 <20221228014757.3170486-12-javierm@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221228014757.3170486-12-javierm@redhat.com>
Precedence: bulk

On Wed, Dec 28, 2022 at 02:47:54AM +0100, Javier Martinez Canillas wrote:
> There is a macro for this already in the <drm/drm_mipi_dsi.h> header, use
> that instead and delete the custom DSI write macro defined in the driver.
> 
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>

This is a nice patch - where you benefit from the more advanced macro,
and drop even more code.

Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

> ---
> 
>  .../gpu/drm/panel/panel-sharp-ls060t1sx01.c   | 19 ++-----------------
>  1 file changed, 2 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c b/drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c
> index 8a4e0c1fe73f..68f52eaaf4fa 100644
> --- a/drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c
> +++ b/drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c
> @@ -32,12 +32,6 @@ static inline struct sharp_ls060 *to_sharp_ls060(struct drm_panel *panel)
>  	return container_of(panel, struct sharp_ls060, panel);
>  }
>  
> -#define dsi_dcs_write_seq(dsi, seq...) ({				\
> -		static const u8 d[] = { seq };				\
> -									\
> -		mipi_dsi_dcs_write_buffer(dsi, d, ARRAY_SIZE(d));	\
> -	})
> -
>  static void sharp_ls060_reset(struct sharp_ls060 *ctx)
>  {
>  	gpiod_set_value_cansleep(ctx->reset_gpio, 0);
> @@ -56,17 +50,8 @@ static int sharp_ls060_on(struct sharp_ls060 *ctx)
>  
>  	dsi->mode_flags |= MIPI_DSI_MODE_LPM;
>  
> -	ret = dsi_dcs_write_seq(dsi, 0xbb, 0x13);
> -	if (ret < 0) {
> -		dev_err(dev, "Failed to send command: %d\n", ret);
> -		return ret;
> -	}
> -
> -	ret = dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_MEMORY_START);
> -	if (ret < 0) {
> -		dev_err(dev, "Failed to send command: %d\n", ret);
> -		return ret;
> -	}
> +	mipi_dsi_dcs_write_seq(dsi, 0xbb, 0x13);
> +	mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_MEMORY_START);
>  
>  	ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
>  	if (ret < 0) {
> -- 
> 2.38.1