Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 2 Jan 2023 20:22:47 +0100
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Deepak R Varma <drv@mailo.com>
Cc:     Support Opensource <support.opensource@diasemi.com>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Saurabh Singh Sengar <ssengar@microsoft.com>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>
Subject: Re: [PATCH] power: supply: da9150: Remove redundant error logging
Message-ID: <20230102192247.rgqcmuyqpultvwsx@mercury.elektranox.org>
References: <Y6SRZZUDoiIKJ0rJ@qemulion>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="yhmmz776lzybvn6w"
Content-Disposition: inline
In-Reply-To: <Y6SRZZUDoiIKJ0rJ@qemulion>
Precedence: bulk


--yhmmz776lzybvn6w
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Dec 22, 2022 at 10:48:29PM +0530, Deepak R Varma wrote:
> A call to platform_get_irq_byname() already prints an error on failure
> within its own implementation. So printing another error based on its
> return value in the caller is redundant and should be removed. The
> clean up also makes if condition block braces and the device pointer
> variable dev unnecessary. Remove those as well.
>=20
> Issue identified using platform_get_irq.cocci coccinelle semantic patch.
>=20
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---

Thanks, queued.

-- Sebastian

> Note: The change was build tested using ARM64 defconfig.
>=20
>  drivers/power/supply/da9150-charger.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
>=20
> diff --git a/drivers/power/supply/da9150-charger.c b/drivers/power/supply=
/da9150-charger.c
> index f9314cc0cd75..14da5c595dd9 100644
> --- a/drivers/power/supply/da9150-charger.c
> +++ b/drivers/power/supply/da9150-charger.c
> @@ -466,10 +466,8 @@ static int da9150_charger_register_irq(struct platfo=
rm_device *pdev,
>  	int irq, ret;
>=20
>  	irq =3D platform_get_irq_byname(pdev, irq_name);
> -	if (irq < 0) {
> -		dev_err(dev, "Failed to get IRQ CHG_STATUS: %d\n", irq);
> +	if (irq < 0)
>  		return irq;
> -	}
>=20
>  	ret =3D request_threaded_irq(irq, NULL, handler, IRQF_ONESHOT, irq_name,
>  				   charger);
> @@ -482,15 +480,12 @@ static int da9150_charger_register_irq(struct platf=
orm_device *pdev,
>  static void da9150_charger_unregister_irq(struct platform_device *pdev,
>  					  const char *irq_name)
>  {
> -	struct device *dev =3D &pdev->dev;
>  	struct da9150_charger *charger =3D platform_get_drvdata(pdev);
>  	int irq;
>=20
>  	irq =3D platform_get_irq_byname(pdev, irq_name);
> -	if (irq < 0) {
> -		dev_err(dev, "Failed to get IRQ CHG_STATUS: %d\n", irq);
> +	if (irq < 0)
>  		return;
> -	}
>=20
>  	free_irq(irq, charger);
>  }
> --
> 2.34.1
>=20
>=20
>=20

--yhmmz776lzybvn6w
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmOzLwYACgkQ2O7X88g7
+ppQfg//edSdOgWKgG0oZOTII18b+uYQwQw5SZgEHaaQeLcOnWJSJ/3A9HKFHXRH
KmBJrGYVcizG85rIqLA+OyK7RNbt+c4AcbF633uoB4lHQhtcjctimx+rMo1DSwt9
bUsOtyqQw8jVefbHwsuuDGQ8o9tOh4TTH3wT1oHNoZ6wsmDCVI1GOi2jLjjjQbyi
2/TaFs+eosRF7s/tSrDSC5TwlQKtPF2s7emHmDKaQfOqB5WBVV0amisF00lEK7M2
jq6nUQrzoyVg4yaBnblHb41cmIbKSfDUEYfD47rQO7wCtg7k2fr48yPq5dOxqFf1
aOPw1DI3xNLLcFxn/4P50J86Bhirn7k/KbTlNxw4uT25Ht6L45mPOLreUIRBA1s7
x/gRc0hScu/ZubsQMfvfbDzvdVED2kFel04DR1Gr1Z11fJzVInxRltLcfrgcY+Rz
S5p3VF1lxy2YhZIVDb615d9XcV//UJk+UF9soOQVIhyMtQ4wR2Y4PUNAUW18rNUt
7W/XxLPcXNYmhyuJQnC4k6fnpAl7V5QZVrJ6+SH2GFqzeVAYMfvEqOma365OAHHd
moSZaaYEc9rlIwMyK9fOYmSWeKFRR8bWQYV2W8rQqltyQ7a/wx6MX/HPc31Khbhx
qq96F7zhex9kP/K6YMZquQ1qU9EV0e/iKd9O8QP1e6uccoYZJQY=
=JV7R
-----END PGP SIGNATURE-----

--yhmmz776lzybvn6w--