Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp10992858rwl; Mon, 2 Jan 2023 11:45:35 -0800 (PST) X-Google-Smtp-Source: AMrXdXsxsz440Azm8v3Q+qUp5oNxW4hbdPV6H7nDoVxXAhFw5I3hC8vGsRVgqtaZjLX9ySx8sgie X-Received: by 2002:a17:906:36ce:b0:838:1b80:9a7a with SMTP id b14-20020a17090636ce00b008381b809a7amr34104435ejc.12.1672688734917; Mon, 02 Jan 2023 11:45:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672688734; cv=none; d=google.com; s=arc-20160816; b=KHDhlKfriFtrH2uW4QLZPmQjsga4SRqswwZkx8b4QKl736Poz4U4mhZFQ59LqYnEaG maKTsZax+2XoAeRwvXt34b48ff9Lq40cALnzQh8LWRrrYHoAejggHhmZjAe2cMG0wF8C ONfBK9cSFrqfl8aV4KJ0vjgE7Ty46rieqdEtHEY1AYgZBOICq+nQSKoMUL6M4IunR8Kj Mqy2RWOaNNHDYPDB4sb03MD/V6BfxTtn3qbPHGgy9vr3M8D2nDEjQAoQUvFsxcPHVv1I qdI8v+pcrlTFDWBJMeYsdK0krjjCbnotM0tIzhNuAMak+qS8JT16VgL8JR4cU5KgyhHc B5Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=die8rj2zsA0MWNvmIToudq84zr52SSRtsS4zKPJloKE=; b=ece5SNSgXM5P8JFh/le6ZLcFMhilFOYIhkBwMPzmHpcI2onBPpfb3VNp3fpdKWISym FyNgHkpQQde7Jxi6r1AnL+Cb33WNzu5QsPnYyhx0PQTFQ1qoEQT4V3y6B4f7yB7BjmpQ +fm+Iif8hNqkve4N9QIEk792JZfyeFW4uA05Bwxz2z0NKzHkxMY4kJL8d6TG9Zr5rdth fIkZ4EDuoVRqlgwzyY4QSi3YScOjL9BhyszZv80qFIXg1YiIxyvY6V53EEWg6GpcU/Rk cY5xtFlzPZxR2iZz1m+oRXHPoo3nfO7CRyROpJ1Nww87+51QWgkQvLdZDk6sL7wCvTvC dxnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ravnborg.org header.s=rsa2 header.b=kthLbfRu; dkim=neutral (no key) header.i=@ravnborg.org header.s=ed2 header.b=gmF9pYLJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nd9-20020a170907628900b0084c8ac6e0b2si11821622ejc.109.2023.01.02.11.45.20; Mon, 02 Jan 2023 11:45:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ravnborg.org header.s=rsa2 header.b=kthLbfRu; dkim=neutral (no key) header.i=@ravnborg.org header.s=ed2 header.b=gmF9pYLJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232975AbjABSvs (ORCPT + 61 others); Mon, 2 Jan 2023 13:51:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230120AbjABSvr (ORCPT ); Mon, 2 Jan 2023 13:51:47 -0500 Received: from mailrelay3-1.pub.mailoutpod2-cph3.one.com (mailrelay3-1.pub.mailoutpod2-cph3.one.com [IPv6:2a02:2350:5:402::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23E47A180 for ; Mon, 2 Jan 2023 10:51:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa2; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=die8rj2zsA0MWNvmIToudq84zr52SSRtsS4zKPJloKE=; b=kthLbfRuWUZz/q0IAnLP3ZXidolhiNT9Utn19plNmHGI71c496kzHe8KfG5rT1RcRTR5SptsWNG19 BKVZJ/qUnnJdo7M8bcUiK5+2jwdq935MOYp4dPCZ4v+f2J5ozn+tTCJYnM8OTkLYpQnUVROs6avHaC +IffYOhiMUopCRkKXymqm5B+b679d8kY5Wk4G0NeBFA0yvTDy4lb6dcGgLrP4/yd+bxJrYxu/V4QeE 8VeVkzkWnXTd+8FuQcTOUyV78aKB7fYYc5Azhm6mWl89Ffb6UywtyKH2rbc4II6u1/fv2fRxQ3YG/T nhgZfT64CSEPqtr7WQkZOKXQHPHAUmw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed2; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=die8rj2zsA0MWNvmIToudq84zr52SSRtsS4zKPJloKE=; b=gmF9pYLJfLmCw0IwpEgyFq6kvaPnDuDGEBPXqcP9seqzZzyzqOkJymmh2/arTTFP7HATl3G+NXj2F blkbqQUAA== X-HalOne-ID: 7e11684a-8ace-11ed-b450-ede074c87fad Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay3 (Halon) with ESMTPSA id 7e11684a-8ace-11ed-b450-ede074c87fad; Mon, 02 Jan 2023 18:51:42 +0000 (UTC) Date: Mon, 2 Jan 2023 19:51:41 +0100 From: Sam Ravnborg To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding Subject: Re: [PATCH 13/14] drm/panel-sony-tulip-truly-nt35521: Drop custom DSI write macro Message-ID: References: <20221228014757.3170486-1-javierm@redhat.com> <20221228014757.3170486-14-javierm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221228014757.3170486-14-javierm@redhat.com> X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_NONE, URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Javier, On Wed, Dec 28, 2022 at 02:47:56AM +0100, Javier Martinez Canillas wrote: > There is a macro for this already in the header, use > that instead and delete the custom DSI write macro defined in the driver. > > Signed-off-by: Javier Martinez Canillas > --- > > .../panel/panel-sony-tulip-truly-nt35521.c | 348 +++++++++--------- > 1 file changed, 170 insertions(+), 178 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c b/drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c > index fa9be3c299c0..a0661576acff 100644 > --- a/drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c > +++ b/drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c > @@ -33,14 +33,6 @@ struct truly_nt35521 *to_truly_nt35521(struct drm_panel *panel) > return container_of(panel, struct truly_nt35521, panel); > } > > -#define dsi_generic_write_seq(dsi, seq...) do { \ > - static const u8 d[] = { seq }; \ > - int ret; \ > - ret = mipi_dsi_generic_write(dsi, d, ARRAY_SIZE(d)); \ > - if (ret < 0) \ > - return ret; \ > - } while (0) > - > static void truly_nt35521_reset(struct truly_nt35521 *ctx) > { > gpiod_set_value_cansleep(ctx->reset_gpio, 1); > @@ -59,200 +51,200 @@ static int truly_nt35521_on(struct truly_nt35521 *ctx) > > dsi->mode_flags |= MIPI_DSI_MODE_LPM; > > - dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x00); > - dsi_generic_write_seq(dsi, 0xff, 0xaa, 0x55, 0xa5, 0x80); > - dsi_generic_write_seq(dsi, 0x6f, 0x11, 0x00); > - dsi_generic_write_seq(dsi, 0xf7, 0x20, 0x00); > - dsi_generic_write_seq(dsi, 0x6f, 0x01); > - dsi_generic_write_seq(dsi, 0xb1, 0x21); > - dsi_generic_write_seq(dsi, 0xbd, 0x01, 0xa0, 0x10, 0x08, 0x01); > - dsi_generic_write_seq(dsi, 0xb8, 0x01, 0x02, 0x0c, 0x02); > - dsi_generic_write_seq(dsi, 0xbb, 0x11, 0x11); > - dsi_generic_write_seq(dsi, 0xbc, 0x00, 0x00); > - dsi_generic_write_seq(dsi, 0xb6, 0x02); > - dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x01); > - dsi_generic_write_seq(dsi, 0xb0, 0x09, 0x09); > - dsi_generic_write_seq(dsi, 0xb1, 0x09, 0x09); > - dsi_generic_write_seq(dsi, 0xbc, 0x8c, 0x00); > - dsi_generic_write_seq(dsi, 0xbd, 0x8c, 0x00); > - dsi_generic_write_seq(dsi, 0xca, 0x00); > - dsi_generic_write_seq(dsi, 0xc0, 0x04); > - dsi_generic_write_seq(dsi, 0xbe, 0xb5); > - dsi_generic_write_seq(dsi, 0xb3, 0x35, 0x35); > - dsi_generic_write_seq(dsi, 0xb4, 0x25, 0x25); > - dsi_generic_write_seq(dsi, 0xb9, 0x43, 0x43); > - dsi_generic_write_seq(dsi, 0xba, 0x24, 0x24); > - dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x02); > - dsi_generic_write_seq(dsi, 0xee, 0x03); > - dsi_generic_write_seq(dsi, 0xb0, > + mipi_dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xff, 0xaa, 0x55, 0xa5, 0x80); > + mipi_dsi_generic_write_seq(dsi, 0x6f, 0x11, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xf7, 0x20, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0x6f, 0x01); > + mipi_dsi_generic_write_seq(dsi, 0xb1, 0x21); > + mipi_dsi_generic_write_seq(dsi, 0xbd, 0x01, 0xa0, 0x10, 0x08, 0x01); > + mipi_dsi_generic_write_seq(dsi, 0xb8, 0x01, 0x02, 0x0c, 0x02); > + mipi_dsi_generic_write_seq(dsi, 0xbb, 0x11, 0x11); > + mipi_dsi_generic_write_seq(dsi, 0xbc, 0x00, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xb6, 0x02); > + mipi_dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x01); > + mipi_dsi_generic_write_seq(dsi, 0xb0, 0x09, 0x09); > + mipi_dsi_generic_write_seq(dsi, 0xb1, 0x09, 0x09); > + mipi_dsi_generic_write_seq(dsi, 0xbc, 0x8c, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xbd, 0x8c, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xca, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xc0, 0x04); > + mipi_dsi_generic_write_seq(dsi, 0xbe, 0xb5); > + mipi_dsi_generic_write_seq(dsi, 0xb3, 0x35, 0x35); > + mipi_dsi_generic_write_seq(dsi, 0xb4, 0x25, 0x25); > + mipi_dsi_generic_write_seq(dsi, 0xb9, 0x43, 0x43); > + mipi_dsi_generic_write_seq(dsi, 0xba, 0x24, 0x24); > + mipi_dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x02); > + mipi_dsi_generic_write_seq(dsi, 0xee, 0x03); > + mipi_dsi_generic_write_seq(dsi, 0xb0, > 0x00, 0xb2, 0x00, 0xb3, 0x00, 0xb6, 0x00, 0xc3, > 0x00, 0xce, 0x00, 0xe1, 0x00, 0xf3, 0x01, 0x11); Fix indent - here and elsewhere. With this fixed: Reviewed-by: Sam Ravnborg > - dsi_generic_write_seq(dsi, 0xb1, > + mipi_dsi_generic_write_seq(dsi, 0xb1, > 0x01, 0x2e, 0x01, 0x5c, 0x01, 0x82, 0x01, 0xc3, > 0x01, 0xfe, 0x02, 0x00, 0x02, 0x37, 0x02, 0x77); > - dsi_generic_write_seq(dsi, 0xb2, > + mipi_dsi_generic_write_seq(dsi, 0xb2, > 0x02, 0xa1, 0x02, 0xd7, 0x02, 0xfe, 0x03, 0x2c, > 0x03, 0x4b, 0x03, 0x63, 0x03, 0x8f, 0x03, 0x90); > - dsi_generic_write_seq(dsi, 0xb3, 0x03, 0x96, 0x03, 0x98); > - dsi_generic_write_seq(dsi, 0xb4, > + mipi_dsi_generic_write_seq(dsi, 0xb3, 0x03, 0x96, 0x03, 0x98); > + mipi_dsi_generic_write_seq(dsi, 0xb4, > 0x00, 0x81, 0x00, 0x8b, 0x00, 0x9c, 0x00, 0xa9, > 0x00, 0xb5, 0x00, 0xcb, 0x00, 0xdf, 0x01, 0x02); > - dsi_generic_write_seq(dsi, 0xb5, > + mipi_dsi_generic_write_seq(dsi, 0xb5, > 0x01, 0x1f, 0x01, 0x51, 0x01, 0x7a, 0x01, 0xbf, > 0x01, 0xfa, 0x01, 0xfc, 0x02, 0x34, 0x02, 0x76); > - dsi_generic_write_seq(dsi, 0xb6, > + mipi_dsi_generic_write_seq(dsi, 0xb6, > 0x02, 0x9f, 0x02, 0xd7, 0x02, 0xfc, 0x03, 0x2c, > 0x03, 0x4a, 0x03, 0x63, 0x03, 0x8f, 0x03, 0xa2); > - dsi_generic_write_seq(dsi, 0xb7, 0x03, 0xb8, 0x03, 0xba); > - dsi_generic_write_seq(dsi, 0xb8, > + mipi_dsi_generic_write_seq(dsi, 0xb7, 0x03, 0xb8, 0x03, 0xba); > + mipi_dsi_generic_write_seq(dsi, 0xb8, > 0x00, 0x01, 0x00, 0x02, 0x00, 0x0e, 0x00, 0x2a, > 0x00, 0x41, 0x00, 0x67, 0x00, 0x87, 0x00, 0xb9); > - dsi_generic_write_seq(dsi, 0xb9, > + mipi_dsi_generic_write_seq(dsi, 0xb9, > 0x00, 0xe2, 0x01, 0x22, 0x01, 0x54, 0x01, 0xa3, > 0x01, 0xe6, 0x01, 0xe7, 0x02, 0x24, 0x02, 0x67); > - dsi_generic_write_seq(dsi, 0xba, > + mipi_dsi_generic_write_seq(dsi, 0xba, > 0x02, 0x93, 0x02, 0xcd, 0x02, 0xf6, 0x03, 0x31, > 0x03, 0x6c, 0x03, 0xe9, 0x03, 0xef, 0x03, 0xf4); > - dsi_generic_write_seq(dsi, 0xbb, 0x03, 0xf6, 0x03, 0xf7); > - dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x03); > - dsi_generic_write_seq(dsi, 0xb0, 0x22, 0x00); > - dsi_generic_write_seq(dsi, 0xb1, 0x22, 0x00); > - dsi_generic_write_seq(dsi, 0xb2, 0x05, 0x00, 0x60, 0x00, 0x00); > - dsi_generic_write_seq(dsi, 0xb3, 0x05, 0x00, 0x60, 0x00, 0x00); > - dsi_generic_write_seq(dsi, 0xb4, 0x05, 0x00, 0x60, 0x00, 0x00); > - dsi_generic_write_seq(dsi, 0xb5, 0x05, 0x00, 0x60, 0x00, 0x00); > - dsi_generic_write_seq(dsi, 0xba, 0x53, 0x00, 0x60, 0x00, 0x00); > - dsi_generic_write_seq(dsi, 0xbb, 0x53, 0x00, 0x60, 0x00, 0x00); > - dsi_generic_write_seq(dsi, 0xbc, 0x53, 0x00, 0x60, 0x00, 0x00); > - dsi_generic_write_seq(dsi, 0xbd, 0x53, 0x00, 0x60, 0x00, 0x00); > - dsi_generic_write_seq(dsi, 0xc0, 0x00, 0x34, 0x00, 0x00); > - dsi_generic_write_seq(dsi, 0xc1, 0x00, 0x00, 0x34, 0x00); > - dsi_generic_write_seq(dsi, 0xc2, 0x00, 0x00, 0x34, 0x00); > - dsi_generic_write_seq(dsi, 0xc3, 0x00, 0x00, 0x34, 0x00); > - dsi_generic_write_seq(dsi, 0xc4, 0x60); > - dsi_generic_write_seq(dsi, 0xc5, 0xc0); > - dsi_generic_write_seq(dsi, 0xc6, 0x00); > - dsi_generic_write_seq(dsi, 0xc7, 0x00); > - dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x05); > - dsi_generic_write_seq(dsi, 0xb0, 0x17, 0x06); > - dsi_generic_write_seq(dsi, 0xb1, 0x17, 0x06); > - dsi_generic_write_seq(dsi, 0xb2, 0x17, 0x06); > - dsi_generic_write_seq(dsi, 0xb3, 0x17, 0x06); > - dsi_generic_write_seq(dsi, 0xb4, 0x17, 0x06); > - dsi_generic_write_seq(dsi, 0xb5, 0x17, 0x06); > - dsi_generic_write_seq(dsi, 0xb6, 0x17, 0x06); > - dsi_generic_write_seq(dsi, 0xb7, 0x17, 0x06); > - dsi_generic_write_seq(dsi, 0xb8, 0x00); > - dsi_generic_write_seq(dsi, 0xb9, 0x00, 0x03); > - dsi_generic_write_seq(dsi, 0xba, 0x00, 0x00); > - dsi_generic_write_seq(dsi, 0xbb, 0x02, 0x03); > - dsi_generic_write_seq(dsi, 0xbc, 0x02, 0x03); > - dsi_generic_write_seq(dsi, 0xbd, 0x03, 0x03, 0x00, 0x03, 0x03); > - dsi_generic_write_seq(dsi, 0xc0, 0x0b); > - dsi_generic_write_seq(dsi, 0xc1, 0x09); > - dsi_generic_write_seq(dsi, 0xc2, 0xa6); > - dsi_generic_write_seq(dsi, 0xc3, 0x05); > - dsi_generic_write_seq(dsi, 0xc4, 0x00); > - dsi_generic_write_seq(dsi, 0xc5, 0x02); > - dsi_generic_write_seq(dsi, 0xc6, 0x22); > - dsi_generic_write_seq(dsi, 0xc7, 0x03); > - dsi_generic_write_seq(dsi, 0xc8, 0x07, 0x20); > - dsi_generic_write_seq(dsi, 0xc9, 0x03, 0x20); > - dsi_generic_write_seq(dsi, 0xca, 0x01, 0x60); > - dsi_generic_write_seq(dsi, 0xcb, 0x01, 0x60); > - dsi_generic_write_seq(dsi, 0xcc, 0x00, 0x00, 0x02); > - dsi_generic_write_seq(dsi, 0xcd, 0x00, 0x00, 0x02); > - dsi_generic_write_seq(dsi, 0xce, 0x00, 0x00, 0x02); > - dsi_generic_write_seq(dsi, 0xcf, 0x00, 0x00, 0x02); > - dsi_generic_write_seq(dsi, 0xd1, 0x00, 0x05, 0x01, 0x07, 0x10); > - dsi_generic_write_seq(dsi, 0xd2, 0x10, 0x05, 0x05, 0x03, 0x10); > - dsi_generic_write_seq(dsi, 0xd3, 0x20, 0x00, 0x43, 0x07, 0x10); > - dsi_generic_write_seq(dsi, 0xd4, 0x30, 0x00, 0x43, 0x07, 0x10); > - dsi_generic_write_seq(dsi, 0xd0, > + mipi_dsi_generic_write_seq(dsi, 0xbb, 0x03, 0xf6, 0x03, 0xf7); > + mipi_dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x03); > + mipi_dsi_generic_write_seq(dsi, 0xb0, 0x22, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xb1, 0x22, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xb2, 0x05, 0x00, 0x60, 0x00, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xb3, 0x05, 0x00, 0x60, 0x00, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xb4, 0x05, 0x00, 0x60, 0x00, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xb5, 0x05, 0x00, 0x60, 0x00, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xba, 0x53, 0x00, 0x60, 0x00, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xbb, 0x53, 0x00, 0x60, 0x00, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xbc, 0x53, 0x00, 0x60, 0x00, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xbd, 0x53, 0x00, 0x60, 0x00, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xc0, 0x00, 0x34, 0x00, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xc1, 0x00, 0x00, 0x34, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xc2, 0x00, 0x00, 0x34, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xc3, 0x00, 0x00, 0x34, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xc4, 0x60); > + mipi_dsi_generic_write_seq(dsi, 0xc5, 0xc0); > + mipi_dsi_generic_write_seq(dsi, 0xc6, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xc7, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x05); > + mipi_dsi_generic_write_seq(dsi, 0xb0, 0x17, 0x06); > + mipi_dsi_generic_write_seq(dsi, 0xb1, 0x17, 0x06); > + mipi_dsi_generic_write_seq(dsi, 0xb2, 0x17, 0x06); > + mipi_dsi_generic_write_seq(dsi, 0xb3, 0x17, 0x06); > + mipi_dsi_generic_write_seq(dsi, 0xb4, 0x17, 0x06); > + mipi_dsi_generic_write_seq(dsi, 0xb5, 0x17, 0x06); > + mipi_dsi_generic_write_seq(dsi, 0xb6, 0x17, 0x06); > + mipi_dsi_generic_write_seq(dsi, 0xb7, 0x17, 0x06); > + mipi_dsi_generic_write_seq(dsi, 0xb8, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xb9, 0x00, 0x03); > + mipi_dsi_generic_write_seq(dsi, 0xba, 0x00, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xbb, 0x02, 0x03); > + mipi_dsi_generic_write_seq(dsi, 0xbc, 0x02, 0x03); > + mipi_dsi_generic_write_seq(dsi, 0xbd, 0x03, 0x03, 0x00, 0x03, 0x03); > + mipi_dsi_generic_write_seq(dsi, 0xc0, 0x0b); > + mipi_dsi_generic_write_seq(dsi, 0xc1, 0x09); > + mipi_dsi_generic_write_seq(dsi, 0xc2, 0xa6); > + mipi_dsi_generic_write_seq(dsi, 0xc3, 0x05); > + mipi_dsi_generic_write_seq(dsi, 0xc4, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xc5, 0x02); > + mipi_dsi_generic_write_seq(dsi, 0xc6, 0x22); > + mipi_dsi_generic_write_seq(dsi, 0xc7, 0x03); > + mipi_dsi_generic_write_seq(dsi, 0xc8, 0x07, 0x20); > + mipi_dsi_generic_write_seq(dsi, 0xc9, 0x03, 0x20); > + mipi_dsi_generic_write_seq(dsi, 0xca, 0x01, 0x60); > + mipi_dsi_generic_write_seq(dsi, 0xcb, 0x01, 0x60); > + mipi_dsi_generic_write_seq(dsi, 0xcc, 0x00, 0x00, 0x02); > + mipi_dsi_generic_write_seq(dsi, 0xcd, 0x00, 0x00, 0x02); > + mipi_dsi_generic_write_seq(dsi, 0xce, 0x00, 0x00, 0x02); > + mipi_dsi_generic_write_seq(dsi, 0xcf, 0x00, 0x00, 0x02); > + mipi_dsi_generic_write_seq(dsi, 0xd1, 0x00, 0x05, 0x01, 0x07, 0x10); > + mipi_dsi_generic_write_seq(dsi, 0xd2, 0x10, 0x05, 0x05, 0x03, 0x10); > + mipi_dsi_generic_write_seq(dsi, 0xd3, 0x20, 0x00, 0x43, 0x07, 0x10); > + mipi_dsi_generic_write_seq(dsi, 0xd4, 0x30, 0x00, 0x43, 0x07, 0x10); > + mipi_dsi_generic_write_seq(dsi, 0xd0, > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00); > - dsi_generic_write_seq(dsi, 0xd5, > + mipi_dsi_generic_write_seq(dsi, 0xd5, > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > 0x00, 0x00, 0x00); > - dsi_generic_write_seq(dsi, 0xd6, > + mipi_dsi_generic_write_seq(dsi, 0xd6, > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > 0x00, 0x00, 0x00); > - dsi_generic_write_seq(dsi, 0xd7, > + mipi_dsi_generic_write_seq(dsi, 0xd7, > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > 0x00, 0x00, 0x00); > - dsi_generic_write_seq(dsi, 0xd8, 0x00, 0x00, 0x00, 0x00, 0x00); > - dsi_generic_write_seq(dsi, 0xe5, 0x06); > - dsi_generic_write_seq(dsi, 0xe6, 0x06); > - dsi_generic_write_seq(dsi, 0xe7, 0x00); > - dsi_generic_write_seq(dsi, 0xe8, 0x06); > - dsi_generic_write_seq(dsi, 0xe9, 0x06); > - dsi_generic_write_seq(dsi, 0xea, 0x06); > - dsi_generic_write_seq(dsi, 0xeb, 0x00); > - dsi_generic_write_seq(dsi, 0xec, 0x00); > - dsi_generic_write_seq(dsi, 0xed, 0x30); > - dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x06); > - dsi_generic_write_seq(dsi, 0xb0, 0x31, 0x31); > - dsi_generic_write_seq(dsi, 0xb1, 0x31, 0x31); > - dsi_generic_write_seq(dsi, 0xb2, 0x2d, 0x2e); > - dsi_generic_write_seq(dsi, 0xb3, 0x31, 0x34); > - dsi_generic_write_seq(dsi, 0xb4, 0x29, 0x2a); > - dsi_generic_write_seq(dsi, 0xb5, 0x12, 0x10); > - dsi_generic_write_seq(dsi, 0xb6, 0x18, 0x16); > - dsi_generic_write_seq(dsi, 0xb7, 0x00, 0x02); > - dsi_generic_write_seq(dsi, 0xb8, 0x08, 0x31); > - dsi_generic_write_seq(dsi, 0xb9, 0x31, 0x31); > - dsi_generic_write_seq(dsi, 0xba, 0x31, 0x31); > - dsi_generic_write_seq(dsi, 0xbb, 0x31, 0x08); > - dsi_generic_write_seq(dsi, 0xbc, 0x03, 0x01); > - dsi_generic_write_seq(dsi, 0xbd, 0x17, 0x19); > - dsi_generic_write_seq(dsi, 0xbe, 0x11, 0x13); > - dsi_generic_write_seq(dsi, 0xbf, 0x2a, 0x29); > - dsi_generic_write_seq(dsi, 0xc0, 0x34, 0x31); > - dsi_generic_write_seq(dsi, 0xc1, 0x2e, 0x2d); > - dsi_generic_write_seq(dsi, 0xc2, 0x31, 0x31); > - dsi_generic_write_seq(dsi, 0xc3, 0x31, 0x31); > - dsi_generic_write_seq(dsi, 0xc4, 0x31, 0x31); > - dsi_generic_write_seq(dsi, 0xc5, 0x31, 0x31); > - dsi_generic_write_seq(dsi, 0xc6, 0x2e, 0x2d); > - dsi_generic_write_seq(dsi, 0xc7, 0x31, 0x34); > - dsi_generic_write_seq(dsi, 0xc8, 0x29, 0x2a); > - dsi_generic_write_seq(dsi, 0xc9, 0x17, 0x19); > - dsi_generic_write_seq(dsi, 0xca, 0x11, 0x13); > - dsi_generic_write_seq(dsi, 0xcb, 0x03, 0x01); > - dsi_generic_write_seq(dsi, 0xcc, 0x08, 0x31); > - dsi_generic_write_seq(dsi, 0xcd, 0x31, 0x31); > - dsi_generic_write_seq(dsi, 0xce, 0x31, 0x31); > - dsi_generic_write_seq(dsi, 0xcf, 0x31, 0x08); > - dsi_generic_write_seq(dsi, 0xd0, 0x00, 0x02); > - dsi_generic_write_seq(dsi, 0xd1, 0x12, 0x10); > - dsi_generic_write_seq(dsi, 0xd2, 0x18, 0x16); > - dsi_generic_write_seq(dsi, 0xd3, 0x2a, 0x29); > - dsi_generic_write_seq(dsi, 0xd4, 0x34, 0x31); > - dsi_generic_write_seq(dsi, 0xd5, 0x2d, 0x2e); > - dsi_generic_write_seq(dsi, 0xd6, 0x31, 0x31); > - dsi_generic_write_seq(dsi, 0xd7, 0x31, 0x31); > - dsi_generic_write_seq(dsi, 0xe5, 0x31, 0x31); > - dsi_generic_write_seq(dsi, 0xe6, 0x31, 0x31); > - dsi_generic_write_seq(dsi, 0xd8, 0x00, 0x00, 0x00, 0x00, 0x00); > - dsi_generic_write_seq(dsi, 0xd9, 0x00, 0x00, 0x00, 0x00, 0x00); > - dsi_generic_write_seq(dsi, 0xe7, 0x00); > - dsi_generic_write_seq(dsi, 0x6f, 0x02); > - dsi_generic_write_seq(dsi, 0xf7, 0x47); > - dsi_generic_write_seq(dsi, 0x6f, 0x0a); > - dsi_generic_write_seq(dsi, 0xf7, 0x02); > - dsi_generic_write_seq(dsi, 0x6f, 0x17); > - dsi_generic_write_seq(dsi, 0xf4, 0x60); > - dsi_generic_write_seq(dsi, 0x6f, 0x01); > - dsi_generic_write_seq(dsi, 0xf9, 0x46); > - dsi_generic_write_seq(dsi, 0x6f, 0x11); > - dsi_generic_write_seq(dsi, 0xf3, 0x01); > - dsi_generic_write_seq(dsi, 0x35, 0x00); > - dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x00); > - dsi_generic_write_seq(dsi, 0xd9, 0x02, 0x03, 0x00); > - dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x00, 0x00); > - dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x00); > - dsi_generic_write_seq(dsi, 0xb1, 0x6c, 0x21); > - dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x00, 0x00); > - dsi_generic_write_seq(dsi, 0x35, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xd8, 0x00, 0x00, 0x00, 0x00, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xe5, 0x06); > + mipi_dsi_generic_write_seq(dsi, 0xe6, 0x06); > + mipi_dsi_generic_write_seq(dsi, 0xe7, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xe8, 0x06); > + mipi_dsi_generic_write_seq(dsi, 0xe9, 0x06); > + mipi_dsi_generic_write_seq(dsi, 0xea, 0x06); > + mipi_dsi_generic_write_seq(dsi, 0xeb, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xec, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xed, 0x30); > + mipi_dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x06); > + mipi_dsi_generic_write_seq(dsi, 0xb0, 0x31, 0x31); > + mipi_dsi_generic_write_seq(dsi, 0xb1, 0x31, 0x31); > + mipi_dsi_generic_write_seq(dsi, 0xb2, 0x2d, 0x2e); > + mipi_dsi_generic_write_seq(dsi, 0xb3, 0x31, 0x34); > + mipi_dsi_generic_write_seq(dsi, 0xb4, 0x29, 0x2a); > + mipi_dsi_generic_write_seq(dsi, 0xb5, 0x12, 0x10); > + mipi_dsi_generic_write_seq(dsi, 0xb6, 0x18, 0x16); > + mipi_dsi_generic_write_seq(dsi, 0xb7, 0x00, 0x02); > + mipi_dsi_generic_write_seq(dsi, 0xb8, 0x08, 0x31); > + mipi_dsi_generic_write_seq(dsi, 0xb9, 0x31, 0x31); > + mipi_dsi_generic_write_seq(dsi, 0xba, 0x31, 0x31); > + mipi_dsi_generic_write_seq(dsi, 0xbb, 0x31, 0x08); > + mipi_dsi_generic_write_seq(dsi, 0xbc, 0x03, 0x01); > + mipi_dsi_generic_write_seq(dsi, 0xbd, 0x17, 0x19); > + mipi_dsi_generic_write_seq(dsi, 0xbe, 0x11, 0x13); > + mipi_dsi_generic_write_seq(dsi, 0xbf, 0x2a, 0x29); > + mipi_dsi_generic_write_seq(dsi, 0xc0, 0x34, 0x31); > + mipi_dsi_generic_write_seq(dsi, 0xc1, 0x2e, 0x2d); > + mipi_dsi_generic_write_seq(dsi, 0xc2, 0x31, 0x31); > + mipi_dsi_generic_write_seq(dsi, 0xc3, 0x31, 0x31); > + mipi_dsi_generic_write_seq(dsi, 0xc4, 0x31, 0x31); > + mipi_dsi_generic_write_seq(dsi, 0xc5, 0x31, 0x31); > + mipi_dsi_generic_write_seq(dsi, 0xc6, 0x2e, 0x2d); > + mipi_dsi_generic_write_seq(dsi, 0xc7, 0x31, 0x34); > + mipi_dsi_generic_write_seq(dsi, 0xc8, 0x29, 0x2a); > + mipi_dsi_generic_write_seq(dsi, 0xc9, 0x17, 0x19); > + mipi_dsi_generic_write_seq(dsi, 0xca, 0x11, 0x13); > + mipi_dsi_generic_write_seq(dsi, 0xcb, 0x03, 0x01); > + mipi_dsi_generic_write_seq(dsi, 0xcc, 0x08, 0x31); > + mipi_dsi_generic_write_seq(dsi, 0xcd, 0x31, 0x31); > + mipi_dsi_generic_write_seq(dsi, 0xce, 0x31, 0x31); > + mipi_dsi_generic_write_seq(dsi, 0xcf, 0x31, 0x08); > + mipi_dsi_generic_write_seq(dsi, 0xd0, 0x00, 0x02); > + mipi_dsi_generic_write_seq(dsi, 0xd1, 0x12, 0x10); > + mipi_dsi_generic_write_seq(dsi, 0xd2, 0x18, 0x16); > + mipi_dsi_generic_write_seq(dsi, 0xd3, 0x2a, 0x29); > + mipi_dsi_generic_write_seq(dsi, 0xd4, 0x34, 0x31); > + mipi_dsi_generic_write_seq(dsi, 0xd5, 0x2d, 0x2e); > + mipi_dsi_generic_write_seq(dsi, 0xd6, 0x31, 0x31); > + mipi_dsi_generic_write_seq(dsi, 0xd7, 0x31, 0x31); > + mipi_dsi_generic_write_seq(dsi, 0xe5, 0x31, 0x31); > + mipi_dsi_generic_write_seq(dsi, 0xe6, 0x31, 0x31); > + mipi_dsi_generic_write_seq(dsi, 0xd8, 0x00, 0x00, 0x00, 0x00, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xd9, 0x00, 0x00, 0x00, 0x00, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xe7, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0x6f, 0x02); > + mipi_dsi_generic_write_seq(dsi, 0xf7, 0x47); > + mipi_dsi_generic_write_seq(dsi, 0x6f, 0x0a); > + mipi_dsi_generic_write_seq(dsi, 0xf7, 0x02); > + mipi_dsi_generic_write_seq(dsi, 0x6f, 0x17); > + mipi_dsi_generic_write_seq(dsi, 0xf4, 0x60); > + mipi_dsi_generic_write_seq(dsi, 0x6f, 0x01); > + mipi_dsi_generic_write_seq(dsi, 0xf9, 0x46); > + mipi_dsi_generic_write_seq(dsi, 0x6f, 0x11); > + mipi_dsi_generic_write_seq(dsi, 0xf3, 0x01); > + mipi_dsi_generic_write_seq(dsi, 0x35, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xd9, 0x02, 0x03, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x00, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x08, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0xb1, 0x6c, 0x21); > + mipi_dsi_generic_write_seq(dsi, 0xf0, 0x55, 0xaa, 0x52, 0x00, 0x00); > + mipi_dsi_generic_write_seq(dsi, 0x35, 0x00); > > ret = mipi_dsi_dcs_exit_sleep_mode(dsi); > if (ret < 0) { > @@ -268,7 +260,7 @@ static int truly_nt35521_on(struct truly_nt35521 *ctx) > } > usleep_range(1000, 2000); > > - dsi_generic_write_seq(dsi, 0x53, 0x24); > + mipi_dsi_generic_write_seq(dsi, 0x53, 0x24); > > return 0; > } > -- > 2.38.1