Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e7b9e76e-8f34-75c8-2136-095bd42a0bf8@redhat.com>
Date:   Mon, 2 Jan 2023 20:13:16 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH 00/14] drm/panel: Make panel drivers use existing DSI
 write macros
Content-Language: en-US
To:     Sam Ravnborg <sam@ravnborg.org>
Cc:     linux-kernel@vger.kernel.org, Ondrej Jirman <megous@megous.com>,
        Purism Kernel Team <kernel@puri.sm>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        =?UTF-8?Q?Guido_G=c3=bcnther?= <agx@sigxcpu.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        dri-devel@lists.freedesktop.org
References: <20221228014757.3170486-1-javierm@redhat.com>
 <Y7Mp1diWRWgiHsw0@ravnborg.org>
From:   Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <Y7Mp1diWRWgiHsw0@ravnborg.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/2/23 20:00, Sam Ravnborg wrote:
> Hi Javier.
> 
> On Wed, Dec 28, 2022 at 02:47:43AM +0100, Javier Martinez Canillas wrote:
>> Hello,
>>
>> This series contains cleanups for DRM panel drivers that define their own
>> DSI write macros instead of using what's already in <drm/drm_mipi_dsi.h>.
>>
>> The changes are quite trivial but I've only tested this with allmodconfig
>> and `make M=drivers/gpu/drm/panel/` so please review and testing would be
>> highly appreciated.
> 
> Nice cleanup - I like it.

Thanks.

> In most of the patches there is some trivial indent that should be
> fixed, I think I noted it everywhere.
>

Yup, I just used sed -i to modify in-place but the new macro _seq suffix
caused the wrong indent everywhere. I'll fix them in v2.
 
> Sorry - but no testing.
>

No worries, I also just build tested the drivers since I lack the HW but
the changes are pretty trivial so I expect no functional changes.
 
> The last patch is buggy - see the comment.

Indeed. Thanks for pointing that out! I completely missed that the macro
was different than the others.

> I suggest to land patch 1 now (with the fix), this makes it easier for
> others to test on top of drm-misc-next.
>

Agreed. I'll just post that one as a v2 and then the rest as a separate
series after pushing that to drm-misc-next.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat