Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 2 Jan 2023 23:19:41 +0100
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Hans de Goede <hdegoede@redhat.com>
Cc:     Denis Arefev <arefev@swemel.ru>, Chen-Yu Tsai <wens@csie.org>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        lvc-project@linuxtesting.org, trufanov@swemel.ru, vfh@swemel.ru
Subject: Re: [PATCH] power: supply: Added check for negative values
Message-ID: <20230102221941.hw35od6uhu7fbfny@mercury.elektranox.org>
References: <20221206091723.28656-1-arefev@swemel.ru>
 <1184e45f-d88c-b8b1-952d-7d6bd1ae2129@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="6z3y7co7hg7rakoo"
Content-Disposition: inline
In-Reply-To: <1184e45f-d88c-b8b1-952d-7d6bd1ae2129@redhat.com>
Precedence: bulk


--6z3y7co7hg7rakoo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Dec 06, 2022 at 06:11:23PM +0100, Hans de Goede wrote:
> Hi,
>=20
> On 12/6/22 10:17, Denis Arefev wrote:
> > Variable 'pirq', which may receive negative value
> > in platform_get_irq().
> > Used as an index in a function regmap_irq_get_virq().
> >=20
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> >=20
> > Signed-off-by: Denis Arefev <arefev@swemel.ru>
>=20
> Thanks, patch looks good to me:
>=20
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>=20
> Regards,
>=20
> Hans

Thanks, queued to power-supply's fixes branch.

-- Sebastian

>=20
> > ---
> >  drivers/power/supply/axp288_fuel_gauge.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >=20
> > diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/s=
upply/axp288_fuel_gauge.c
> > index 148eb8105803..36c7039c99c2 100644
> > --- a/drivers/power/supply/axp288_fuel_gauge.c
> > +++ b/drivers/power/supply/axp288_fuel_gauge.c
> > @@ -640,6 +640,8 @@ static void fuel_gauge_init_irq(struct axp288_fg_in=
fo *info)
> > =20
> >  	for (i =3D 0; i < AXP288_FG_INTR_NUM; i++) {
> >  		pirq =3D platform_get_irq(info->pdev, i);
> > +		if (pirq < 0)
> > +			continue;
> >  		info->irq[i] =3D regmap_irq_get_virq(info->regmap_irqc, pirq);
> >  		if (info->irq[i] < 0) {
> >  			dev_warn(&info->pdev->dev,
>=20

--6z3y7co7hg7rakoo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmOzWH0ACgkQ2O7X88g7
+prkow//WeGRJ+8c+zBWyca2ncxQuK0f5OqpVwrMJN8p6yHN8roPoMMszV4T3PYG
/kkWcgJ3SAHs5qolXwGGsSJ+1ehh2I/4fKrhn8aKokbFGfq/IS9lIa6B5nd6xJsV
l1reydmzHvs0FK8SAYV/hx852Bw9ZA0epi0bxClzbzor5AUu2ALHRVoNAIGz/KX6
nHry0NIKurs2tOdYXdIpmJutuaKG2oTFyzNmYQ3SRDrFSXRCHkpYtyWIYSqPI/BF
u4Ov7G1YvSf3TfNkVEWkYn1d/pyhe68JgAUpGYLwCMA/qSnZBIBHur56HE/n+a6Q
v/pMNSoEVReBEgvh8SGsmEEFzC9MSOMLG3KYIwqb9AEWHfHUMztMwJuPJzC0dsAt
d7ltTqzVnEvJruhGAex2vOkM7EHMKmgidvjp44g0LyD87E3P8Th7l/3vmyxg0wLG
ey//FLIEUjb885TV26RLRJi2YHkqJy2574hjNNedK3LEU0oM9Sz1uuqukfZp9B6e
H0Ld442yT0DEix5lqmcg8Tvhw80iUlCjt9Kt5vguaY1r9lvr+rVb1sUJL8Oeg7yM
pGyDYnJjlwuNgUf8f940uVkg8A0Hbq6fX87q3Q9TRMdtcM+sij+1Cbi7cUceQEiM
U0dg7TcjPJyUsXNozZri6tHqMP4IziZ6cL5mP8mV//fInB/vmQg=
=rXS/
-----END PGP SIGNATURE-----

--6z3y7co7hg7rakoo--