Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a7f6e0ae-3fbc-ccf7-6185-a425ad25e04f@nvidia.com>
Date:   Mon, 2 Jan 2023 16:57:02 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 1/1] efi: rtc: Enable SET/GET WAKEUP services as optional
Content-Language: en-US
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Ard Biesheuvel <ardb@kernel.org>
Cc:     Alessandro Zummo <a.zummo@towertech.it>, linux-rtc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org
References: <20221227040925.1619833-1-sdonthineni@nvidia.com>
 <CAMj1kXG79-MxGJEwvnekqbVyeEMVHBfhNjwZkz91mMwv4-vT3Q@mail.gmail.com>
 <Y7NY+ba2USk7hEAx@mail.local>
From:   Shanker Donthineni <sdonthineni@nvidia.com>
In-Reply-To: <Y7NY+ba2USk7hEAx@mail.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUFJM1dORkxhM3dsb2Vvb2xEdGZwaDVVNmg5aTZPUmtITjBuSVI5R1pyaDlV?=
 =?utf-8?B?VE5hc3JLOFJiV1A3UmVrOFN0VVh6WkNnaEUvd3I3cUVpazFzcDM4dm9VM0Y5?=
 =?utf-8?B?VW1XTmVUcnhiM0NZL0ZOdXRWZUZtV3ZEYzZ2aXdrM0t1YkFkZlRpWjdGaXVl?=
 =?utf-8?B?TWhPNmVaRlFVQ1BRQ1F0L3RkV3puRVdXdURQMFlLRHIrK2U0MVM4UitlRnpI?=
 =?utf-8?B?VU54ZjBuK3dRRVh0UEo4bWlNcnoweHNWVFB5SkZqSG5HaHRwQ21jZitwVDBy?=
 =?utf-8?B?OHJFc2Q5cmZvVHBkVHljWmJRNWVidFM0OWtvK2cvdkRoaE9ta3JkM0dybitw?=
 =?utf-8?B?anlQNzlHdlRzSjBReTdZK0xvbWFZSkRqSmxGOGhMeW9PZy9DNm5sMTNZaVUv?=
 =?utf-8?B?dHdxWG81eFg3MU9lZ0hPU0hOR0NPd05CS2xnOWlndm5Id1hsZ3pHeGdLUU1h?=
 =?utf-8?B?eVMxbEtSYXA1MHUzQVd1bk5HMkpQaXFuWDlYQ0w1VjBQVlQrWit2anFhSUNj?=
 =?utf-8?B?R0xIYStEbi9BZ0dqQThnU1k2V3JEMWMvd3hVMk1nK2xsMFRPS1p4U1E2cDBs?=
 =?utf-8?B?MVQ0ZnpRUms2NnQ2T3hsVmZkQmZIQkdRdGFRSDNXRVpOS1NIMnp3d1hkNE00?=
 =?utf-8?B?K05nUnEzdTZhNEErejV0TklHTDRJRVZpbWtXaXI5d2djUWl2cDRjelF4L0NY?=
 =?utf-8?B?TGtORVpsa2hyaVBCaHhEbzd6eUg4di9VQ0VxWWIveC92cHdRSmE3b1hmUUJz?=
 =?utf-8?B?MXBKaHh2YWxSZ1N1dHFOL2hWOUk2Zko0aGpvSy9NelFmZDAvd2Vrd1FuSHcw?=
 =?utf-8?B?NU1xOXQ4RFdSaXRLaVZJQVRQdlkrOTRaVXZvYmM1TDJvdDJ6eEFURityWWNN?=
 =?utf-8?B?RGhISnZqU1ZZbVdoVExZa0d5dVlpOXZNdVM5WjViZnNPUkhHQzNEa21iS2F2?=
 =?utf-8?B?TGZOZXIyV0VGQ3lseTU2Y0FNZEpTSDEycjRpNUJqRUIyNHo2clpGN09CbG9y?=
 =?utf-8?B?elFIR0VGRUdLaHR0bmRvaVh5RmRhc1UycE5NbWhSSlRiM0xBdFdZZkFhbDIr?=
 =?utf-8?B?TkI5T25SVmFDMXFWU2VkNUN1bHNsa3MvMGFXVDE2cFRJYzc2UTlhbUovWHBV?=
 =?utf-8?B?SlROSTY0YzJxdkZ5d2dlSlV6TVo3eVVoRlVmRElhU3dydEJNa3NUN0s2c3Az?=
 =?utf-8?B?YVRxUkxoaHBEQk9EbW1uOW1rblBGU05SejBPa1NrZlBoeUZDUHQwRVl6MkxR?=
 =?utf-8?B?dFBNakk4THdERWZPNWd4KzNrUkR0UGpxYngrTWpTMTNxTXlERnlPbWVCMi9C?=
 =?utf-8?B?ZnZGM2pHbjVPcEZKR2V0Qm1SWGVUWXA1YVp5SFhRYmdtK3NIcC9CN2ZibFBo?=
 =?utf-8?B?dWQwSW05R081dUJldVVIOFdZd0NNNnpqa2VrRmFEeVViVXhQYlpOL2pyOHdX?=
 =?utf-8?B?WTJ1S1A1bkJrcXAybVlxRmFsK2hzQ2VyTk95dk1BeEdoaEJocWhWY01FTDlq?=
 =?utf-8?B?czZZR0dCTllSellJekRkT0pKeGFEZFRzMVRrRHRETnJjZE5GV0Zoa3NoY1Zu?=
 =?utf-8?B?dG1SdEIrMkM0UzNabVRDalE3b3hwQkRwZ1J3cDF0R3ptUnU5M0trVDQ4V2lw?=
 =?utf-8?B?cmQ0NVZDR1haZTlJaDVIenZWMTVFTE9DaTl0QjdsKzhuUXVIZTdKcEdHRitQ?=
 =?utf-8?B?NXFNR0NwbExRRHpIN2tJK3ltQWt1T2VzREtEYlgzMEY2dEUxOUNaMm5SanRF?=
 =?utf-8?B?ZnRhUGlVL210eGZOSXhHamYvVFRzS3gwbHRhL3FKR0FHNzBhUHNPc1dBcFdK?=
 =?utf-8?B?L08veVVNWG9GalY3ZjVwVS9QMllKNm16UXVNN3lZbXVia2ZLY2l4azlMVXRU?=
 =?utf-8?B?ZmpNTFZtdStmK0s4ZlpBU282d1l5WjZSRjVlaGs1dGZlblkwV0RLcjNHT21K?=
 =?utf-8?B?UWVQcUZNc1l0OXgyRFdhbmtRN3N0blhCMWF4dEdoL3o5MjFhbXRTODBnZ2pS?=
 =?utf-8?B?cWdkbVlvNjg4SFMxNGxuNnRpbENkN2h4Qnh0bXduOGJXMGZ2MnR3Rlc1Qm9G?=
 =?utf-8?B?Zkg3d1BpclZ5a3VVcnNsK2VrUnB1UlJNVjhUN2p3ZEI1ZnRQR0QwWGxPNnl1?=
 =?utf-8?B?dklsRnRteW9HKzhqM3M1dUp6WUZCUjVybG1PUkphdUEyMXFKM2RGYXVJdFJC?=
 =?utf-8?B?U0E9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e092196a-a73a-407d-a436-08daed14b016
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB5762.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2023 22:57:13.7623
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MPSf7U70tSy+bPTJe2X0KYe7QvicS+WLtL8VzTTm+zRVcdOAu7PQXudZZTdrXHd5RAuU5EIA77nDpTTY8jeB8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8573
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Alexandre Belloni,

On 1/2/23 16:21, Alexandre Belloni wrote:
> On 02/01/2023 11:47:11+0100, Ard Biesheuvel wrote:
>> On Tue, 27 Dec 2022 at 05:09, Shanker Donthineni<sdonthineni@nvidia.com>  wrote:
>>> The current implementation of rtc-efi is expecting all the 4
>>> time services GET{SET}_TIME{WAKEUP} must be supported by UEFI
>>> firmware. As per the EFI_RT_PROPERTIES_TABLE, the platform
>>> specific implementations can choose to enable selective time
>>> services based on the RTC device capabilities.
>>>
>>> This patch does the following changes to provide GET/SET RTC
>>> services on platforms that do not support the WAKEUP feature.
>>>
>>> 1) Relax time services cap check when creating a platform device.
>>> 2) Clear RTC_FEATURE_ALARM bit in the absence of WAKEUP services.
>>> 3) Conditional alarm entries in '/proc/driver/rtc'.
>>>
>>> Signed-off-by: Shanker Donthineni<sdonthineni@nvidia.com>
>> Queued as a fix in efi/urgent, thanks.
> This rather seems like an rtc heavy patch and the subject line is
> misleading. This should be rtc: efi:
> Also, I'm pretty sure this doesn't qualify as an urgent fix.
> 

Thanks, I'll post v2 patch with your suggested subject.