Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CAHk-=wim8DMRzjyYTJ3UbdqZ26keQyZSU02NZb-JY1=9OpcO1w@mail.gmail.com>
 <20230102225656.GA3532398@roeck-us.net> <CAHk-=wjZPPscjDhsHQw_ttHOaQS69rADLm0KuRhbNavBiO62OQ@mail.gmail.com>
 <20230103014535.GA313835@roeck-us.net>
In-Reply-To: <20230103014535.GA313835@roeck-us.net>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Mon, 2 Jan 2023 18:13:09 -0800
Message-ID: <CAHk-=whmeBkyu3iS_s-yk0=t3GEoW3sQb-wJFHKykOjG=iQVFw@mail.gmail.com>
Subject: Re: Linux 6.2-rc2
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     "Jason A. Donenfeld" <Jason@zx2c4.com>,
        Yoshinori Sato <ysato@users.sourceforge.jp>,
        Rich Felker <dalias@libc.org>, Arnd Bergmann <arnd@arndb.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Palmer Dabbelt <palmer@rivosinc.com>,
        Ard Biesheuvel <ardb@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jan 2, 2023 at 5:45 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> ... and reverting commit 99cb0d917ff indeed fixes the problem.

Hmm. My gut feel is that this just exposes some bug in binutils.

That said, maybe that commit should not have added its own /DISCARDS/
thing, and instead just added that "*(.note.GNU-stack)" to the general
/DISCARDS/ thing that is defined by the

  #define DISCARDS  ..

a little bit later, so that we only end up with one single DISCARD
list. Something like this (broken patch on purpose):

  --- a/include/asm-generic/vmlinux.lds.h
  +++ b/include/asm-generic/vmlinux.lds.h
  @@ -897,5 +897,4 @@
    */
   #define NOTES                                        \
  -     /DISCARD/ : { *(.note.GNU-stack) }              \
        .notes : AT(ADDR(.notes) - LOAD_OFFSET) {       \
                BOUNDED_SECTION_BY(.note.*, _notes)     \
  @@ -1016,4 +1015,5 @@
   #define DISCARDS                                     \
        /DISCARD/ : {                                   \
  +     *(.note.GNU-stack)                              \
        EXIT_DISCARDS                                   \
        EXIT_CALL                                       \

But maybe that DISCARDS macrop ends up being used too late?

It really shouldn't matter, but here we are, with a build problem with
some random old binutils on an odd platform..

             Linus