Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <02a2e641-6b6d-e1c5-2c43-8815306d92a0@amd.com>
Date:   Tue, 3 Jan 2023 09:07:14 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v3] x86/sev: Add SEV-SNP guest feature negotiation support
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>,
        David Rientjes <rientjes@google.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org,
        mingo@redhat.com, tglx@linutronix.de, dave.hansen@linux.intel.com,
        seanjc@google.com, pbonzini@redhat.com, thomas.lendacky@amd.com,
        michael.roth@amd.com, stable@kernel.org
References: <20230102083810.71178-1-nikunj@amd.com>
 <3169b54b-d990-7707-5ec4-cde7261318fe@google.com>
 <45487a87-764a-7ff3-292b-4a55fe29f7ba@amd.com> <Y7M4IzNYBtfEJe6Z@zn.tnic>
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <Y7M4IzNYBtfEJe6Z@zn.tnic>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dEFkdzFFbmtTOUdXNWpLU3BoWlNRYjA4Q09uL1pxbnkrUlRnQXJKUDFtcDVC?=
 =?utf-8?B?cm4wRzBPUmFNVlo4UWtWVWRjaWw4SDlKNVkzaXp6ZnJseEpSaDVHWTJPaFNV?=
 =?utf-8?B?L1RaRlMwUEQzckczZHZKTS95OTQzVENFcFJvUSt3R0VjZTgrQkU3S1AwSERF?=
 =?utf-8?B?SVlDR1FiZkV0L1JjNW42b2ZIWEtZUDM0bk9ocUE0L0tHZk5sL05TbjUvcnp6?=
 =?utf-8?B?blJGZnBuN0JtcGpkZWhyVC9VNStiWHB2N3dod0Rqak0zV3RQTU1ITGhHQWE0?=
 =?utf-8?B?VDhXMFJCRVpkYU05SGtVZi8xdWtHSXlLU2c4L01mTTJDUzNvY2U1dlB2UC80?=
 =?utf-8?B?dWN6S0lLTUN6eUMrWnJwWnp1VExJZnF4TmJoOThnMFNBWFNQYkVhZld5eUVl?=
 =?utf-8?B?d0NDck9BMUtjeE5QbzN2OW9vT1lpR21sNDlCRjc0eXR5WTR1QzJCSUZ5L00z?=
 =?utf-8?B?Wk0reFRSTmVQeU5QUXNQaFZjWjY5bDhIaER1cjZlZmxHNFd2S0RrYjZ3ak9i?=
 =?utf-8?B?OE91Z3VwN1VJQXRKYVdDaGVseE9LT2xBbHNmdHpzVnYybUJYRnlmRG02em9r?=
 =?utf-8?B?SGgvQlZ6WldVNll4SzA3MThodGRYZ3ZaSXVxR1ZtWGZRY0xLTkVJbUZMQzhJ?=
 =?utf-8?B?M3dwa2dVQUhQTjBtY05EZ1dyaC90b0E3aEJEVXdTcE40bjR2Uk9nTFRxWU56?=
 =?utf-8?B?RFRmME41SmxYaDZXQkxYMlgvaHlCckt1d1JNa1F5VTFxR0pSK1hzZUFwUTZt?=
 =?utf-8?B?dTJZUU9lRFpIR3BPTkg1ZHp6QmF6MlV5bENzSlNNZEtvU1NKdG5VOVl4cnBP?=
 =?utf-8?B?YUFLeVR2QmdhRStxUFc4TlhGekowMWRBNnZLc0V5OFhWOUJsYnBKY0cwT01Z?=
 =?utf-8?B?dWxCZTlFNWlFbitzVGxBK2NLOFU4ci8wUHlIQUJKMFlWU2RRcjRNMWJFY2NV?=
 =?utf-8?B?ZnFNZnhvOEw3b2xvdTJ2TWhyQWJWSnlXQ1QyQmJvbWtLTURFdzlNQnFYNDRw?=
 =?utf-8?B?STlxSFpwME5GdGRQZ2RWS1M1M0MwNVdYYVBDZ2hJbUFkMVNuMFFvakhsemdx?=
 =?utf-8?B?UVQwZGd4cFZoSVNybzdKcElkR3BNc0pnVmUxNHRTaWxrL0lxUWJyZDlBYXIr?=
 =?utf-8?B?TnluTFdVUHIveTdIREVOYjNHd294c09KMW5YclRQSU9zek9CNTVnWWlGUGtH?=
 =?utf-8?B?Q1VjenVITTFIZEpJb29YYnpINWF6cUExQW4wdVRQNHFJVmtFbDU0bk40b0k1?=
 =?utf-8?B?V1paQ2FBUjVxdjhDbVRBRHB3Ri8xSnU2aDB3YkdjbFljbk5scVg3L3FjY1Fn?=
 =?utf-8?B?TDJJaG5WODI5azZFWGRvNGNQK1F4M1BReUNVZHVwM3BYVFVsNnNmYzhPenhv?=
 =?utf-8?B?bDlsYzVCN0E5d2dpQmNSQVZXUXFuWlIwSjJnZng5ZzlFcEl3aERrMThEelNj?=
 =?utf-8?B?cUE1ZThoTWR2a05xL3FVN2VFQ1NZbGQwR0RTUUFlR25jdFl1Z3NzSnhRQXZ6?=
 =?utf-8?B?SkxKUk9mK1NXak16Rmp3RVB6MlliMjdqK3U3cFNyR3Bxd3lKc2dxaXFXeDNC?=
 =?utf-8?B?U0ZucHljQ2Q2UHgwQm5meHBsT1BybVVZUWd2SG03bEdBdHlLWStQMVBKbjdm?=
 =?utf-8?B?QVR2ZVVLRUZoRGZGY1NVbFBUOXVrYjVnMjNyNDNPR3Evc3Boc3VoVnZrT0Nk?=
 =?utf-8?B?ZVNVRi9GMU9UMnpVWlJ3N2ZwL0hVM0pFWU90SUVlY1h3M0lsTFFGeVRTZ1NN?=
 =?utf-8?B?U3RnY0pNcTBlZ0pBRFY1VFY4VjVwRTQ3YlRnSm53L2tXQmhaRmE2dHVWemxX?=
 =?utf-8?B?ZDAwblk0emZQWnVBQXY5SUhwbjh1RWM4SXRES245MDBhR3c5eVlEdmhwZ2Z3?=
 =?utf-8?B?Q2ZtbThQZ3FQcXNFdG96aFhHZHQvRWJhUzcya1NGbk81bmp5akkydDFpN0M1?=
 =?utf-8?B?ZVFHTTZMNkZ3TnBRd3ZsUnczS3hXWFNDUTEwVWFUeWNCVjE4UEdZWlE2TTds?=
 =?utf-8?B?RTVYQmxmbGlXUXpGaDRFRWtzM2l2TFhSVUZxcmE0a0pZSVU1UTZPQ21RYWsz?=
 =?utf-8?B?cGVoSWhLZWlxQ1AzV21tYlpmMVhJbTBlNHF3TFpBZjVYL3IrWlVjMWxBb1Qr?=
 =?utf-8?Q?rPktZweY1cg45XV9QZCsWWbEa?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 96e1332c-f381-49bf-30f4-08daed3bd6d2
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6309.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2023 03:37:29.2736
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vlEWbqYB9/bV0w07zqCejrMUCeaXA4gYivkqBMRNZABnRuSzA8fXZLMpE1YBFjmwmZRyk9kNo4Rb+yej7JHGrA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4080
X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/01/23 01:32, Borislav Petkov wrote:
> On Mon, Jan 02, 2023 at 08:50:23PM +0530, Nikunj A. Dadhania wrote:
>>>> +		/*
>>>> +		 * Terminate the boot if hypervisor has enabled any feature
>>>> +		 * lacking guest side implementation.
>>>> +		 */
>>>> +		if (sev_status & SNP_FEATURES_IMPL_REQ & ~SNP_FEATURES_PRESENT)
>>>> +			sev_es_terminate(SEV_TERM_SET_GEN, GHCB_SNP_FEAT_NOT_IMPLEMENTED);
>>>
>>> We can't help out by specifying which feature(s)?
>>
>> The purpose of SNP_FEATURES_PRESENT is just that, at present no features that need guest 
>> implementation is part of the kernel. For e.g. I will be posting patches with SecureTSC 
>> enabled, that will make the following change.
> 
> I think what David means is, can we have sev_es_terminate() say exactly which
> feature wasn't implemented instead of users having to dig out which one exactly
> wasn't by trying to find out what their SNP_FEATURES_IMPL_REQ and
> SNP_FEATURES_PRESENT masks are.
> 
> Looking at the GHCB protocol, where GHCB_SNP_FEAT_NOT_IMPLEMENTED reason code
> goes is GHCBData[23:16] which is not enough... And the VMSA has SEV_FEATURES but
> that's guest-only.

Currently, GHCBData[24:63] is unused. If we intend to use the bit range(40bits), GHCB spec 
will need to be updated. And probably would not be enough.
 
> I guess we need a way to communicate those masks in a more user-friendly way so
> that it is exactly clear because of which missing feature(s) has the guest
> terminated.

As the termination request is done using GHCB MSR protocol, exit codes cannot be used.

Regards,
Nikunj