Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 3 Jan 2023 07:35:32 +0000
From:   Lorenzo Stoakes <lstoakes@gmail.com>
To:     Jaewon Kim <jaewon31.kim@samsung.com>
Cc:     riel@redhat.com, redkoi@virtuozzo.com, akpm@linux-foundation.org,
        hannes@cmpxchg.org, mhocko@kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, jaewon31.kim@gmail.com
Subject: Re: [PATCH] page_alloc: avoid the negative free for meminfo available
Message-ID: <Y7PaxPV3Ln7AXVSc@lucifer>
References: <CGME20230103072834epcas1p3441ef50a6cc26ac48d184f1244b76a0e@epcas1p3.samsung.com>
 <20230103072807.19578-1-jaewon31.kim@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230103072807.19578-1-jaewon31.kim@samsung.com>
Precedence: bulk

On Tue, Jan 03, 2023 at 04:28:07PM +0900, Jaewon Kim wrote:
> The totalreserve_pages could be higher than the free because of
> watermark high or watermark boost. Handle this situation and fix it to 0
> free size.
>
> Signed-off-by: Jaewon Kim <jaewon31.kim@samsung.com>
> ---
>  mm/page_alloc.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 218b28ee49ed..e510ae83d5f3 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5948,6 +5948,8 @@ long si_mem_available(void)
>  	 * without causing swapping or OOM.
>  	 */
>  	available = global_zone_page_state(NR_FREE_PAGES) - totalreserve_pages;
> +	if (available < 0)
> +		available = 0;
>
>  	/*
>  	 * Not all the page cache can be freed, otherwise the system will
> --
> 2.17.1
>

We already reset to zero at the end of the function, wouldn't resetting to zero
here potentially skew the result?