Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 3 Jan 2023 08:58:29 +0100
From:   Johan Hovold <johan@kernel.org>
To:     Abel Vesa <abel.vesa@linaro.org>
Cc:     Steev Klimaszewski <steev@kali.org>,
        Douglas Anderson <dianders@chromium.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b
Message-ID: <Y7PgJZtXBD42EobX@hovoldconsulting.com>
References: <20221231142721.338643-1-abel.vesa@linaro.org>
 <CAKXuJqjiEpxnX_E=HGqEaX91YA7XUmUoaK0NQqXHJCUkcqUPoQ@mail.gmail.com>
 <Y7KUFMjnra22YGlv@hovoldconsulting.com>
 <Y7Ncg9DMbHBagcoz@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y7Ncg9DMbHBagcoz@linaro.org>
Precedence: bulk

On Tue, Jan 03, 2023 at 12:36:51AM +0200, Abel Vesa wrote:
> On 23-01-02 09:21:40, Johan Hovold wrote:
> > On Sun, Jan 01, 2023 at 10:58:42PM -0600, Steev Klimaszewski wrote:
> > > On Sat, Dec 31, 2022 at 8:27 AM Abel Vesa <abel.vesa@linaro.org> wrote:
> > > >
> > > > The actual name is R133NW4K-R0.
> > > >
> > > > Fixes: 0f9fa5f58c784 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry")
> > > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > > > ---
> > > >
> > > > Assuming the information from here is correct:
> > > > https://raw.githubusercontent.com/linuxhw/EDID/master/DigitalDisplay.md

> > > Thanks for this - when I was looking for the panel, I simply went with
> > > what I found on panel-look.
> > 
> > Did you check what string your panel reports? For example, using
> > something like:
> > 
> > 	# strings /sys/class/drm/card0-eDP-1/edid
> > 	...
> > 	B133UAN02.1
> 
> Mine shows: M133NW4J R3
> 
> But since both R0 and R3 have the same product ID, I decided to drop the
> revision part, otherwise we would need to add a second entry with the
> only difference between them being the revision part (Rx). This is what
> I did in patch #2.

Makes sense. Thanks for confirming.

Johan