Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: RE:(2) [PATCH] page_alloc: avoid the negative free for meminfo
 available
Reply-To: jaewon31.kim@samsung.com
Sender: =?UTF-8?B?6rmA7J6s7JuQ?= <jaewon31.kim@samsung.com>
From:   =?UTF-8?B?6rmA7J6s7JuQ?= <jaewon31.kim@samsung.com>
To:     Michal Hocko <mhocko@suse.com>
CC:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "hannes@cmpxchg.org" <hannes@cmpxchg.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jaewon31.kim@gmail.com" <jaewon31.kim@gmail.com>
In-Reply-To: <Y7PhVaqhIzs8e8mU@dhcp22.suse.cz>
Message-ID: <20230103082008epcms1p6f75b54cbfeba0a1ab9a8044dc650134b@epcms1p6>
Date:   Tue, 03 Jan 2023 17:20:08 +0900
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <Y7PhVaqhIzs8e8mU@dhcp22.suse.cz>
        <20230103072807.19578-1-jaewon31.kim@samsung.com>
        <CGME20230103072834epcas1p3441ef50a6cc26ac48d184f1244b76a0e@epcms1p6>
Precedence: bulk

>On Tue 03-01-23 16:28:07, Jaewon Kim wrote:
>> The totalreserve_pages could be higher than the free because of
>> watermark high or watermark boost. Handle this situation and fix it to 0
>> free size.
>
>What is the actual problem you are trying to address by this change?

Hello

As described on the original commit,
  34e431b0ae39 /proc/meminfo: provide estimated available memory
mm is tring to provide the avaiable memory to user space.

But if free is negative, the available memory shown to userspace
would be shown smaller thatn the actual available size. The userspace
may do unwanted memory shrinking actions like process kills.

I think the logic sholud account the positive size only.

BR

>
>> Signed-off-by: Jaewon Kim <jaewon31.kim=40samsung.com>
>> ---
>>  mm/page_alloc.c =7C 2 ++
>>  1 file changed, 2 insertions(+)
>>=20
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index 218b28ee49ed..e510ae83d5f3 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> =40=40 -5948,6 +5948,8 =40=40 long si_mem_available(void)
>>  	 * without causing swapping or OOM.
>>  	 */
>>  	available =3D global_zone_page_state(NR_FREE_PAGES) - totalreserve_pag=
es;
>> +	if (available < 0)
>> +		available =3D 0;
>> =20
>>  	/*
>>  	 * Not all the page cache can be freed, otherwise the system will
>> --=20
>> 2.17.1
>
>--=20
>Michal Hocko
>SUSE Labs


=C2=A0=0D=0A---------=20Original=20Message=20---------=0D=0ASender=20:=20Mi=
chal=20Hocko=C2=A0<mhocko=40suse.com>=0D=0ADate=20:=202023-01-03=2017:03=20=
(GMT+9)=0D=0ATitle=20:=20Re:=20=5BPATCH=5D=20page_alloc:=20avoid=20the=20ne=
gative=20free=20for=20meminfo=20available=0D=0A=C2=A0=0D=0AOn=20Tue=2003-01=
-23=2016:28:07,=20Jaewon=20Kim=20wrote:=0D=0A>=20The=20totalreserve_pages=
=20could=20be=20higher=20than=20the=20free=20because=20of=0D=0A>=20watermar=
k=20high=20or=20watermark=20boost.=20Handle=20this=20situation=20and=20fix=
=20it=20to=200=0D=0A>=20free=20size.=0D=0A=0D=0AWhat=20is=20the=20actual=20=
problem=20you=20are=20trying=20to=20address=20by=20this=20change?=0D=0A=0D=
=0A>=20Signed-off-by:=20Jaewon=20Kim=20<jaewon31.kim=40samsung.com>=0D=0A>=
=20---=0D=0A>=20=C2=A0mm/page_alloc.c=20=7C=202=20++=0D=0A>=20=C2=A01=20fil=
e=20changed,=202=20insertions(+)=0D=0A>=20=0D=0A>=20diff=20--git=20a/mm/pag=
e_alloc.c=20b/mm/page_alloc.c=0D=0A>=20index=20218b28ee49ed..e510ae83d5f3=
=20100644=0D=0A>=20---=20a/mm/page_alloc.c=0D=0A>=20+++=20b/mm/page_alloc.c=
=0D=0A>=20=40=40=20-5948,6=20+5948,8=20=40=40=20long=20si_mem_available(voi=
d)=0D=0A>=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20*=20without=20caus=
ing=20swapping=20or=20OOM.=0D=0A>=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=
=A0=20*/=0D=0A>=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0available=20=3D=
=20global_zone_page_state(NR_FREE_PAGES)=20-=20totalreserve_pages;=0D=0A>=
=20+=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0if=20(available=20<=200)=0D=0A>=20+=
=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0ava=
ilable=20=3D=200;=0D=0A>=20=C2=A0=0D=0A>=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=
=A0=20=C2=A0/*=0D=0A>=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20*=20No=
t=20all=20the=20page=20cache=20can=20be=20freed,=20otherwise=20the=20system=
=20will=0D=0A>=20--=20=0D=0A>=202.17.1=0D=0A=0D=0A--=20=0D=0AMichal=20Hocko=
=0D=0ASUSE=20Labs=0D=0A