Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221227040925.1619833-1-sdonthineni@nvidia.com>
 <CAMj1kXG79-MxGJEwvnekqbVyeEMVHBfhNjwZkz91mMwv4-vT3Q@mail.gmail.com> <Y7NY+ba2USk7hEAx@mail.local>
In-Reply-To: <Y7NY+ba2USk7hEAx@mail.local>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Tue, 3 Jan 2023 10:18:06 +0100
Message-ID: <CAMj1kXHAYvGdGJN0rfEL2y1jRP8P5YotKMmCmx0h07vJP=YfBA@mail.gmail.com>
Subject: Re: [PATCH 1/1] efi: rtc: Enable SET/GET WAKEUP services as optional
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc:     Shanker Donthineni <sdonthineni@nvidia.com>,
        Alessandro Zummo <a.zummo@towertech.it>,
        linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-efi@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 2 Jan 2023 at 23:21, Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
>
> On 02/01/2023 11:47:11+0100, Ard Biesheuvel wrote:
> > On Tue, 27 Dec 2022 at 05:09, Shanker Donthineni <sdonthineni@nvidia.com> wrote:
> > >
> > > The current implementation of rtc-efi is expecting all the 4
> > > time services GET{SET}_TIME{WAKEUP} must be supported by UEFI
> > > firmware. As per the EFI_RT_PROPERTIES_TABLE, the platform
> > > specific implementations can choose to enable selective time
> > > services based on the RTC device capabilities.
> > >
> > > This patch does the following changes to provide GET/SET RTC
> > > services on platforms that do not support the WAKEUP feature.
> > >
> > > 1) Relax time services cap check when creating a platform device.
> > > 2) Clear RTC_FEATURE_ALARM bit in the absence of WAKEUP services.
> > > 3) Conditional alarm entries in '/proc/driver/rtc'.
> > >
> > > Signed-off-by: Shanker Donthineni <sdonthineni@nvidia.com>
> >
> > Queued as a fix in efi/urgent, thanks.
>
> This rather seems like an rtc heavy patch and the subject line is
> misleading. This should be rtc: efi:
> Also, I'm pretty sure this doesn't qualify as an urgent fix.
>

I'm happy to drop it from my tree, but please add a cc:stable so it
gets backported to v6.1 at least. Otherwise, EFI compliant systems
that implement get/set_time but not get/set_wakeup_time have no RTC at
all on any LTS kernel until a year from now, and this was never the
intent when we introduced the EFI_RT_PROPERTIES_TABLE.