Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp11659417rwl; Tue, 3 Jan 2023 02:49:50 -0800 (PST) X-Google-Smtp-Source: AMrXdXurNbVHGLgK/MDevcJhjwEtoF2/IbhB43Zk9cDdtwSDGowJworB2N1YZvHti0qPWjpwaGbA X-Received: by 2002:aa7:d513:0:b0:462:9baa:7507 with SMTP id y19-20020aa7d513000000b004629baa7507mr37777357edq.8.1672742990418; Tue, 03 Jan 2023 02:49:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672742990; cv=none; d=google.com; s=arc-20160816; b=UkjcaroHnlVwgAqEBzLoYYdfSRiYYTlSYr9RVg7fUTyMN6OO6xXUcG/d9qN39zvJ60 KCKD+AmvhhaRX36WzAqBKZEhp6SIgwfZgQEeQFWERdLh05PSG1RUHQ28IOSJ/+LBG5+/ 949EsOpBBWeTnpoRhP7nI5eSA9ugTMeYG2CR1asRdRJ2qW7wNbA0BmAm4HrWG8QHagsA ecK5xll4Y3wDjjulABSSR/u4/DYpDHWxUfOgAIgfb6jth5ivMwf0K+v7GN10CGIh8ONi Z9Z2PiIyyY7Lmmg2lm5gqwN+uY8jQmEHy/HcoSx+Td08wmDHDrk7vPSMPTDmoSPs1OD1 Op5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=kAOnfRQ7of64+BS9QAuBAKcdpFJCJGM4HVpBKI1Pc5o=; b=MXAZeVjsBqle6PxylHc5hVkOJVz1ZCEaMH+zkD1cX2MztAPK8+wg11eZYZGiUyhixS GiQTFNsq6V/KEDyNJecoFnLV55CvZZRFJH1wnuuK4tV+cYTbjVh3zarm82NnyPlzVeEL 6u7OzezdgCWBz37xc5EzfkyrDP6+zCsBguItcpeQlxk4fjE1KnZLA64EC3sQWpzBxDNs rQHR5kERChcoPwrVQvHOw8MafwwEbs7QTqRqHjrgsI6yd5GLirCmZcZzkMDZ89dtER8J CfZFjmgMjdOye1kCXmyWmIBO4TJETsZrC9xBtERfQkjtFGDNwoSJ8As3n4qTRbmla+Xw 3jLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DgefgNF+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id js10-20020a17090797ca00b007c0edce0846si29160220ejc.670.2023.01.03.02.49.36; Tue, 03 Jan 2023 02:49:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DgefgNF+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233135AbjACKi5 (ORCPT + 61 others); Tue, 3 Jan 2023 05:38:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230006AbjACKiz (ORCPT ); Tue, 3 Jan 2023 05:38:55 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5F7D232 for ; Tue, 3 Jan 2023 02:38:53 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A0034B80E63 for ; Tue, 3 Jan 2023 10:38:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 454CAC433D2; Tue, 3 Jan 2023 10:38:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672742331; bh=c3L9uY7EIC7vpSaHHn/bXVJdBylqPR5p2C8ZK3Etjuo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DgefgNF+4HirWsfutq/MzyV0ZMIyvwlwVnqaxoeHoMf6UtXs7WoAaAZGp9ER9dHtC XdzRqXeOeQRDI1bcM7CJkf66kDOfoWPUQgnOJLR1F/KaMQERZB4I2SCKtWIXqdqZjw 4RizqXan3DrRFexxrVx6oiI7nfdfIS8B4fLuPA4uQYb+0xN8w7P3x0B4EyZq+/kEjs UHtGk92bkgerQbFbfqKCdAHjnkncykTAQyqXtlzKc1TEHvAA7a6RyWpLiKHqzp0J0j 374oGqzoiGv/Dppzd+xsNC6KYJwefvuO/O3OU7SXC/b8D9Xj4YQhevqnOxfYgSVZlQ qJFHjhA20Jtew== Date: Tue, 3 Jan 2023 10:38:45 +0000 From: Lee Jones To: Tom Fitzhenry Cc: Neil Armstrong , Ondrej Jirman , Javier Martinez Canillas , Martijn Braam , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mfd: rk808: re-add rk808-clkout to RK818 Message-ID: References: <20230102111147.2580861-1-tom@tom-fitzhenry.me.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230102111147.2580861-1-tom@tom-fitzhenry.me.uk> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 02 Jan 2023, Tom Fitzhenry wrote: > Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which > dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe. > > This line was removed in commit 3633daacea2e > ("mfd: rk808: Permit having multiple PMIC instances"), but only from RK818. > > Changes in v2: > - Add a Fixes tag (Javier Martinez Canillas). > - Add Javier Martinez Canillas's Reviewed-by tag. > - Add Neil Armstrong's Acked-by tag. Change-logs should live under the "---" below. I'll ship this out for you this time. > Fixes: 3633daacea2e ("mfd: rk808: Permit having multiple PMIC instances") > Signed-off-by: Tom Fitzhenry > Reviewed-by: Javier Martinez Canillas > Acked-by: Neil Armstrong > --- > drivers/mfd/rk808.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. -- Lee Jones [李琼斯]