Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp11700320rwl; Tue, 3 Jan 2023 03:31:20 -0800 (PST) X-Google-Smtp-Source: AMrXdXuBy8ZqG9uKcVd+jO4clH1cBQuR6Y5jd9jYS4wy7oSkUq6I8hynvXi5s/RLb+NW/jpQhIH+ X-Received: by 2002:a05:6402:1759:b0:46c:f631:c0dc with SMTP id v25-20020a056402175900b0046cf631c0dcmr32789061edx.12.1672745480504; Tue, 03 Jan 2023 03:31:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672745480; cv=none; d=google.com; s=arc-20160816; b=zwge8CSKdDAvE4nNuOm7TYzYa5p7Pp8qmN9iiHLT7mchK3Fmu8Dkq0oXJmpO/RYdnf K4pcR42OMzAY9+zK3XR4vxshA+zKpeLBQvchepOBoGXpu0w6/DPNauip2NJoB4doVoCx VWHpTbT8Om7PZCf1gzbMn/ADJY/qMwVoSYwd67LAXn5BYwPIyydImCr6sYBWm27RnfSV k667VWSilxHn4TX3fxg4OvELExie9I5pfBBybosaKdf4kxrO7fJXOINmL7BFbyJsPNku dmAfuq+kYRrsyjqMmhoFcdROt+lX8W3MNVrkg32BnEPLZ7m/sUAIyhou91nFaibm7ZQK ZAiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=9F6aZ3k6Uhye47LxE4RyeSBdtzrIJE85Tpml9PfX3qg=; b=Y01TTKTRH428Rcvk2mWNhQV0ajcarBO9Rv0HeX5sJ6/mVHAMggKiJdd0sU5bgnYOZW vmfF1iubA9vuSSzgsaufwlv9gXFmz/T9//4GNu3RoI+S2MGpXnFdBGwK3KyqlxyHYao9 JLKw4B5RaXp7TRlaFnNfAxahz9mogXglj3OHo21ww+pw9fqUXOh6QDuHgE8IsRRuXsxS v0uFNZTtcT/eBDtbCWPYivtPZceyHZ42rdHOjVKM+/zPvq4EdQWP+kvfdX/RQg/wjhe/ D6MC4vrS8874zOvl6kEcdd9AvwmpfzugPUDqEdhx670vcpMPTOr7KKDGvfsUi9+KkR9m SKWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q16-20020a056402249000b0048567586e48si19934638eda.600.2023.01.03.03.31.05; Tue, 03 Jan 2023 03:31:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233186AbjACLES (ORCPT + 61 others); Tue, 3 Jan 2023 06:04:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237327AbjACLEB (ORCPT ); Tue, 3 Jan 2023 06:04:01 -0500 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6EB6FADF; Tue, 3 Jan 2023 03:03:59 -0800 (PST) Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4NmVGf0XJnz4f3lK9; Tue, 3 Jan 2023 19:03:54 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.127.227]) by APP4 (Coremail) with SMTP id gCh0CgBXwLOaC7RjvUsZBA--.2391S4; Tue, 03 Jan 2023 19:03:56 +0800 (CST) From: Yu Kuai To: tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yukuai1@huaweicloud.com, yi.zhang@huawei.com, yangerkun@huawei.com Subject: [PATCH] blk-cgroup: fix missing pd_online_fn() while activating policy Date: Tue, 3 Jan 2023 19:28:33 +0800 Message-Id: <20230103112833.2013432-1-yukuai1@huaweicloud.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: gCh0CgBXwLOaC7RjvUsZBA--.2391S4 X-Coremail-Antispam: 1UD129KBjvdXoWrKry5ur47Ar1kZFyfKr18AFb_yoW3ZFgE9a 4kZFyxtFsxAa1IkrnYyFyrXrZYkrW0qrW7WF93KryxAF1DJay2ya1agrnxWay7CFy3CFyr uFWqgr4ktr93ZjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbxkFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j 6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628v n2kIc2xKxwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F4 0E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFyl IxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxV AFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6rW3Jr0E3s1lIxAIcVC2z280aVAFwI0_ Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUb XdbUUUUUU== X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yu Kuai If the policy defines pd_online_fn(), it should be called after pd_init_fn(), like blkg_create(). Signed-off-by: Yu Kuai --- block/blk-cgroup.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index ce6a2b7d3dfb..4c94a6560f62 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -1455,6 +1455,10 @@ int blkcg_activate_policy(struct request_queue *q, list_for_each_entry_reverse(blkg, &q->blkg_list, q_node) pol->pd_init_fn(blkg->pd[pol->plid]); + if (pol->pd_online_fn) + list_for_each_entry_reverse(blkg, &q->blkg_list, q_node) + pol->pd_online_fn(blkg->pd[pol->plid]); + __set_bit(pol->plid, q->blkcg_pols); ret = 0; -- 2.31.1