Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a1143ca2-9460-f156-58a7-66072034559c@linaro.org>
Date:   Tue, 3 Jan 2023 12:42:49 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] nvmem: fix registration vs use race
Content-Language: en-US
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Hector Martin <marcan@marcan.st>
References: <E1pCdoY-0044aT-A5@rmk-PC.armlinux.org.uk>
 <bad6a162-3e82-2f5e-1822-23951b61450b@linaro.org>
 <Y7QVh8/LPQ7H8ehp@shell.armlinux.org.uk>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
In-Reply-To: <Y7QVh8/LPQ7H8ehp@shell.armlinux.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 03/01/2023 11:46, Russell King (Oracle) wrote:
> On Tue, Jan 03, 2023 at 11:30:36AM +0000, Srinivas Kandagatla wrote:
>>
>>
>> On 03/01/2023 09:42, Russell King (Oracle) wrote:
>>> The i.MX6 CPU frequency driver sometimes fails to register at boot time
>>> due to nvmem_cell_read_u32() sporadically returning -ENOENT.
>>>
>>> This happens because there is a window where __nvmem_device_get() in
>>> of_nvmem_cell_get() is able to return the nvmem device, but as cells
>>> have been setup, nvmem_find_cell_entry_by_node() returns NULL.
>>>
>>> The occurs because the nvmem core registration code violates one of the
>>> fundamental principles of kernel programming: do not publish data
>>> structures before their setup is complete.
>>>
>>> Fix this by making nvmem core code conform with this principle.
>>>
>> how about a Fixes tag and Cc stable?
> 
> Which commit do you suggest? This error goes all the way back to the
> inception of nvmem, commit
> 
> eace75cfdcf7 ("nvmem: Add a simple NVMEM framework for nvmem providers")
> 
> but clearly its going to be a lot of effort to backport it all the
> way due to all the changes.

I understand the backport issue, On the other hand as this a real issue 
backporting to atleast stable kernels would be worth.

--srini
>