Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <465bb512-2ea3-ebfc-4b21-7b493f019fc3@suse.com>
Date:   Tue, 3 Jan 2023 13:20:48 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [RFC PATCH 04/14] sound: usb: card: Introduce USB SND vendor op
 callbacks
To:     Wesley Cheng <quic_wcheng@quicinc.com>,
        Takashi Iwai <tiwai@suse.de>, Oliver Neukum <oneukum@suse.com>
Cc:     srinivas.kandagatla@linaro.org, mathias.nyman@intel.com,
        perex@perex.cz, broonie@kernel.org, lgirdwood@gmail.com,
        andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        gregkh@linuxfoundation.org, Thinh.Nguyen@synopsys.com,
        bgoswami@quicinc.com, tiwai@suse.com, robh+dt@kernel.org,
        agross@kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
        devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
        quic_jackp@quicinc.com, quic_plai@quicinc.com
References: <20221223233200.26089-1-quic_wcheng@quicinc.com>
 <20221223233200.26089-5-quic_wcheng@quicinc.com>
 <80f92635-6d14-8ff3-17ac-de2e5b977947@suse.com> <87lemqxpet.wl-tiwai@suse.de>
 <ec632e64-2d9c-3f71-4fe7-e1c6acb81393@quicinc.com>
Content-Language: en-US
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <ec632e64-2d9c-3f71-4fe7-e1c6acb81393@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dCtLN1RSTlY0Sk4rdXVuZjNsSW5lT0F4VjV5dS9VOXRPQnltbHdnN05iaW4r?=
 =?utf-8?B?Z0hmRnVuN250STJnWTFiMzRvZDNoZDZQcFRhTzlBZ2F5TDlaQ1VCanllU3pB?=
 =?utf-8?B?RHVtZHJ2RUtGdzI4TFdFcldIT1dmMFAraDI5Z0F6Z25vaCtLMUJWVWxhbXBB?=
 =?utf-8?B?Nk9BaTl5MHI5azBmNmdka2M1REx6ZE5pRUJzRGVHdC83Y04zZlRrM3JNaEJ5?=
 =?utf-8?B?OU0rVHYvNlpKUXJEK0QvdnM1UnY3L2U2UUxQZS93WDdxWWJWVS92TUQrYklG?=
 =?utf-8?B?eVB5Y0pDVEtBZWtzdDBaK1UwQURkdy8zWlg5ZVVIemdnVVFxMVFBV2s2ZUx2?=
 =?utf-8?B?UytMN1RjZmpicFlSOTFxQ1ZnQlFMbndoUHdKNXM1dzZndkVxQTA1OWNwWFcz?=
 =?utf-8?B?ZnhNK2h3SkM4WnM4YVppaFhwaWR3YUdsNVFqYkhyTUVjTHBYWUUrY0orNmIx?=
 =?utf-8?B?dWRZMC9VTjI2bndjRkJXZ0VGYllZNmUwU3NQUko0UlhrNG81QmRGbEtaM0Ru?=
 =?utf-8?B?NGJtSGRnRUh1YStDTXEyV29RM3d0SStoTFZrTHlYMUlPWDF3K1BBYVZQbis5?=
 =?utf-8?B?TjNzUFJOcGtlSHVncW1KQlM0bTFKODQ5bW5mU09SKzJUTzU0cjdvdU82SXdX?=
 =?utf-8?B?c0NXeDd5Zyt3QWFSZFZ0R0lJL2M4dk9HbWFEL1dhZVhpQzRNa2RRa2x0UVN0?=
 =?utf-8?B?UnJQU0MvcjNKMEJzdjRSK21KaW9TZEtDd01aS0o2emUrYTBKUERqblYwV2xv?=
 =?utf-8?B?Ty9mMSt4enRJUlBiQVkwSDE3NU16T1NPRG1BK3NwWWJIbnhhQUs2UkZIajZZ?=
 =?utf-8?B?dmNDNVNpNWtSU0hNNG5TbkVvZmM5MGdLdU45cG9XZG1qRmdoWFErNThWQVR0?=
 =?utf-8?B?UVV2b3ZJdnM1VmRWZWI3VHJLcko0ZHNGRnhiY1h2T3hEOEdxeHdXN2QzWko2?=
 =?utf-8?B?ZHFPL0JoWGFPbUdwRHBTYUJ5czJpQTI4ek1KVk1VTXlpTU5xVUplUGhyUWVV?=
 =?utf-8?B?SUVZVWtjUnVQR0s3a2E2UWJKRGhkUWZObUVIekFGYWlidEJkRkFtYzNIVExs?=
 =?utf-8?B?dzVSbmlIL0d2bUhpV04wOFBSdjNuMDhtb1hLSVlVZFVWd3gvTTVldTkxR1d1?=
 =?utf-8?B?ZDVMYW5MbzhNWGkyTVA5MXFZWEY0SnRzYktUSWdObEtyRUQyRFlNQnJHUzZN?=
 =?utf-8?B?aFBrZmtZOWZsaEU2NUtnMXRwRUR2cm1leThibm5IUSs4M0h5cTdTT2N5Qndw?=
 =?utf-8?B?cFpuK3dheU9EOUoyc1lka0xaSGpwR1hIZFFLYUhzVE1kRUM4eEU3dHozQzQr?=
 =?utf-8?B?UkFMRzhIZGR4cUZYOEhnd09EUXEyNUVRK1Q3c2NlU2N5bDhhcGE2NTBxSGcy?=
 =?utf-8?B?UU9HcWI0Zzltc1N6aS9ReitxajExMzlQc2RuTy9pVkp1SmFPNVRmZ2NzRmhq?=
 =?utf-8?B?eWJ6RnB3Z2w3eUR2dW5xV2RzNFlUR3F6NWdhS3BBTGpTRW45R1h4K21heG0x?=
 =?utf-8?B?NzgxUjFVb2NXbUppYjVqVmZudUVxOCtMbHl0YjA1T0FRaUVlSEVVR3gvdTNq?=
 =?utf-8?B?alhQa1VkLzFKZ0RUdW04eWxFM0tBUkFGUWhHL1FtZzJzMGx2UGJiL2srNVRu?=
 =?utf-8?B?TWRoQnREN3NFeXdZWWhQbldvQjNsWWRvN21EalZEdGZjemtxcVNpRW5nbkMr?=
 =?utf-8?B?QS9ucWJXdGF6aUFjdUE2dVZVYUJVMWl4SXByd1l4ejYvNDNQOG0zUXJtcUsr?=
 =?utf-8?B?TTgvUFo3a2xDWG5tQjNJQnBWY1NYQWtQaVBNVnBjSFhGOVpLQlNycXNwS0tj?=
 =?utf-8?B?YUxLTmdOY2ZRdjlyNXNmVlVTNnM3Q01YVmdkWXdPRERzd1B1Zlc4VW5lWWww?=
 =?utf-8?B?UUFPNnlnUU1qWXNTa3ZLRlc1SjZ2ZForMGM2QndhajFOcE50S3V5ZFRUMW9r?=
 =?utf-8?B?c0diMnFvd0dnSVRrdWNtYzVuNXRjTml5V3BsaEhjb3R5OFgzcW15WmxtYmRW?=
 =?utf-8?B?NE45WktQalJtS25MNXdLNjlUQ2R1V3M5dWFpZzZ6aGYybWdOYjNuTjFrMlNS?=
 =?utf-8?B?M2J0eFViSHV6YTdUNkxVRDRUVHpWbGdOTUtqbGk0TytXRnZvVlA4OUtnZldT?=
 =?utf-8?B?L1hrMVdmd2pzaHlsOUNuNnppUzFJZ09OTWo1VzdPSFhSUktYU0VraGhscHlI?=
 =?utf-8?Q?1uI4aEV2ELPjxeEhL1KtvUbo4MSg1ZfSMjkSRhp/EsUQ?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18498be1-603a-4602-b3bb-08daed84f3bb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2023 12:20:50.9633
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +olddsnOmrrb9vCuUrIphZtUSWiEsnobyju6NKwy8GukUWUpu8suj4BEQjiBe0PG2r5XFffFqPLc8xvGn1ATqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7233
X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 30.12.22 08:10, Wesley Cheng wrote:

> It may depend on how the offloading is implemented, but we do have a mechanism to force the audio stream off from the qc_usb_audio_offload. Regardless of if the UDEV is suspended first, or the USB backend, as long as we ensure that the offloading is disabled before entering suspend, I think that should be sufficient.

You would presumably output garbage, if the UDEV is asleep but the backend is not.

  
> The reset_resume() path is fine.  Bus reset is going to cause a disconnect() callback in the offload driver, in which we already have the proper handling for ensuring the offload path is halted, and we reject any incoming stream start requests.

How? If we go the reset_resume() code path, we find that usb-audio does not make
a difference between regular resume() and reset_resume()

	Regards
		Oliver