Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp11892023rwl; Tue, 3 Jan 2023 06:17:40 -0800 (PST) X-Google-Smtp-Source: AMrXdXsSUCr4HUABhRfnYK0rF1E+uS38QSm94CaNEEhWv2GO9VJtQ3tiJTBseO/9E5ow+DLp5OPr X-Received: by 2002:a17:90b:198f:b0:226:28aa:eb17 with SMTP id mv15-20020a17090b198f00b0022628aaeb17mr20375077pjb.11.1672755459766; Tue, 03 Jan 2023 06:17:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672755459; cv=none; d=google.com; s=arc-20160816; b=Jqk4nGBC6Ho3RMrKz8a/1gF3Z06dtIIfUDW2hNrmW977pRG5yh3ZHJf9spI5lN1eUH FWDd1pJdFbeMiB03cP3xnDRaSNpVGt9G7PoGYgOnpW+WTAoM/KMI8Dcyd+pwSJmJaOxJ QAPNM01KB+b1rdHRedxi+NQ+9PhaCUlmgIs0qeZcc5yGDKgk7Zcxvi9rrUxR8+NBkAo6 w8ris3m2dSHQeF7ts5pkKXNIQPRCgAs9wy2fP/Wl2Dh08Vu7ft4jWqxe1XVrsPmigEAz qJ13G+JXuQ+SseCZRQxWFPvslrFwL/6ONQmq5UNSDCt+z6FfRCnKfji3DrNuOM7QDZjm WgTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Kcq+Jczpstankfwo74FUwDr6LqImjmmhnHu9lOl6NDA=; b=peZ7z9NIvFcJNenpo8l1e1gkCEq84fmoCS3bH1zihcWhk80O8nFnygbzgzIcHoeoDm XUWZkywgj24nI9Cj1ZXVMsIjMTfrV96ofOEJLxsK0EunvQgGESyMB70NHBYpCMWpvKp3 pZp6+HadXxDm2YNNsGojF7gvM9W55Uh/gEGqnkrrvjodVp72rqwH0LumJAg4VMjjXulv zR9atiqTCdimakfJHRNFDBGDG+ubHCTA2lG5b3VO8sL6mIv42rlvd4815uBO/RyJ3nmm DdYxZwygIqP2w9VyKNGku6O6SugzBhG2vCzPtCR8HtZ5d6CxYP8bZY3biBTwmiSs2pUi isPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=mw5am7MM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oj10-20020a17090b4d8a00b00219d5a60401si27833068pjb.142.2023.01.03.06.17.28; Tue, 03 Jan 2023 06:17:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=mw5am7MM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237574AbjACOFr (ORCPT + 60 others); Tue, 3 Jan 2023 09:05:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237677AbjACOFX (ORCPT ); Tue, 3 Jan 2023 09:05:23 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEB2610579 for ; Tue, 3 Jan 2023 06:05:22 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 78E166767E; Tue, 3 Jan 2023 14:05:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1672754721; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kcq+Jczpstankfwo74FUwDr6LqImjmmhnHu9lOl6NDA=; b=mw5am7MMKojzHwNlLLuYKTmup5VdHLyMD28puc31TovXb4/WscvSWd/M9WhLLX9qXTEl59 c7G2w2o2wtlFI8PdjZw8csZmhp70Z+vYeeaLsa/Ks0xJFi3oFHhRJR6Hs1GUAR5I49oFX/ iVCyTO4+FfpVTYODrvPm8a+iplvnBdw= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 5D1D02C141; Tue, 3 Jan 2023 14:05:21 +0000 (UTC) Date: Tue, 3 Jan 2023 15:05:21 +0100 From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH printk v3 5/6] printk: introduce console_get_next_message() and console_message Message-ID: References: <20221221202704.857925-1-john.ogness@linutronix.de> <20221221202704.857925-6-john.ogness@linutronix.de> <875ydodjgs.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <875ydodjgs.fsf@jogness.linutronix.de> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 2023-01-03 11:08:27, John Ogness wrote: > On 2022-12-21, John Ogness wrote: > > +/** > > + * console_message - Container for a prepared console message. > > This documentation is not included in the kerneldocs, but it should at > least be proper kerneldoc format. It should be: > > * struct console_message - Container for a prepared console message. Great catch! Best Regards, Petr