Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <04c0adce-3850-aa73-6bad-a10973d83df3@gmail.com>
Date:   Tue, 3 Jan 2023 09:37:41 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH net] net: dpaa: Fix dtsec check for PCS availability
Content-Language: en-US
To:     Jiri Pirko <jiri@resnulli.us>
Cc:     Madalin Bucur <madalin.bucur@nxp.com>,
        "David S . Miller" <davem@davemloft.net>,
        Sean Anderson <sean.anderson@seco.com>, netdev@vger.kernel.org,
        Paolo Abeni <pabeni@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Christian Zigotzky <info@xenosoft.de>,
        linux-kernel@vger.kernel.org
References: <20230103065038.2174637-1-seanga2@gmail.com>
 <Y7PyStu4s79FAHWH@nanopsycho>
From:   Sean Anderson <seanga2@gmail.com>
In-Reply-To: <Y7PyStu4s79FAHWH@nanopsycho>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/3/23 04:15, Jiri Pirko wrote:
> Tue, Jan 03, 2023 at 07:50:38AM CET, seanga2@gmail.com wrote:
>> We want to fail if the PCS is not available, not if it is available. Fix
> 
> It is odd to read plural maiestaticus in patch desctiption :) Better to
> stick with describing what code does wrong and then telling the codebase
> what to do.

Writing a kernel is a collaborative effort :)

>> this condition.
>>
>> Fixes: 5d93cfcf7360 ("net: dpaa: Convert to phylink")
>> Reported-by: Christian Zigotzky <info@xenosoft.de>
>> Signed-off-by: Sean Anderson <seanga2@gmail.com>
> 
> Reviewed-by: Jiri Pirko <jiri@nvidia.com>