Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp12035007rwl; Tue, 3 Jan 2023 08:08:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXtSVy2ewDflg6XQxXGywq0gM6EcFr+nbNTMLWrF0PIHomtAZ8Ndk8MB310tpYw8oULh7tvf X-Received: by 2002:a05:6402:914:b0:479:dc9c:1144 with SMTP id g20-20020a056402091400b00479dc9c1144mr40850089edz.24.1672762101720; Tue, 03 Jan 2023 08:08:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672762101; cv=none; d=google.com; s=arc-20160816; b=Sfa2tvRQLn62RCTjZ57UBSupqSlrGcU9KaGH/Rl1vEzw2HYcPIrtt+Pdp+KYAMqZV1 3fIF2B4BT60mf+9SvFYFP930bNUY/zqDf7T80K7peooOMduLXVgz9ssRe5Cg4n7VHFze NgoVSzrExTVqp/5jgCWtz+WUR0agX4oniRBqirZSCh7OlwRmn13BO/3SHxEYqGDOnnA0 419vexhGSLuvziO39uBX/VsDTJtISxMuFE3WtIk11YM9XMnL+I7nHz47vjabXVMKa5e9 V7yopKLTpM0arhCiS1nEGrYhEo0oLNHqUYEhhH9Qx9zO2oIJCDBPIaANhZDd5Po48dUT cAGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=CAM6e8IG/Rz136eESNbi5w6bCfYR1ThQGHH2Xq5R+a4=; b=RukD8ZqK8ixZSFg+m3/XmfYWQlsFXkOp0yMIXCWRZDlO/GBuJ6W9+WNFiTwMjAo5F0 Eqyaz8D8HWY0SOG8jrMUTNs33ZYRq6R5/55hyupxTpiaKymeFi3iv6q06M9ql4wFaATk rwe6mpjfnnBLxOs1NmQbeT1Mpya/mUWb6W+or3JSCAM4gGwjboAhjvOcTpGWFsRYPwqC neeTxFu79oag0AlClGQveX5VLBl6AY53w43y8nHwwHjb8rQ2I24A/h9TJEuHPtQlrHKh 6w0j07EYLkWY5tjh/9YkFm3bIgSlTDS21le9ToD01mvR5dKm41GzpdIId9mjqFE0rqDz vTvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MWYw6ks3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h16-20020a056402281000b0047920cdf1ccsi33369142ede.73.2023.01.03.08.08.07; Tue, 03 Jan 2023 08:08:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MWYw6ks3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237995AbjACPtH (ORCPT + 61 others); Tue, 3 Jan 2023 10:49:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233158AbjACPtF (ORCPT ); Tue, 3 Jan 2023 10:49:05 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25D6912080; Tue, 3 Jan 2023 07:49:04 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 83AA461456; Tue, 3 Jan 2023 15:49:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6CEBC433EF; Tue, 3 Jan 2023 15:49:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672760943; bh=gOfiSj4aIN0UjAUIlvhoKrXaCz9kqH8r5kkeyMxL0JE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=MWYw6ks3uaa3yHBfwsKUWTwZX0tws+dtkzHPzulH/Zya6jWU4xUUPdR77Y4jTcXa2 pI338/eeFcAxjvMn1DROP2tWDQf/fWYz9f2m9zhB5cBVbm1NhQpBQGv7YnvCxvd85P E1oXVzNyvy8sxP4EikFSlnBEzFarygQDFOxD5jDxlVFX2T5cuF3bBc0/pKbImAsHcA 0TCLwsy0DUyeEVqZmNScl7iW1KJ2gDsGAKszNOhjZhcaJe6HNsrU/EWd/ppOfxeSQ+ vhVNartGqbxogEPuZ7aq38il6kHGCau22w4e5+U2UWGtuceVQ3clWG3zzOHBAajVqh JxFfQrv9S0nBA== From: Felipe Balbi To: JaeHun Jung , Greg Kroah-Hartman , Thinh Nguyen Cc: "open list:USB XHCI DRIVER" , open list , Seungchull Suh , Daehwan Jung , JaeHun Jung Subject: Re: [PATCH] usb: dwc3: Clear DWC3_EVENT_PENDING when count is 0 In-Reply-To: <20230102050831.105499-1-jh0801.jung@samsung.com> References: <20230102050831.105499-1-jh0801.jung@samsung.com> Date: Tue, 03 Jan 2023 17:48:58 +0200 Message-ID: <87cz7vvct1.fsf@balbi.sh> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, JaeHun Jung writes: > Sometimes very rarely, The count is 0 and the DWC3 flag is set has status. > It must not have these status. Because, It can make happen interrupt storming > status. > So, It have to clean up DWC3_EVENT_PENDING flags set when count is 0. > It means "There are no interrupts to handle.". > > (struct dwc3_event_buffer *) ev_buf = 0xFFFFFF883DBF1180 ( > (void *) buf = 0xFFFFFFC00DBDD000 = end+0x337D000, > (void *) cache = 0xFFFFFF8839F54080, > (unsigned int) length = 0x1000, > (unsigned int) lpos = 0x0, > (unsigned int) count = 0x0, > (unsigned int) flags = 0x00000001, > (dma_addr_t) dma = 0x00000008BD7D7000, > (struct dwc3 *) dwc = 0xFFFFFF8839CBC880, > (u64) android_kabi_reserved1 = 0x0), > > (time = 47557628930999, irq = 165, fn = dwc3_interrupt, latency = 0, en = 1), > (time = 47557628931268, irq = 165, fn = dwc3_interrupt, latency = 0, en = 3), > (time = 47557628932383, irq = 165, fn = dwc3_interrupt, latency = 0, en = 1), > (time = 47557628932652, irq = 165, fn = dwc3_interrupt, latency = 0, en = 3), > (time = 47557628933768, irq = 165, fn = dwc3_interrupt, latency = 0, en = 1), > (time = 47557628934037, irq = 165, fn = dwc3_interrupt, latency = 0, en = 3), > (time = 47557628935152, irq = 165, fn = dwc3_interrupt, latency = 0, en = 1), > (time = 47557628935460, irq = 165, fn = dwc3_interrupt, latency = 0, en = 3), > (time = 47557628936575, irq = 165, fn = dwc3_interrupt, latency = 0, en = 1), > (time = 47557628936845, irq = 165, fn = dwc3_interrupt, latency = 0, en = 3), > (time = 47557628937960, irq = 165, fn = dwc3_interrupt, latency = 0, en = 1), > (time = 47557628938229, irq = 165, fn = dwc3_interrupt, latency = 0, en = 3), > (time = 47557628939345, irq = 165, fn = dwc3_interrupt, latency = 0, en = 1), > (time = 47557628939652, irq = 165, fn = dwc3_interrupt, latency = 0, en = 3), > (time = 47557628940768, irq = 165, fn = dwc3_interrupt, latency = 0, en = 1), > (time = 47557628941037, irq = 165, fn = dwc3_interrupt, latency = 0, en = 3), > (time = 47557628942152, irq = 165, fn = dwc3_interrupt, latency = 0, en = 1), > (time = 47557628942422, irq = 165, fn = dwc3_interrupt, latency = 0, en = 3), > (time = 47557628943537, irq = 165, fn = dwc3_interrupt, latency = 0, en = 1), > (time = 47557628943806, irq = 165, fn = dwc3_interrupt, latency = 0, en = 3), > (time = 47557628944922, irq = 165, fn = dwc3_interrupt, latency = 0, en = 1), > (time = 47557628945229, irq = 165, fn = dwc3_interrupt, latency = 0, en = 3), > (time = 47557628946345, irq = 165, fn = dwc3_interrupt, latency = 0, en = 1), > (time = 47557628946614, irq = 165, fn = dwc3_interrupt, latency = 0, en = 3), > (time = 47557628947729, irq = 165, fn = dwc3_interrupt, latency = 0, en = 1), > (time = 47557628947999, irq = 165, fn = dwc3_interrupt, latency = 0, en = 3), > > Signed-off-by: JaeHun Jung Please get in the habit of running patches through scripts/get_maintainer.pl. If you did, it would tell you Thinh is the new maintainer for dwc3. -- balbi