Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757482AbXHTJMm (ORCPT ); Mon, 20 Aug 2007 05:12:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753374AbXHTJMd (ORCPT ); Mon, 20 Aug 2007 05:12:33 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:38054 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752964AbXHTJMc (ORCPT ); Mon, 20 Aug 2007 05:12:32 -0400 Date: Mon, 20 Aug 2007 12:12:30 +0300 (EEST) From: Pekka J Enberg To: Peter Zijlstra cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, David Miller , Andrew Morton , Daniel Phillips , Christoph Lameter , Matt Mackall , Lee Schermerhorn , Steve Dickson Subject: Re: [PATCH 04/10] mm: slub: add knowledge of reserve pages In-Reply-To: <1187595513.6114.176.camel@twins> Message-ID: References: <20070806102922.907530000@chello.nl> <20070806103658.603735000@chello.nl> <1187595513.6114.176.camel@twins> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 613 Lines: 18 Hi Peter, On Mon, 20 Aug 2007, Peter Zijlstra wrote: > -static struct page *new_slab(struct kmem_cache *s, gfp_t flags, int node) > +static struct page *new_slab(struct kmem_cache *s, gfp_t flags, int node, int *reserve) > { [snip] > + *reserve = page->reserve; Any reason why the callers that are actually interested in this don't do page->reserve on their own? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/