Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230103145023.40055-1-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20230103145023.40055-1-andriy.shevchenko@linux.intel.com>
From:   Guenter Roeck <groeck@google.com>
Date:   Tue, 3 Jan 2023 10:55:03 -0800
Message-ID: <CABXOdTdLFbi+-wUk1ohX+5bs01b0WX-MRSH9tUWD316vucpdmw@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] platform/chrome: cros_ec_proto: Use asm intead of asm-generic
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Tzung-Bi Shih <tzungbi@kernel.org>,
        Guenter Roeck <groeck@chromium.org>,
        chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org,
        Benson Leung <bleung@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jan 3, 2023 at 6:50 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> There is no point to specify asm-generic for the unaligned.h.
> Drop the 'generic' suffix.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Subject: s/intead/instead/

otherwise

Reviewed-by: Guenter Roeck <groeck@chromium.org>

> ---
>  drivers/platform/chrome/cros_ec_proto_test.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_proto_test.c b/drivers/platform/chrome/cros_ec_proto_test.c
> index c6a83df91ae1..08c58d031593 100644
> --- a/drivers/platform/chrome/cros_ec_proto_test.c
> +++ b/drivers/platform/chrome/cros_ec_proto_test.c
> @@ -5,7 +5,8 @@
>
>  #include <kunit/test.h>
>
> -#include <asm-generic/unaligned.h>
> +#include <asm/unaligned.h>
> +
>  #include <linux/platform_data/cros_ec_commands.h>
>  #include <linux/platform_data/cros_ec_proto.h>
>
> --
> 2.35.1
>