Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 3 Jan 2023 22:53:32 +0200
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     Ricardo Ribalda <ribalda@chromium.org>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Hans Verkuil <hverkuil@xs4all.nl>, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Hans Verkuil <hans.verkuil@cisco.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>
Subject: Re: [PATCH v3 0/8] Follow-up patches for uvc v4l2-compliance
Message-ID: <Y7SVzNGrpdWXmvuI@pendragon.ideasonboard.com>
References: <20220920-resend-v4l2-compliance-v3-0-598d33a15815@chromium.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220920-resend-v4l2-compliance-v3-0-598d33a15815@chromium.org>
Precedence: bulk

Hi Ricardo,

On Tue, Jan 03, 2023 at 03:36:18PM +0100, Ricardo Ribalda wrote:
> This patchset contains the fixes for the comments on "v10 of Fix
> v4l2-compliance errors series". In particular to the patches
> 
> -uvcvideo: uvc_ctrl_is_accessible: check for INACTIVE
> -uvcvideo: improve error handling in uvc_query_ctrl()
> 
> And the patch:
> -uvcvideo: Fix handling on Bitmask controls

I've applied 1/8 to 7/8 to my tree and pushed the result to
https://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux.git/log/?h=next/uvc.
You can submit a new version of 8/8 only based on that branch.

> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> To: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: linux-media@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hans Verkuil <hans.verkuil@cisco.com>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> 
> ---
> Changes in v3 (Thanks Laurent):
> - Add a new patch for refactoring __uvc_ctrl_add_mapping
> - Use standard names for menus
>   - Return error on uvc_mapping_get_menu_value
>   - Add const
>   - StyLe!
> - Do not return positive errors in uvc_query_ctrl()
>    - Improve commit message
> - improve error logging in uvc_query_ctrl()
>    - Fix comment
>    - Improve doc
> - Fix handling on Bitmask controls
>    - s/uvc/UVC
>    - Reflow comments to 80 chars
>    - Test with GET_RES first
>    - Remove clamp to (0,..)
> - Return -EACCES for Wrong state error
>    - Full rewrite of commit message
> - uvc_ctrl_is_accessible: check for INACTIVE
>    - Update commit message
>    - Remove try variable
>    - Update documentation
> - Implement mask for V4L2_CTRL_TYPE_MENU
>    - Include linux/bits.h
> - Link to v2: https://lore.kernel.org/r/20220920-resend-v4l2-compliance-v2-0-7c0942040004@chromium.org
> 
> Changes in v2:
> - Include "Get menu names from framework series"
>   https://lore.kernel.org/r/20220920-standard-menues-v2-0-a35af3243c2f@chromium.org
> - Link to v1: https://lore.kernel.org/r/20220920-resend-v4l2-compliance-v1-0-81364c15229b@chromium.org
> 
> ---
> Hans Verkuil (2):
>       media: uvcvideo: Check for INACTIVE in uvc_ctrl_is_accessible()
>       media: uvcvideo: improve error logging in uvc_query_ctrl()
> 
> Ricardo Ribalda (6):
>       media: uvcvideo: Return -EACCES for Wrong state error
>       media: uvcvideo: Do not return positive errors in uvc_query_ctrl()
>       media: uvcvideo: Fix handling on Bitmask controls
>       media: uvcvideo: Implement mask for V4L2_CTRL_TYPE_MENU
>       media: uvcvideo: Refactor __uvc_ctrl_add_mapping
>       media: uvcvideo: Use standard names for menus
> 
>  drivers/media/usb/uvc/uvc_ctrl.c   | 238 ++++++++++++++++++++++++++++---------
>  drivers/media/usb/uvc/uvc_driver.c |  10 +-
>  drivers/media/usb/uvc/uvc_v4l2.c   | 108 ++++++++++++-----
>  drivers/media/usb/uvc/uvc_video.c  |  15 +--
>  drivers/media/usb/uvc/uvcvideo.h   |   8 +-
>  include/uapi/linux/uvcvideo.h      |   4 +-
>  6 files changed, 281 insertions(+), 102 deletions(-)
> ---
> base-commit: 69b41ac87e4a664de78a395ff97166f0b2943210
> change-id: 20220920-resend-v4l2-compliance-4fdbe4fbd7b5

-- 
Regards,

Laurent Pinchart