Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp12538033rwl; Tue, 3 Jan 2023 16:25:19 -0800 (PST) X-Google-Smtp-Source: AMrXdXs/M2tpEalYP1qMUA/afYMHmtItzTGR1XCFkNNIP9UxLDL8W7zaRuivbHQpm2tV5L41G9Xd X-Received: by 2002:a05:6402:1d84:b0:482:2baf:622 with SMTP id dk4-20020a0564021d8400b004822baf0622mr34408520edb.20.1672791918830; Tue, 03 Jan 2023 16:25:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672791918; cv=none; d=google.com; s=arc-20160816; b=MsZtkI7UnosjemnZSeB59V4UqYRHi9jj3d8/PlELjiq0Al0x7npP5arX+mrwfGs/dh ivdimX/O5OQ/g16dgDjQT62Bb+1r4b9jh6HisaIaMrcz/QclF6GmGOiPwWEIphRCqQWI cEb11YcTnvVVRqlt5wv/Fx2+/HpIBH6HK1dueOapSjGENs1L36/aAQGyWP3vhCJO9iMY wIqvVcinaDZw44wY3dkKwbTiFv+gls0KmY5b2ZfnY5cCLOz5BF/4b9Zho4gtHXqHbabI W0eA51HLixAsl/GW6ZB8E5h/+I7LQabmq4bV7CHB3Hs9ee00/KqplRKih6K8NZdyXUgj 5Rhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=hQ/lWA2u673qQ3zZUAqUhxWgXqekzo4IW91NihIOMao=; b=ZmGm5veFv5r0eaw3e/CXERnv63+SNm/uUXIhynUOMDr1wCg8vf9+y1B2+mIW3W+eUo umuyXyIZxK8T2xWyehm7NR7LtX5VJ2pcMLy9gE5FJjtf3UFh6fmTzM4rM9vPFgaPOJHg ImRp/LX/2FFt0cUlB3YZ6cMDfgUlikjs3O/iE8WdwDzojx7TXvd902qbvZaygnHQcCCf A7LhM1YNlT800P/gF+NEA+z6Eo+X41wLMz7tN8o0a8qj/PkMY7qbl5xTS3kG0cYSM9mH Z3B+fSrOCLUO0HBcQWmsVvVUbeJZ/8qXIuEIYhFT4sUsmPrYe0mNA9s78bBc9jQ6zPZl 5qHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FMXhuV3K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sc24-20020a1709078a1800b007c079eed73csi30598911ejc.416.2023.01.03.16.25.03; Tue, 03 Jan 2023 16:25:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FMXhuV3K; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230247AbjADAOS (ORCPT + 57 others); Tue, 3 Jan 2023 19:14:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233096AbjADAOQ (ORCPT ); Tue, 3 Jan 2023 19:14:16 -0500 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8F5F13F2D for ; Tue, 3 Jan 2023 16:14:15 -0800 (PST) Received: by mail-yb1-xb2d.google.com with SMTP id 192so34923713ybt.6 for ; Tue, 03 Jan 2023 16:14:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hQ/lWA2u673qQ3zZUAqUhxWgXqekzo4IW91NihIOMao=; b=FMXhuV3K2ARtmgPHeUhmZFz7Ug53ziDjO+cCjXO9HNwnsX8S02ay2252oFhhss3762 z96s/0ZsfKsPyffy3FeMV2aZh0HgEnBAJa0VLdJRnYIaU5PRaFPYAMATDB1t6MYDA6Zl 94nTVRaQ7ACXOSVNgpmXUtakqKwKJuKCTVgf/ti26nwyFIxfHGzr3362F+FoWXPCk2kQ RAjKwD4tkQ4U1pOHiKEG0aoXTFaCYQoVqv2DEjBwpMWsGPC925H7LUAI7iMT+TzwWQwl Jmu0JLGmSKqQQThJAiU0SVYeKoBpMOjHDvNQ6OFGEdueQYAvDH11SgcJc7JoyC7YLl0X EOlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hQ/lWA2u673qQ3zZUAqUhxWgXqekzo4IW91NihIOMao=; b=JKBrTsLi3SBspp5cOWYexd8vml6t0uuSiHVgOPWtflFWKkY6oD+4AajvJaHE+oxWXA MKUkb5Er84yi8GIwmtGz2sCWSHUZ5gVOmrJdLk4Jd0tslEr8Kdq2OlAkTKqgeaYpEUE4 C+ChNzapZf9+XMpsZeb5lU+FrHjAsqQ1nYRQ0bONEpOlbMm7NtLQNeiMZlZwaHoMC09m 9AAT5OghniuBBPWGiRbhmIzdfmA+qb+vkSAIGtSBW8AN+UI4Wt457/IBPWSs11fqBOq8 WtLoFbLOGx6Oa7zKQ8/5CaUY6wFQlEM5+YTF1fNZcDArgR5cWqJgr+EIt9Xv82UmSu35 /UOg== X-Gm-Message-State: AFqh2kodOgzZyCw9YTIQELJTe67Ld48/Dz5UqWXScx1HB7HNsyrSUF8T frVt+/9p0CZVcUM2qP2Or84rSBEbunxg76u0UzJRi/s15cLi3rwa X-Received: by 2002:a25:8e8e:0:b0:6fa:a54e:9276 with SMTP id q14-20020a258e8e000000b006faa54e9276mr3560320ybl.460.1672791254909; Tue, 03 Jan 2023 16:14:14 -0800 (PST) MIME-Version: 1.0 References: <20221215165728.2062984-1-arnd@kernel.org> In-Reply-To: From: Linus Walleij Date: Wed, 4 Jan 2023 01:14:03 +0100 Message-ID: Subject: Re: [PATCH] usb: fotg210: fix OTG-only build To: Daniel Palmer Cc: Arnd Bergmann , Arnd Bergmann , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 2, 2023 at 7:10 AM Daniel Palmer wrote: > Maybe a little unrelated to this patch but this IP is also used on the > MStar/SigmaStar chips I actually think Arnd Bergmann at one point sent me a device with this line of chips in it. I suppose you will be upstreaming this support? > (albeit only the host (FUSBH200) part that used > to have its own driver that got removed at some point...) Sorry for reading this after sending out my latest changes, here: https://lore.kernel.org/linux-usb/20230103-gemini-fotg210-usb-v1-0-f2670cb4a492@linaro.org/T/#t The first patch in this series differentiates between FOTG200 and FOTG210, do you mean to say there is rather FUSBH200 as well? There is also FUSB220... (Faraday used to have datasheets on their webpage but I can't access them anymore.) > For what it's worth I could not get this driver to function correctly > with UVC cameras etc and was fed up with hacking it apart to try to > get it to work when it's mostly a copy/paste of an old copy of the > common EHCI driver. > So I added some extra quirks to the common EHCI driver to allow it to > run this IP too and deleted the custom driver in my tree (hence the > conflicts..). > > I'm not sure how using the common EHCI driver works with the OTG part > but if it's possible to make that work maybe my way is a better > solution than trying to maintain this driver? That's a good point, do you have a pointer to your EHCI quirk patch so I can take a look? Yours, Linus Walleij